Prompt to store cards and identities

[samsymons]

Task/Issue URL: https://app.asana.com/0/0/1201938691568506/f
Tech Design URL:
CC: @brindy

Description:

This PR updates the macOS browser to support saving and storing payment methods and identities.

Steps to test this PR:

1. Test that prompting to save credentials still works as expected.
2. Test that prompting to save payment methods works as expected. You can use this site to test.
3. Test that prompting to save identities works as expected. I've been using the Amazon address form to test this, but Emanuele might have suggestions for other ways to test.
4. Test that disabling the three new settings in preferences causes each of these prompt types to no longer appear.
5. Test that the Settings gear icon on each prompt takes you to preferences.

Test websites:

• Payment Methods: https://codepen.io/jadepreis/full/aZmPBY
• Identities: https://www.roboform.com/filling-test-all-fields (hitting enter on this form will trigger it, as long as you have enough information)

Testing checklist:

• Test with Release configuration

---

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

[samsymons]

Don't love this function signature, am open to suggestions.

[ayoy]

Technically we can do this:

identity.addressStreet
    .flatMap(NSTextField.label(titled:))
    .map(identityStackView.addArrangedSubview(_:))

Here we use Optional.flatMap which is a no-op for .none and otherwise produces a non-optional NSTextField, which is then added to the stack view using map. And then we don't need optionalLabel and a variant of addArrangedSubview that takes an optional. We can even go further and do this:

[
    identity.addressStreet,
    identity.addressStreet2, 
    identity.addressCity,
    identity.addressProvince,
    identity.addressPostalCode,
    identity.addressCountryCode
]
    .forEach { value in
        value.flatMap(NSTextField.label(titled:))
            .map(identityStackView.addArrangedSubview(_:))
    }

I personally consider such code "clever", which does not necessarily mean "good", so it's a matter of deciding if we think it's understandable to the reader. Perhaps it's a valid alternative to having optionalLabel kind of API :)

[brindy]

1. https://www.roboform.com/filling-test-all-fields
   Saw this form create a prompt once, but couldn't get it to do it again even after clearing data and running a clean build. It also didn't offer to re-fill them when I came back to the page when I did have some data saved.

2. Disabling the prompts worked, but turning them on again I wasn't getting prompts for the address or credit cards. Also tried fire button and restarting the browser.

3. Would be good if the test outline had some definitive test sites we can use. That might mean creating them in our privacy test pages if there aren't some good public ones.

Looks like Emanuelle also has some issue so going to leave this for now. Ping me when it's ready for another look

[ayoy]

LGTM! I tested it in various ways and it does the job[0] 🚀 Great stuff! Please have a look into my comments for a possible alternative to optionalLabel.

[0] - Actually, I found that the CC info is not saved on Catalina. Saving identities and passwords work fine. On Big Sur it all works fine. I believe it's something on the JS side though, what do you think? Having said that, the Logins+ UI on Catalina has more issues (not related to this project) - perhaps it's just a separate topic to handle with a separate project. Or it will wait until we drop Catalina support 🤔

[samsymons]

Good catch on the Catalina issue, I took a look through the code and also think that this is something on the JS side. This is one I'm going to write up as a separate task before merging, and then try to set up my spare laptop with Catalina so that I can test it later in the week.

Catalina support is something I would personally love to drop, it causes us quite a few headaches 😩

[samsymons]

I've written up a task for myself to get 10.15 set up and to do a deep dive into Logins+ issues, starting with this CC issue you found. 🙂 I've set it due Wednesday, but it might be later in the week depending on how busy the next couple days are.

[samsymons]

The push build is failing on a test that is known to be flaky, but the PR build has succeeded. I ran this test locally, and confirmed tests are green (log attached). I'm going to run this one more time just in case, but if it fails again I'm going to merge it.

Test DuckDuckGo Privacy Browser_2022-03-28T21-42-39.txt