Remove mouse event listeners on browser close #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonathanKingston I changed the base so this is part of RC1 today |
tomasstrba
requested review from
tomasstrba
and removed request for
bwaresiak
tomasstrba
requested changes
Feb 28, 2022
| @@ -85,6 +85,11 @@ final class BrowserTabViewController: NSViewController { | |||
| addMouseMonitors() | |||
| } | |||
|
|
|||
| override func viewWillDisappear() { | |||
There was a problem hiding this comment.
I know it was previously like this, but safer is to call addMouseMonitors() in viewWillAppear().
The reason is viewWillAppear and viewWillDisappear are called multiple times during the lifecycle of the view controller. viewDidLoad() just once
|
I would like to compile another build for testing so I speed up this PR a bit by doing the requested change myself. I will ask someone else to review |
brindy
approved these changes
Feb 28, 2022
tomasstrba
force-pushed
the
jkt/remove-mouse-listeners-browsertab
branch
from
30ff977 to
ffc23e0
Compare
samsymons
added a commit
that referenced
this pull request
Mar 2, 2022
# By Tomas Strba (6) and others # Via GitHub (1) and Tomas Strba (1) * develop: Logins+ authentication (#438) Update privacy dashboard to main (#451) Version 0.19.1 Remove mouse event listeners on browser close (#448) Find in Page Hotfix + refactoring of forced unwrapping (#450) Memory leak fixed (#449) Version 0.19.0 Top autofill (#432) Option to add new notes or edit existing is disabled (#446) Use our own autoconsent fork (#444) New Feedback Form (#424) Update privacy dashboard (#440) # Conflicts: # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/SecureVault/View/PasswordManager.storyboard
samsymons
added a commit
that referenced
this pull request
Mar 4, 2022
* develop: Logins+ authentication (#438) Update privacy dashboard to main (#451) Version 0.19.1 Remove mouse event listeners on browser close (#448) Find in Page Hotfix + refactoring of forced unwrapping (#450) Memory leak fixed (#449) Version 0.19.0 Top autofill (#432) Option to add new notes or edit existing is disabled (#446) Use our own autoconsent fork (#444)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199178362774117/1201889534538164/f
Tech Design URL:
CC:
Description:
Fixes browser restart click handler issue.
Steps to test this PR:
Please describe the issue in as much detail as possible.:
At steps 4 and 6, clicking doesn't should now work.
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM