Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update privacy dashboard #440

Merged
merged 5 commits into from
Feb 24, 2022
Merged

Update privacy dashboard #440

merged 5 commits into from
Feb 24, 2022

Conversation

SlayterDev
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1163321984198618/1201722757273633/f
Tech Design URL:
CC:

Description:
This PR updates privacy dashboard and BSK to include fixes with tracker attribution

Steps to test this PR:

  1. Visit news.google.com
  2. Dashboard should show "We only found trackers owned by Google"
  3. Visit cnn.com
  4. Disable protections
  5. Dashboard should show Trackers owned by site and "## trackers found"
  6. Dashboard should show all trackers blocked and show trackers from WarnerMedia as owned by the site
  7. Visit banfacialrecognition.com
  8. No trackers should be reported

Testing checklist:

  • Test with Release configuration

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@brindy brindy self-assigned this Feb 24, 2022
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good against that revision. Feel free to merge once you update to point at the tagged BSK.

@brindy brindy assigned SlayterDev and unassigned brindy Feb 24, 2022
@SlayterDev SlayterDev merged commit eb24a6e into develop Feb 24, 2022
@SlayterDev SlayterDev deleted the brad/fix-dash-trackers-found branch February 24, 2022 19:16
samsymons added a commit that referenced this pull request Feb 25, 2022
# By Sam Macbeth (2) and others
# Via GitHub
* develop:
  Top autofill (#432)
  Option to add new notes or edit existing is disabled (#446)
  Use our own autoconsent fork (#444)
  New Feedback Form (#424)
  Update privacy dashboard (#440)
  Fix crash when background tabs trigger cookie popup (#439)
  Update clickToLoadConfig.json (#435)
  rename weakAssign to assign(to:onWeaklyHeld:) (#442)
  Improve Safari favorite importing (#436)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Mar 2, 2022
# By Tomas Strba (6) and others
# Via GitHub (1) and Tomas Strba (1)
* develop:
  Logins+ authentication (#438)
  Update privacy dashboard to main (#451)
  Version 0.19.1
  Remove mouse event listeners on browser close (#448)
  Find in Page Hotfix + refactoring of forced unwrapping (#450)
  Memory leak fixed (#449)
  Version 0.19.0
  Top autofill (#432)
  Option to add new notes or edit existing is disabled (#446)
  Use our own autoconsent fork (#444)
  New Feedback Form (#424)
  Update privacy dashboard (#440)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	DuckDuckGo/SecureVault/View/PasswordManager.storyboard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants