Fix crash when background tabs trigger cookie popup #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The webview may not have a window when we run this code.
brindy
approved these changes
Feb 24, 2022
There was a problem hiding this comment.
LGTM, thanks. I couldn't get it to crash, but please create a follow up task to consider rearchitecting this. Ideally these script implementations should be platform agnostic - e.g if we want to re-use this on iOS right now we'd have to edit it before moving it into BSK.
samsymons
added a commit
that referenced
this pull request
Feb 25, 2022
# By Sam Macbeth (2) and others # Via GitHub * develop: Top autofill (#432) Option to add new notes or edit existing is disabled (#446) Use our own autoconsent fork (#444) New Feedback Form (#424) Update privacy dashboard (#440) Fix crash when background tabs trigger cookie popup (#439) Update clickToLoadConfig.json (#435) rename weakAssign to assign(to:onWeaklyHeld:) (#442) Improve Safari favorite importing (#436) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The webview may not have a window when we run this code.
Task/Issue URL: https://app.asana.com/0/1163321984198618/1201869397036687/f
Tech Design URL:
CC:
Description:
Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM