Improve Safari favorite importing #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# By Alexey Martemyanov (2) and others # Via GitHub (1) and Tomas Strba (1) * develop: Fix crash on SecureVault corruption (#417) ensure app usage is sent (#429) Fix non-debug builds (#428) new tds url (#430) Sparkle 1.27.1 (#411) Disable CVDisplayLing logging (#421) Version 0.18.7 # Conflicts: # DuckDuckGo/Menus/MainMenuActions.swift
* develop: Set BrowserServicesKit to 8.0.2.
samsymons
commented
Feb 23, 2022
samsymons
commented
Feb 23, 2022
| return | ||
| } | ||
| topFavorites = Array(favorites.prefix(Constants.maxNumberOfFavorites).reversed()) |
There was a problem hiding this comment.
We now import bookmarks and display them in a consistent order, so they don't need to be reversed on the Home Screen.
brindy
approved these changes
Feb 23, 2022
jonathanKingston
pushed a commit
that referenced
this pull request
Feb 25, 2022
Task/Issue URL: https://app.asana.com/0/1177771139624306/1201796758953738/f Tech Design URL: CC: Description: This PR makes a few changes: A new Reset Bookmarks option has been added to the Debug menu - happy testing Bookmarks are now sorted from oldest to newest, matching how other browsers work Safari favorites are correctly marked when importing The resulting folder structure now depends on which browser you import from. Safari imports all bookmarks to the root level, except favorites, whereas others import all bookmarks to the root level except for their "other bookmarks" folders. The end goal of this change was to make the imported bookmark structure match the source browser as closely as possible. This isn't always possible - for instance, Chromium browsers don't have the concept of a favorite bookmark - but we've tried to get closer. Steps to test this PR: Import bookmarks from all supported browsers and verify that bookmarks are in the same order that they are in the browser you imported from
samsymons
added a commit
that referenced
this pull request
Feb 25, 2022
# By Sam Macbeth (2) and others # Via GitHub * develop: Top autofill (#432) Option to add new notes or edit existing is disabled (#446) Use our own autoconsent fork (#444) New Feedback Form (#424) Update privacy dashboard (#440) Fix crash when background tabs trigger cookie popup (#439) Update clickToLoadConfig.json (#435) rename weakAssign to assign(to:onWeaklyHeld:) (#442) Improve Safari favorite importing (#436) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1201796758953738/f
Tech Design URL:
CC:
Description:
This PR makes a few changes:
The end goal of this change was to make the imported bookmark structure match the source browser as closely as possible. This isn't always possible - for instance, Chromium browsers don't have the concept of a favorite bookmark - but we've tried to get closer.
Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM