Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate blocklist url #430

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Separate blocklist url #430

merged 1 commit into from
Feb 17, 2022

Conversation

jdorweiler
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/inbox/11472677167854/1201796464179828/1201806214353011
Tech Design URL:
CC:

Description:

Switching to a separate blocklist url. This one removes all cnames until we decide on a fix.

Steps to test this PR:

  1. Load some sites with trackers, blocking should be working as expected
  2. Try to toggle protections off on a site, reload time should be much faster (~2sec for me)

Testing checklist:

  • Test with Release configuration
Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

SlayterDev
SlayterDev approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@SlayterDev SlayterDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely lovely 👏

@jdorweiler jdorweiler merged commit 01b55fa into develop Feb 17, 2022
@jdorweiler jdorweiler deleted the jd/new-tds-url branch February 17, 2022 19:37
samsymons added a commit that referenced this pull request Feb 18, 2022
@samsymons
Merge branch 'develop' into sam/logins-filtering-and-sorting
bc04eb4 
# By Jason (1) and Sam Symons (1)
# Via GitHub
* develop:
  Fix non-debug builds (#428)
  new tds url (#430)

# Conflicts:
#	DuckDuckGo/AppDelegate/AppDelegate.swift
samsymons added a commit that referenced this pull request Feb 18, 2022
@samsymons
Merge branch 'sam/logins-filtering-and-sorting' into sam/logins-authe…
b663971 
…ntication

* sam/logins-filtering-and-sorting:
  Ensure that items within sections are sorted correctly.
  Re-enable a SwiftLint warning fix.
  Fix non-debug builds (#428)
  new tds url (#430)
samsymons added a commit that referenced this pull request Feb 18, 2022
@samsymons
Merge branch 'develop' into sam/macos-12-crash-report-handling
979e0c6 
* develop:
  Fix non-debug builds (#428)
  new tds url (#430)
  Sparkle 1.27.1 (#411)
  Disable CVDisplayLing logging (#421)
  Update Fire Popover graphics (#426)
  Version 0.18.7
  Refresh the address bar when reloading (#413)
  Fix tabs leakage after Drag-Drop (#423)
  Point to BrowserServicesKit 8.0. (#425)
  Import error improvements (#406)
  Replace Burn and Fireproof icons (#416)
  don't disable the UI unless onboarding has been marked as finished (#420)
  fix nested RunLoop waiting (#422)
  Version 0.18.6
samsymons added a commit that referenced this pull request Feb 21, 2022
@samsymons
Merge branch 'develop' into sam/import-safari-favorites-correctly
9a82995 
# By Alexey Martemyanov (2) and others
# Via GitHub (1) and Tomas Strba (1)
* develop:
  Fix crash on SecureVault corruption (#417)
  ensure app usage is sent (#429)
  Fix non-debug builds (#428)
  new tds url (#430)
  Sparkle 1.27.1 (#411)
  Disable CVDisplayLing logging (#421)
  Version 0.18.7

# Conflicts:
#	DuckDuckGo/Menus/MainMenuActions.swift
jonathanKingston pushed a commit that referenced this pull request Feb 25, 2022
@jdorweiler @jonathanKingston
new tds url (#430)
82914a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SlayterDev SlayterDev SlayterDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdorweiler @SlayterDev