Fix Catalina onboarding lock up #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mallexxx
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
Controls disabling not reproduced after this change: 9bcee10#r66152340
Still, LGTM
samsymons
added a commit
that referenced
this pull request
Feb 9, 2022
# By Alexey Martemyanov (2) and others # Via GitHub * develop: Replace Burn and Fireproof icons (#416) don't disable the UI unless onboarding has been marked as finished (#420) fix nested RunLoop waiting (#422) Version 0.18.6 Tweaks of suggestions and autocomplete (#403) Bump privacy dashboard to latest version (#409) Point to the latest BrowserServicesKit branch. (#414) # Conflicts: # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Feb 18, 2022
* develop: Fix non-debug builds (#428) new tds url (#430) Sparkle 1.27.1 (#411) Disable CVDisplayLing logging (#421) Update Fire Popover graphics (#426) Version 0.18.7 Refresh the address bar when reloading (#413) Fix tabs leakage after Drag-Drop (#423) Point to BrowserServicesKit 8.0. (#425) Import error improvements (#406) Replace Burn and Fireproof icons (#416) don't disable the UI unless onboarding has been marked as finished (#420) fix nested RunLoop waiting (#422) Version 0.18.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/392891325557410/1201737990269948
Tech Design URL:
CC: @bstandaert-ddg
Description:
Don't disable the UI unless onboarding has been marked as finished
Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM