Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Burn and Fireproof icons #416

Merged
merged 4 commits into from
Feb 8, 2022
Merged

Replace Burn and Fireproof icons #416

merged 4 commits into from
Feb 8, 2022

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Feb 3, 2022

Task/Issue URL: https://app.asana.com/0/1177771139624306/1201296605067758/f
Tech Design URL:
CC:

Description:
Replaces Burn and Fireproof icons to match mobile versions

Steps to test this PR:

  1. Validate Burn icon matches mobile
  2. Validate More Menu->Fireproof icon is ok
  3. Validate Save Password Dialog -> Not Now -> Fireproofing Alert icon matches the menu icon

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@tomasstrba tomasstrba self-assigned this Feb 4, 2022
Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
Just curious, why aren't we matching fireproof icon with iOS too?
Screen Shot 2022-02-04 at 10 45 22

EDIT: Everything good, the problem was lack of caffeine in my head

@mallexxx mallexxx merged commit 89c48e5 into develop Feb 8, 2022
@mallexxx mallexxx deleted the alex/fire-button branch February 8, 2022 05:03
samsymons added a commit that referenced this pull request Feb 9, 2022
# By Alexey Martemyanov (2) and others
# Via GitHub
* develop:
  Replace Burn and Fireproof icons (#416)
  don't disable the UI unless onboarding has been marked as finished (#420)
  fix nested RunLoop waiting (#422)
  Version 0.18.6
  Tweaks of suggestions and autocomplete (#403)
  Bump privacy dashboard to latest version (#409)
  Point to the latest BrowserServicesKit branch. (#414)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Feb 18, 2022
* develop:
  Fix non-debug builds (#428)
  new tds url (#430)
  Sparkle 1.27.1 (#411)
  Disable CVDisplayLing logging (#421)
  Update Fire Popover graphics (#426)
  Version 0.18.7
  Refresh the address bar when reloading (#413)
  Fix tabs leakage after Drag-Drop (#423)
  Point to BrowserServicesKit 8.0. (#425)
  Import error improvements (#406)
  Replace Burn and Fireproof icons (#416)
  don't disable the UI unless onboarding has been marked as finished (#420)
  fix nested RunLoop waiting (#422)
  Version 0.18.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants