Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh the address bar when reloading page #413

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

tomasstrba
Copy link
Contributor

Task/Issue URL:
https://app.asana.com/0/1177771139624306/1201687230162679/f
https://app.asana.com/0/1177771139624306/1201703099650430/f

Description:
Matching the address bar behavior when refreshing page with other browsers.

Steps to test this PR:

  1. Load a website
  2. Type something into address bar
  3. Refresh the page
  4. Make sure the address bar contains URL of the currently loaded website

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@samsymons samsymons self-assigned this Feb 2, 2022
Copy link
Collaborator

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomasstrba tomasstrba merged commit 21a6c4c into develop Feb 11, 2022
@tomasstrba tomasstrba deleted the tom/reload-address-bar-fix branch February 11, 2022 16:11
samsymons added a commit that referenced this pull request Feb 12, 2022
* develop:
  Update Fire Popover graphics (#426)
  Refresh the address bar when reloading (#413)
  Fix tabs leakage after Drag-Drop (#423)
samsymons added a commit that referenced this pull request Feb 13, 2022
* develop:
  Update Fire Popover graphics (#426)
  Refresh the address bar when reloading (#413)
  Fix tabs leakage after Drag-Drop (#423)
samsymons added a commit that referenced this pull request Feb 18, 2022
* develop:
  Fix non-debug builds (#428)
  new tds url (#430)
  Sparkle 1.27.1 (#411)
  Disable CVDisplayLing logging (#421)
  Update Fire Popover graphics (#426)
  Version 0.18.7
  Refresh the address bar when reloading (#413)
  Fix tabs leakage after Drag-Drop (#423)
  Point to BrowserServicesKit 8.0. (#425)
  Import error improvements (#406)
  Replace Burn and Fireproof icons (#416)
  don't disable the UI unless onboarding has been marked as finished (#420)
  fix nested RunLoop waiting (#422)
  Version 0.18.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants