Fix non-debug builds #428
Merged
Fix non-debug builds #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
commented
Feb 16, 2022
| ProcessInfo.processInfo.environment["XCTestConfigurationFilePath"] != nil | ||
| #else | ||
| return false |
There was a problem hiding this comment.
This call now just returns false if we're not in a DEBUG configuration.
samsymons
added a commit
that referenced
this pull request
Feb 18, 2022
* develop: Fix non-debug builds (#428) new tds url (#430) Sparkle 1.27.1 (#411) Disable CVDisplayLing logging (#421) Update Fire Popover graphics (#426) Version 0.18.7 Refresh the address bar when reloading (#413) Fix tabs leakage after Drag-Drop (#423) Point to BrowserServicesKit 8.0. (#425) Import error improvements (#406) Replace Burn and Fireproof icons (#416) don't disable the UI unless onboarding has been marked as finished (#420) fix nested RunLoop waiting (#422) Version 0.18.6
samsymons
added a commit
that referenced
this pull request
Feb 21, 2022
# By Alexey Martemyanov (2) and others # Via GitHub (1) and Tomas Strba (1) * develop: Fix crash on SecureVault corruption (#417) ensure app usage is sent (#429) Fix non-debug builds (#428) new tds url (#430) Sparkle 1.27.1 (#411) Disable CVDisplayLing logging (#421) Version 0.18.7 # Conflicts: # DuckDuckGo/Menus/MainMenuActions.swift
jonathanKingston
pushed a commit
that referenced
this pull request
Feb 25, 2022
* Update the conditional check around `isRunningTests`. * Fix SwiftLint warning. * Silence Xcode warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1201834657842440/f
Tech Design URL:
CC:
Description:
This PR updates a new conditional that was added to
isRunningTeststo support compiling for configurations other thanDEBUG.Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM