Fix crash on SecureVault corruption #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mallexxx
force-pushed
the
alex/fix-secure-vault-crash
branch
from
8b11d5c to
775917a
Compare
|
Btw, I have not been ignoring this review, I'm just monitoring the discussion on duckduckgo/BrowserServicesKit#60. :) |
bwaresiak
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
I've tested changes from BSK: Bookmark/Login import, startup, corrupted DB and lack of storage space, looks good to me!
@samsymons since @mallexxx is out, can you double check and merge if it looks good to you?
samsymons
approved these changes
Feb 20, 2022
samsymons
added a commit
that referenced
this pull request
Feb 21, 2022
# By Alexey Martemyanov (2) and others # Via GitHub (1) and Tomas Strba (1) * develop: Fix crash on SecureVault corruption (#417) ensure app usage is sent (#429) Fix non-debug builds (#428) new tds url (#430) Sparkle 1.27.1 (#411) Disable CVDisplayLing logging (#421) Version 0.18.7 # Conflicts: # DuckDuckGo/Menus/MainMenuActions.swift
jonathanKingston
pushed a commit
that referenced
this pull request
Feb 25, 2022
* Fix crash and data import on Secure Vault corruption * update BSK rev * update BSK rev * SecureVault error reporting * Update to BrowserServicesKit 8.0.1. Co-authored-by: Sam Symons <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1201649423461236/f
Tech Design URL:
CC: @samsymons
Description:
Fixes crash and data import on SecureVault corruption
Steps to test this PR:
0. Corrupt database file at ~/Library/Containers/com.duckduckgo.macos.browser[.debug]/Data/Library/Application Support/Vault/Vault.db
throw errorat DefaultDatabaseProvider.swift:75)throw error, validate database file is recreated and logins/data import work normallysee also: duckduckgo/BrowserServicesKit#60
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM