Fix video fullscreen exit crash #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mallexxx
force-pushed
the
alex/fix-fullscreen-crash
branch
from
bc2e86a to
e9d9ebe
Compare
tomasstrba
requested changes
Nov 3, 2021
|
@tomasstrba could you take a look again at this please |
tomasstrba
approved these changes
Feb 18, 2022
| @@ -20,6 +20,12 @@ import Cocoa | |||
| import Combine | |||
| import os.log | |||
|
|
|||
| #if DEBUG | |||
There was a problem hiding this comment.
In general this is a bad technique. The point of #if DEBUG #else is to resolve the condition during the compilation. When using isDebugBuild both branches are part of the binary.
I can't see a usage of isDebugBuild, was it merged by mistake? (it was previously there and I remember refactoring it)
| @@ -170,4 +170,13 @@ final class WebView: WKWebView { | |||
| inspectorPerform("showResources") | |||
| } | |||
|
|
|||
| var fullscreenWindowController: NSWindowController? { | |||
| guard let fullscreenWindowController = self.window?.windowController, | |||
| fullscreenWindowController.className.contains("FullScreen") | |||
samsymons
added a commit
that referenced
this pull request
Feb 22, 2022
jonathanKingston
pushed a commit
that referenced
this pull request
Feb 25, 2022
* Fix crash on fullscreen exit * fix resizing * trying to fix Xcode 13.0 compatibility * Xcode 13.1 fix * Unit tests fixed for macOS 12 * fix tab switching * Fix window closing when video playing in full screen * cleanup Co-authored-by: Tomas Strba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199237043630360/1201203279491064/f
Tech Design URL:
CC: @tomasstrba @samsymons
Description:
Fixes crash when fullscreen playing Tab/Window is closed
Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM