Cookie prompt management

[sammacbeth]

Task/Issue URL: https://app.asana.com/0/72649045549333/1201033079931464/f
Tech Design URL: https://app.asana.com/0/481882893211075/1201233831195884/f
CC: @tomasstrba

Description:
Implements cookie prompt management using @cliqz/autoconsent. This is currently without a UI as the design project is not yet underway, but I'm opening this PR to get early feedback on the implementation.

We're running that library in a background Webview and exposing an API for it to native code. This API allows:

• Checking if there's a consent provider we understand on a specific tab.
• Checking if the popup is being displayed on the tab.
• Clicking through the popup to opt the user out.
• Testing if the page has correctly stored the opt-out.

The JS code component is currently in the Submodules folder as a simple project which provides the glue between the native messaging and autoconsent library. This is not currently an actual git submodule, but it could make sense to have it as one if we wish to using this implementation on iOS too.

Steps to test this PR:

1. Visit theguardian.com
2. The consent popup should be automatically opted out of.

The test page in duckduckgo/privacy-test-pages#65 has a more comprehensive set of test pages.

Testing checklist:

• Test with Release configuration

---

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

[tomasstrba]

Sam, please, would you like to have this reviewed?

[sammacbeth]

@tomasstrba I've just added remote config support, so I think it's good to go through a round of review. Thanks!

[tomasstrba]

@sammacbeth, thanks for creating this PR for getting the feedback sooner! 👍 In general, it is pretty good, I only found few tips for making the code more readable and maintainable in the future.

Plus, there are few inconsistencies in file management:

1. autoconsent folder shouldn't be commited to Submodules if it isn't true git submodule.

2. There are inconsistencies between Xcode file structure and real file structure (Autoconsent folder, Submodules folder). Ideally, it should be the same.

[sammacbeth]

Thanks for the review @tomasstrba. I've addressed your inline comments. I've also:

• Added unit-tests for config.featureEnabled.
• Added integration tests for the feature. These depend on Add autoconsent test page privacy-test-pages#65 being merged before they will pass.
• Fixed CMP checking for the first page load (previously there was a race when the background page wasn't get ready for the API calls).

Regarding file managment:

1. I put this code in the Submodules folder as I imagine it could easily become a submodule if we decide to add this to iOS too. However in the meantime it could be somewhere else. Should I just create a new directory in the root for it, or nest it inside DuckDuckGo/Autoconsent? I'm not sure what the convention should be for code which should not be bundled in the build (e.g. node_modules folder).
2. This is related to the first point. The autoconsent submodule contains files in dist which should be included in the browser bundle (so we can load the background page and userscript). Is there a way to make that happen without adding them to the DuckDuckGo/Autoconent folder in Xcode?

[brindy]

Sorry for butting in, but I've added a few comments to help make this clear and align with our (granted implied) code style.

[tomasstrba]

@sammacbeth, sorry for later responses to your questions:

1. Ideally, we include another repo as submodule and use the code from there. Is the code currently copied from somewhere?
2. Please see "Copy Bundle Resources" phase in Xcode, where you can specify what is copied into the bundle.

.

[tomasstrba]

Sam, this is really nice code! 🥇 🎖️

Please, could merge develop into this branch so I can compile with the latest Xcode? Then I will test the functionality.

[tomasstrba]

@sammacbeth, nice work! 👏 Can't wait to have this feature live 🚀

Code in general looks good and I like the architecture. There are few polishing tips so the style is aligned with Swift conventions. Sorry if they are a bit annoying

The feature worked for me after visiting theguardian.com, unfortunately these are the issues I found:

• After loading of the website, there is a period of time I can't do anything with the site. It feels like the main thread is blocked, but only the current webview seems to be unresponsive
• If you open a new tab, start loading theguardian.com and immediately switch the tab, you still get "Popups managed" info
• After popup is dismissed, the website scroll position is reset to the beginning (probably known issue)

[tomasstrba]

LGTM! 🚀 🚀 🚀

Thanks for making the code more readable! If all reviews including the product review are finished, feel free to merge 🥇

Good job! 👏