Import error improvements

[samsymons]

Task/Issue URL:
Tech Design URL:
CC: @brindy

Description:

This PR makes some small tweaks to the import code to squash some errors:

1. Browsers are no longer displayed in the list of import targets if they are installed but have no available profiles. In development, this would trip an assertion failure, and in production it led to a weird state where it just gave you a blank screen.
2. The Chrome importer now shows the name of each profile if you have multiple available
3. Firefox no longer gives you an error if you import from it, but have no logins. Now it counts as a successful import of 0 logins

Steps to test this PR:

1. Install Brave, but don't launch it. If you already have it installed, delete it and its application support directory, and reinstall it. Then, open the importer and check that it isn't visible.

2. Now launch Brave, and open the importer again. Check that it is present in the list – try to import from it, you should get a successful import of 0 logins and bookmarks.

3. Create multiple profiles in Chrome, and open the importer; check that the profile list shows the expected names

4. Delete all of your Firefox logins (or, optionally, go to ~/Library/Application Support/Firefox/Profiles in Finder and drill down into the default release profile, then delete logins.json) and run the importer. It should give you a successful import of 0 logins

Testing checklist:

• Test with Release configuration

---

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

[samsymons]

@bstandaert-ddg This one will be of interest to you - I'd love if you were able to take some time to try and break the import flow 🙂

[bstandaert-ddg]

Will do! The original issue I had is definitely fixed now.

After making a second profile in Brave, the DDG importer is showing more profiles than I actually have:

Perhaps profile 2 and "testing custom profile" are the same thing?

[bstandaert-ddg]

Also, password import from Brave doesn't seem to be working, at least with this multi-profile setup. Here, I have a password saved in profile 1, but DDG shows "0 passwords" no matter which profile I import from: https://drive.google.com/file/d/11a2FWJl0hWei8nte5a9deaYOXsCv88kN/view

[samsymons]

@bstandaert-ddg Thanks! Good spot on the profiles thing, I wasn't seeing that with Chrome but let me muck about with multiple Brave profiles more and see what happens. Might pull the trigger on this BrowserProfile code update after all.

[samsymons]

Finally catching up on this after a busy week last week. It looked like Chromium defines a System Profile directory which contains the new Preferences file that the importer is looking for, but it isn't user facing.

Going to ignore it when importing – nice catch @bstandaert-ddg! Look for a commit some time tomorrow that fixes the issues you found.

[samsymons]

@bstandaert-ddg This is now updated, are you able to take another look to verify that you don't see the extra profile? I'm curious to see if you're still having problems importing logins from Brave - I was able to import some logins just now successfully.

[bstandaert-ddg]

Sorry for the delay here. The profile list looks correct now. Importing passwords seems to be working now also 🤷

[brindy]

LGTM! The code in the FileStoreMock looks hairy, but given it's for testing I'm not too worried.