onboarding updates #398

brindy · 2022-01-14T13:28:15Z

Task/Issue URL: https://app.asana.com/0/392891325557410/1201320333982195
Tech Design URL:
CC:

Description:

Empty states for bookmark popover and manager UI
Empty state for logins+
Additional info screen for the data importer
Text typing animation
Design updates for onboarding
Add manual trigger for re-triggering the onboarding about:welcome

Notes:

Typing animation should be good on macOS 12, but before that the word wrapping might be obvious. We're OK with that.

Steps to test this PR:

Check empty states for bookmark popover and manager UI
Check empty state for logins+
Check additional info screen for the data importer shown for Chromium and Firefox when importing logins (button should change to 'next' when logins is selected)
Check text typing animation during onboarding, confirm that clicking anywhere skips typing on the current screen and shows the buttons
Check manual trigger for re-triggering the onboarding about:welcome and confirm works as expected in "clean" install scenario

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj

…r into brindy/onboarding-v2

… prevent typing when the user comes back to this view after completing the onboarding

# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj

DuckDuckGo/Bookmarks/Extensions/NSPopUpButtonExtension.swift

samsymons

LGTM, no real issues here – ran through all of the new features and it all looks great. Only a couple small things:

Unit tests are failing
I definitely see these errors you mentioned, even though the app compiles. A few errors about AppKit types not being available, but clearly they are. Xcode 13.2 issue I guess
The Import button spacing feels a little cramped. I would expect it to have the same spacing as the title/description text have between each other. That said, if this is consistent with the design then please ignore this 🙂
We show the Chrome Keychain password copy even if the app does have access to the key (i.e. has been granted permission in the past), meaning that we tell users they'll be prompted but then they aren't. Pretty minor in the grand scheme of things, and to be honest I'm inclined to keep the copy anyway – better to always explain what's happening with user data at sensitive as this.

samsymons · 2022-01-16T23:51:52Z

I also still see the text jumping around in the typing animation but that's a known issue related to having emoji in the strings yeah? I forget where you got to on that issue sorry.

brindy · 2022-01-19T18:42:12Z

Addressed (or deliberately ignored) all your points. :)

This is ready for another review, please :)

brindy · 2022-01-19T21:39:42Z

@bstandaert-ddg any chance you can give this a bit of a hammering if you've got time, please?

samsymons · 2022-01-19T22:43:14Z

DuckDuckGo/Onboarding/View/DaxSpeech.swift

+            let chars = Array(text)
+            let untypedChars = chars[Array(typedText).count ..< chars.count]
+            let combined = NSMutableAttributedString(string: typedText)
+            combined.append(NSAttributedString(string: String(untypedChars), attributes: [


For some reason this just reminded me that there's a new attributed string API in macOS 12. Not really relevant here, but I'm excited to be able to use it one day.

samsymons

New changes look good. I bashed on the import flow a bunch and tested importing, canceling early, etc. Nothing seems to be blocking onboarding from progressing now, and the changes to the importer all worked for me. 🙂

bstandaert-ddg · 2022-01-20T04:32:59Z

@brindy If I type about:welcome, once I get to the import step and click "import", the browser crashes:

Perhaps related, Xcode is showing me these weird errors:

(My usual approach to making xcode happy is git submodule update + clean build folder, but that doesn't seem to be working here)

Any ideas?

brindy · 2022-01-20T11:05:36Z

@bstandaert-ddg

Absolutely no idea 😬

Could try nuking your DerivedData folder:

Do Cmd-Shift-K in Xcode to do a clean inside the IDE
Close Xcode
Delete the DerivedData folder with this command rm -rf ~/Library/Developer/Xcode/DerivedData
Open Xcode
Build and Run

I'm on Xcode 13.2.1 if that matters.

Also that screenshot looks unfamiliar - where in the Xcode UI is that from?

Finally, I presume you have at least one of those browsers installed?

bstandaert-ddg · 2022-01-21T00:15:49Z

Thanks for the suggestion. The Xcode errors are gone now, but it's still crashing when I try to import. Will take a look later and see if I can figure out why.

bstandaert-ddg · 2022-01-21T01:38:08Z

The crash I was seeing turned out to be unrelated to this PR. Made an asana task: https://app.asana.com/0/1199178362774117/1201696927820456/f

Will get back to testing this shortly.

samsymons

Bashed on the changes to the importer a bit and looked over the design changes, looks good!

bstandaert-ddg · 2022-01-21T20:58:01Z

I don't see any issues either!

One tiny question: If I click "import", then "cancel" from within the dialog, the welcome page moves on to the next step (default browser). Is that expected, or should it stay on the import step until I click "maybe later"?

…ground ends up small behind it

brindy · 2022-01-24T13:28:42Z

Thanks @bstandaert-ddg - it's consistent with the set default one too. Possibly worth creating a follow up task for.

* develop: Version 0.18.5 support privacy config for clickToLoad (#407) Automatically select available login (#405) initial FB Click to Load (WIP) (#329) onboarding updates (#398) Version 0.18.4 Configuration of Sparkle - Setting SUAllowsAutomaticUpdates to NO (#404) Hide downloads button if the popover is opened/closed manually (#397)

# By Alexey Martemyanov (20) and others # Via Tomas Strba (2) and others * develop: (63 commits) Tweaks of suggestions and autocomplete (#403) Bump privacy dashboard to latest version (#409) Point to the latest BrowserServicesKit branch. (#414) Move embedded TDS from BSK to platform repo (#412) Image of shield with dot replaced (#410) Expand Fireproofing to include Local Storage and IndexedDB (#408) Version 0.18.5 support privacy config for clickToLoad (#407) Automatically select available login (#405) initial FB Click to Load (WIP) (#329) onboarding updates (#398) Version 0.18.4 Configuration of Sparkle - Setting SUAllowsAutomaticUpdates to NO (#404) Hide downloads button if the popover is opened/closed manually (#397) Textfield of the homepage is empty and unfocused right after switching to the homepage (#400) Remove navigatorCredentials (#392) Remove GPC header if it exists when not needed (#366) Version 0.18.3 Fireproofing encrypted storage (#332) Fix Lock Screen UI issues (#399) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo/Crash Reports/Model/CrashReportSender.swift

brindy added 17 commits January 10, 2022 11:29

use specific text item for button label

af00040

allow onboarding to be re-triggered

15fe85c

add way to determine content based on common URls

63228eb

add empty state for logins, move some images around

87c79e1

launch the import from the empty state

309fda9

Merge branch 'develop' into brindy/onboarding-v2

7c08f5e

# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj

empty state for bookmarks. reorg images again

a47d2cd

Merge branch 'develop' of github.com:more-duckduckgo-org/macos-browse…

aed34bf

…r into brindy/onboarding-v2

move text above the icon for the animation

75fc52a

fix button margins

16e6828

enable speech typing animation

a57d611

use non blank space to avoid wrapping the emoji onto its own line and…

aeea42a

… prevent typing when the user comes back to this view after completing the onboarding

empty states and launching of import

be80889

use show func to display importer

ef80a72

add place holder for more info screen

bb46f96

show more info text

df91dfb

Merge branch 'develop' into brindy/onboarding-v2

a229eea

# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj

brindy requested a review from samsymons January 14, 2022 13:28

brindy commented Jan 14, 2022

View reviewed changes

DuckDuckGo/Bookmarks/Extensions/NSPopUpButtonExtension.swift Show resolved Hide resolved

samsymons approved these changes Jan 16, 2022

View reviewed changes

brindy added 4 commits January 18, 2022 16:22

fix unit tests

4b50bde

use attributed string on macos 12 for best typing animation

aa3d839

update copy and fix import bug

5251198

support themes properly in dax text

cf38af7

brindy assigned samsymons Jan 19, 2022

Merge branch 'develop' into brindy/onboarding-v2

7545d1a

brindy changed the title ~~onboarding updates (wip)~~ onboarding updates Jan 19, 2022

use completion to progress onboarding after import

49d5d9c

samsymons reviewed Jan 19, 2022

View reviewed changes

samsymons approved these changes Jan 19, 2022

View reviewed changes

brindy added 3 commits January 21, 2022 12:07

clean up and tweak animation delay

616f44b

update based on design review feedback

b824951

change cancel to a back button

0753f1a

samsymons approved these changes Jan 21, 2022

View reviewed changes

brindy added 3 commits January 24, 2022 11:08

layer a background on the skip button so that it looks ok if the back…

6a4a659

…ground ends up small behind it

Merge branch 'develop' into brindy/onboarding-v2

c7c5dd0

use a fixed background to avoid transparency problems

68c32c1

brindy merged commit 9bcee10 into develop Jan 24, 2022

brindy deleted the brindy/onboarding-v2 branch January 24, 2022 16:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

onboarding updates #398

onboarding updates #398

brindy commented Jan 14, 2022 •

edited

Loading

samsymons left a comment

samsymons commented Jan 16, 2022

brindy commented Jan 19, 2022

brindy commented Jan 19, 2022

samsymons Jan 19, 2022

samsymons left a comment

bstandaert-ddg commented Jan 20, 2022 •

edited

Loading

brindy commented Jan 20, 2022 •

edited

Loading

bstandaert-ddg commented Jan 21, 2022

bstandaert-ddg commented Jan 21, 2022

samsymons left a comment •

edited

Loading

bstandaert-ddg commented Jan 21, 2022

brindy commented Jan 24, 2022

onboarding updates #398

onboarding updates #398

Conversation

brindy commented Jan 14, 2022 • edited Loading

Internal references:

samsymons left a comment

Choose a reason for hiding this comment

samsymons commented Jan 16, 2022

brindy commented Jan 19, 2022

brindy commented Jan 19, 2022

samsymons Jan 19, 2022

Choose a reason for hiding this comment

samsymons left a comment

Choose a reason for hiding this comment

bstandaert-ddg commented Jan 20, 2022 • edited Loading

brindy commented Jan 20, 2022 • edited Loading

bstandaert-ddg commented Jan 21, 2022

bstandaert-ddg commented Jan 21, 2022

samsymons left a comment • edited Loading

Choose a reason for hiding this comment

bstandaert-ddg commented Jan 21, 2022

brindy commented Jan 24, 2022

brindy commented Jan 14, 2022 •

edited

Loading

bstandaert-ddg commented Jan 20, 2022 •

edited

Loading

brindy commented Jan 20, 2022 •

edited

Loading

samsymons left a comment •

edited

Loading