Update to the latest BSK branch #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
commented
Feb 3, 2022
Comment on lines
-66
to
-74
| }, | ||
| { | ||
| "package": "TrackerRadarKit", | ||
| "repositoryURL": "https://github.com/duckduckgo/TrackerRadarKit.git", | ||
| "state": { | ||
| "branch": null, | ||
| "revision": "5f4caf35b8418700a48c64c7c61eb43308c8dacc", | ||
| "version": "1.0.3" | ||
| } |
There was a problem hiding this comment.
I don't entirely follow why this was removed by Xcode - the app still builds and runs fine, and running Resolve Package Versions doesn't bring it back. 🤷
mallexxx
approved these changes
Feb 3, 2022
samsymons
added a commit
that referenced
this pull request
Feb 9, 2022
# By Alexey Martemyanov (2) and others # Via GitHub * develop: Replace Burn and Fireproof icons (#416) don't disable the UI unless onboarding has been marked as finished (#420) fix nested RunLoop waiting (#422) Version 0.18.6 Tweaks of suggestions and autocomplete (#403) Bump privacy dashboard to latest version (#409) Point to the latest BrowserServicesKit branch. (#414) # Conflicts: # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Feb 18, 2022
# By Alexey Martemyanov (20) and others # Via Tomas Strba (2) and others * develop: (63 commits) Tweaks of suggestions and autocomplete (#403) Bump privacy dashboard to latest version (#409) Point to the latest BrowserServicesKit branch. (#414) Move embedded TDS from BSK to platform repo (#412) Image of shield with dot replaced (#410) Expand Fireproofing to include Local Storage and IndexedDB (#408) Version 0.18.5 support privacy config for clickToLoad (#407) Automatically select available login (#405) initial FB Click to Load (WIP) (#329) onboarding updates (#398) Version 0.18.4 Configuration of Sparkle - Setting SUAllowsAutomaticUpdates to NO (#404) Hide downloads button if the popover is opened/closed manually (#397) Textfield of the homepage is empty and unfocused right after switching to the homepage (#400) Remove navigatorCredentials (#392) Remove GPC header if it exists when not needed (#366) Version 0.18.3 Fireproofing encrypted storage (#332) Fix Lock Screen UI issues (#399) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo/Crash Reports/Model/CrashReportSender.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1201761380785255/f
Tech Design URL:
CC: @bwaresiak
Description:
This PR updates the app to point to the latest BSK branch.
This was changed earlier today to point to duckduckgo/BrowserServicesKit#58 for testing purposes, but the change had been merged before the custom branch had been swapped back to friends-and-family. This PR fixes that 🙂
Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM