support privacy config for clickToLoad #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
ladamski
requested review from
samsymons and
tomasstrba
and removed request for
samsymons and
tomasstrba
ladamski
force-pushed
the
la/support-ctl-privacy-config
branch
from
605d4c5 to
44f504f
Compare
samsymons
added a commit
that referenced
this pull request
Jan 31, 2022
# By Lucas Adamski (1) and others # Via Tomas Strba * develop: Version 0.18.5 support privacy config for clickToLoad (#407) Automatically select available login (#405) # Conflicts: # DuckDuckGo/SecureVault/Model/PasswordManagementItemListModel.swift # DuckDuckGo/SecureVault/View/PasswordManagementItemList.swift # DuckDuckGo/SecureVault/View/PasswordManagementViewController.swift
samsymons
added a commit
that referenced
this pull request
Feb 1, 2022
* develop: Version 0.18.5 support privacy config for clickToLoad (#407) Automatically select available login (#405) initial FB Click to Load (WIP) (#329) onboarding updates (#398) Version 0.18.4 Configuration of Sparkle - Setting SUAllowsAutomaticUpdates to NO (#404) Hide downloads button if the popover is opened/closed manually (#397)
samsymons
added a commit
that referenced
this pull request
Feb 18, 2022
# By Alexey Martemyanov (20) and others # Via Tomas Strba (2) and others * develop: (63 commits) Tweaks of suggestions and autocomplete (#403) Bump privacy dashboard to latest version (#409) Point to the latest BrowserServicesKit branch. (#414) Move embedded TDS from BSK to platform repo (#412) Image of shield with dot replaced (#410) Expand Fireproofing to include Local Storage and IndexedDB (#408) Version 0.18.5 support privacy config for clickToLoad (#407) Automatically select available login (#405) initial FB Click to Load (WIP) (#329) onboarding updates (#398) Version 0.18.4 Configuration of Sparkle - Setting SUAllowsAutomaticUpdates to NO (#404) Hide downloads button if the popover is opened/closed manually (#397) Textfield of the homepage is empty and unfocused right after switching to the homepage (#400) Remove navigatorCredentials (#392) Remove GPC header if it exists when not needed (#366) Version 0.18.3 Fireproofing encrypted storage (#332) Fix Lock Screen UI issues (#399) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo/Crash Reports/Model/CrashReportSender.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1201730253863268/f
Tech Design URL:
CC:
Description:
Support privacy config for ClickToLoad, requires these to land:
duckduckgo/BrowserServicesKit#56
duckduckgo/privacy-configuration#113
Currently this is failing because it needs
clickToPlayto be added to the BSK branch in duckduckgo/BrowserServicesKit#56Steps to test this PR:
You can also test with the local embedded config but you will need to disable the remotely fetched version which will override it (https://github.com/more-duckduckgo-org/macos-browser/blob/develop/DuckDuckGo/ContentBlocker/macos-config.json)
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM