Automatically select available login #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: Textfield of the homepage is empty and unfocused right after switching to the homepage (#400)
|
This doesn't work for me on a site with a "www." prefix: Screen.Recording.2022-01-24.at.4.17.42.PM.movI think what's happening is that the login panel removes the prefix before saving the login, but it's being compared to the tab domain that still has the prefix included. |
|
@bstandaert-ddg Yep, you're right, that's exactly what's happening. The matching logic is weak right now, and I think we need to do a better job of being more lenient regarding which credentials this functionality matches against. I'm gonna put something together and get you & Brindy to take another look. Thanks! |
|
@bstandaert-ddg Made a change to fix the issue you were seeing, what do you think? |
brindy
approved these changes
Jan 27, 2022
|
Looks good! |
samsymons
added a commit
that referenced
this pull request
Jan 31, 2022
# By Lucas Adamski (1) and others # Via Tomas Strba * develop: Version 0.18.5 support privacy config for clickToLoad (#407) Automatically select available login (#405) # Conflicts: # DuckDuckGo/SecureVault/Model/PasswordManagementItemListModel.swift # DuckDuckGo/SecureVault/View/PasswordManagementItemList.swift # DuckDuckGo/SecureVault/View/PasswordManagementViewController.swift
samsymons
added a commit
that referenced
this pull request
Feb 1, 2022
* develop: Version 0.18.5 support privacy config for clickToLoad (#407) Automatically select available login (#405) initial FB Click to Load (WIP) (#329) onboarding updates (#398) Version 0.18.4 Configuration of Sparkle - Setting SUAllowsAutomaticUpdates to NO (#404) Hide downloads button if the popover is opened/closed manually (#397)
samsymons
added a commit
that referenced
this pull request
Feb 18, 2022
# By Alexey Martemyanov (20) and others # Via Tomas Strba (2) and others * develop: (63 commits) Tweaks of suggestions and autocomplete (#403) Bump privacy dashboard to latest version (#409) Point to the latest BrowserServicesKit branch. (#414) Move embedded TDS from BSK to platform repo (#412) Image of shield with dot replaced (#410) Expand Fireproofing to include Local Storage and IndexedDB (#408) Version 0.18.5 support privacy config for clickToLoad (#407) Automatically select available login (#405) initial FB Click to Load (WIP) (#329) onboarding updates (#398) Version 0.18.4 Configuration of Sparkle - Setting SUAllowsAutomaticUpdates to NO (#404) Hide downloads button if the popover is opened/closed manually (#397) Textfield of the homepage is empty and unfocused right after switching to the homepage (#400) Remove navigatorCredentials (#392) Remove GPC header if it exists when not needed (#366) Version 0.18.3 Fireproofing encrypted storage (#332) Fix Lock Screen UI issues (#399) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo/Crash Reports/Model/CrashReportSender.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1201228737296484/f
Tech Design URL:
CC: @brindy
Description:
This PR changes the Logins+ popover to automatically select existing credentials if you're on an existing domain that has them.
We can only do the automatic scrolling with SwiftUI on macOS 11+, so for 10.15 the existing filtering logic has been retained.
Steps to test this PR:
PasswordManagementViewController'sviewDidAppearmethod, swap the calls in the macOS 11 availability check and run the above two tests again, verify that the old search bar filtering logic is still usedTesting checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM