-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS 12 crash report handling #431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# By Alistair Brown (9) and others # Via GitHub * develop: (36 commits) Partial tech debt cleanup (#345) Address Bar visual tweaks (#310) Bump find-in-page to latest version (#352) Bump privacy dashboard to latest version (#349) fix popover message bug (#348) Add missing next and previous find-in-page button handlers (#351) add asserts to check that atb and install date are nil before being set (#350) copy private email address (#344) Reset tracker info on page change (#335) remove history menu and re-home other items (#343) Update the credit card model + UI tweaks (#342) 0.17.6 Add Usage Pixel (#336) Bump find-in-page to latest version (#337) Forward delete collision with suffix resolved (#334) Avoid using a specific browser as the default. (#341) Closing animation duration changed to 0.15 (#333) Hiding the favicon view when favicon is nil (#326) export bookmarks (#339) Ensure ITP database is cleared (#328) ... # Conflicts: # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# By Alexey Martemyanov (20) and others # Via Tomas Strba (2) and others * develop: (63 commits) Tweaks of suggestions and autocomplete (#403) Bump privacy dashboard to latest version (#409) Point to the latest BrowserServicesKit branch. (#414) Move embedded TDS from BSK to platform repo (#412) Image of shield with dot replaced (#410) Expand Fireproofing to include Local Storage and IndexedDB (#408) Version 0.18.5 support privacy config for clickToLoad (#407) Automatically select available login (#405) initial FB Click to Load (WIP) (#329) onboarding updates (#398) Version 0.18.4 Configuration of Sparkle - Setting SUAllowsAutomaticUpdates to NO (#404) Hide downloads button if the popover is opened/closed manually (#397) Textfield of the homepage is empty and unfocused right after switching to the homepage (#400) Remove navigatorCredentials (#392) Remove GPC header if it exists when not needed (#366) Version 0.18.3 Fireproofing encrypted storage (#332) Fix Lock Screen UI issues (#399) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo/Crash Reports/Model/CrashReportSender.swift
* develop: Fix non-debug builds (#428) new tds url (#430) Sparkle 1.27.1 (#411) Disable CVDisplayLing logging (#421) Update Fire Popover graphics (#426) Version 0.18.7 Refresh the address bar when reloading (#413) Fix tabs leakage after Drag-Drop (#423) Point to BrowserServicesKit 8.0. (#425) Import error improvements (#406) Replace Burn and Fireproof icons (#416) don't disable the UI unless onboarding has been marked as finished (#420) fix nested RunLoop waiting (#422) Version 0.18.6
samsymons
commented
Feb 18, 2022
Comment on lines
80
to
81
let patternToReplace = "\"\(itemToFilter)\"\\s*:\\s*\".*\"" | ||
let redactedKeyValuePair = "\"\(itemToFilter)\":\"<removed>\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully my regexes are sensible 🙂 Here's a copy of it on regex101 if you want to play with it.
tomasstrba
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎖️
This PR is a masterpiece 💯
samsymons
added a commit
that referenced
this pull request
Feb 24, 2022
# Via GitHub * develop: Remove the Never option from the Save Credentials VC. (#437) Check the current sheets for a lock screen before presenting. (#434) macOS 12 crash report handling (#431) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo/SecureVault/View/PasswordManager.storyboard
samsymons
added a commit
that referenced
this pull request
Feb 24, 2022
samsymons
added a commit
that referenced
this pull request
Feb 24, 2022
# Via GitHub * develop: Logins+ filtering and sorting (#427) Remove the Never option from the Save Credentials VC. (#437) Check the current sheets for a lock screen before presenting. (#434) macOS 12 crash report handling (#431) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo/AppDelegate/AppDelegate.swift # DuckDuckGo/NavigationBar/View/MoreOptionsMenu.swift # DuckDuckGo/NavigationBar/View/NavigationBarViewController.swift # DuckDuckGo/SecureVault/Extensions/UserText+PasswordManager.swift # DuckDuckGo/SecureVault/View/PasswordManagementViewController.swift # DuckDuckGo/SecureVault/View/PasswordManager.storyboard # DuckDuckGo/Statistics/PixelArguments.swift
jonathanKingston
pushed a commit
that referenced
this pull request
Feb 25, 2022
* Handle macOS 12 crashes. * TEMP: Changes to allow sending crashes to a dev instance in DEBUG mode. Revert this! * Reset the crash reporter service URL. * Resolve merge conflicts. * Considering parsing the macOS 12 format. * Remove the initial parsing code. * Restore crash pixel. * Restore the last-check logic. * Remove more old debugging code. * Remove more unused changes. * Use one place for tracking the file extensions. * Strip out more data. * Fix up the regex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1201348868339182/f
Tech Design URL:
CC: @tomasstrba
Description:
This PR updates the app to look for and send
.ips
crash reports to the backend. The backend is already running the changes needed to interpret this format.Steps to test this PR:
👇 Git patch attached here 👇
Expand for git patch - save this into `crash_pr.patch` and run `git apply crash_pr.patch`
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM