Check for an existing lock screen before showing a new one #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
added a commit
that referenced
this pull request
Feb 24, 2022
# Via GitHub * develop: Remove the Never option from the Save Credentials VC. (#437) Check the current sheets for a lock screen before presenting. (#434) macOS 12 crash report handling (#431) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo/SecureVault/View/PasswordManager.storyboard
samsymons
added a commit
that referenced
this pull request
Feb 24, 2022
samsymons
added a commit
that referenced
this pull request
Feb 24, 2022
# Via GitHub * develop: Logins+ filtering and sorting (#427) Remove the Never option from the Save Credentials VC. (#437) Check the current sheets for a lock screen before presenting. (#434) macOS 12 crash report handling (#431) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo/AppDelegate/AppDelegate.swift # DuckDuckGo/NavigationBar/View/MoreOptionsMenu.swift # DuckDuckGo/NavigationBar/View/NavigationBarViewController.swift # DuckDuckGo/SecureVault/Extensions/UserText+PasswordManager.swift # DuckDuckGo/SecureVault/View/PasswordManagementViewController.swift # DuckDuckGo/SecureVault/View/PasswordManager.storyboard # DuckDuckGo/Statistics/PixelArguments.swift
jonathanKingston
pushed a commit
that referenced
this pull request
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1201856209410871/f
Tech Design URL:
CC: @brindy
Description:
This PR updates the Lock Screen logic to check whether one is already visible before displaying a new one. This issue couldn't lock users out of the app, but it looked weird.
Steps to test this PR:
#if DEBUGchecks that automatically unlock debug builds of the app (specifically,unlockExistingInstallIfNecessaryinsideWaitlist.swift)DAXas the code and proceed through the waitlist flowTesting checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM