Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tds etag to breakage reports #466

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Add tds etag to breakage reports #466

merged 2 commits into from
Mar 25, 2022

Conversation

SlayterDev
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/72649045549333/1201722757273633/f
Tech Design URL:
CC:

Description:
This PR adds the tds etag to the breakage report pixel

Steps to test this PR:

  1. Send breakage report using dashboard
  2. Ask breakage team to verify etag is attached

Testing checklist:

  • Test with Release configuration
Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@samsymons samsymons self-assigned this Mar 16, 2022
samsymons
samsymons approved these changes Mar 19, 2022
View reviewed changes
Copy link
Collaborator

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SlayterDev SlayterDev merged commit 9d9fd10 into develop Mar 25, 2022
@SlayterDev SlayterDev deleted the brad/tds-etag branch March 25, 2022 14:33
samsymons added a commit that referenced this pull request Mar 29, 2022
@samsymons
Merge branch 'develop' into sam/password-generation
bcad9a3 
* develop:
  Prompt to store cards and identities (#461)
  Version 0.21.1
  inject CTL user script atDocumentEnd (#482)
  Fire button and shield button animations (#476)
  Add tds etag to breakage reports (#466)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsymons samsymons samsymons approved these changes

Assignees

@samsymons samsymons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SlayterDev @samsymons