Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the automatic unlock logic #460

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

samsymons
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1199230911884351/1201945424795364/f
Tech Design URL:
CC:

Description:

This PR removes the automatic Lock Screen unlock logic. This logic was used to make sure internal users of the browser didn't all need to get an invite code just to keep using the browser.

Now everyone internally has unlocked, we can remove the logic, in case users find a way to exploit it.

Steps to test this PR:

  1. Run a clean build of the browser in debug mode and ensure it does unlock automatically, we want to make sure that debug and review build users still bypass the lock screen
  2. Run a clean build of the browser in release mode and ensure it does not unlock automatically. Ideally, install an old version of the browser and run it, then install an archived version of this branch over top and check that it's locked.

Testing checklist:

  • Test with Release configuration

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@brindy brindy self-assigned this Mar 10, 2022
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ran it locally on top of production and it let me in. Ran it clean on my MBP and it showed the waitlist.

@brindy brindy assigned samsymons and unassigned brindy Mar 10, 2022
@samsymons samsymons merged commit 927ec55 into develop Mar 10, 2022
@samsymons samsymons deleted the sam/remove-lock-screen-upgrade-logic branch March 10, 2022 23:28
samsymons added a commit that referenced this pull request Mar 16, 2022
* develop:
  fix launch link when no windows are open (#470)
  Version 0.20.1
  Update storyboards to use correct color names. (#468)
  Fix suggestion selection crash (#469)
  Version 0.20.0
  Dev tools visibility fix (#457)
  Fix BrowserTabViewController leakage (#463)
  Remove the upgrade logic. (#460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants