Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BrowserTabViewController leakage #463

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Fix BrowserTabViewController leakage #463

merged 1 commit into from
Mar 11, 2022

Conversation

mallexxx
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/inbox/1199237043628108/1201937895290423/1201946177136629
CC:

Description:
Fixes BrowserTabViewController leakage

Steps to test this PR:

  1. Open a new window
  2. Navigate to a website (e.g. youtube and start video)
  3. Close Tab
  4. Validate the Tab and BrowserTabViewController is deallocated (and video is stopped)

Testing checklist:

  • Test with Release configuration
Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@tomasstrba tomasstrba self-requested a review March 10, 2022 15:00
@tomasstrba tomasstrba self-assigned this Mar 10, 2022
tomasstrba
tomasstrba approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 👏 👏 👏

@tomasstrba tomasstrba assigned mallexxx and unassigned tomasstrba Mar 11, 2022
@mallexxx mallexxx merged commit 78473e2 into develop Mar 11, 2022
@mallexxx mallexxx deleted the alex/fix-leak branch March 11, 2022 13:35
samsymons added a commit that referenced this pull request Mar 16, 2022
@samsymons
Merge branch 'develop' into sam/autofill-cards-and-identities
e947e7a 
* develop:
  fix launch link when no windows are open (#470)
  Version 0.20.1
  Update storyboards to use correct color names. (#468)
  Fix suggestion selection crash (#469)
  Version 0.20.0
  Dev tools visibility fix (#457)
  Fix BrowserTabViewController leakage (#463)
  Remove the upgrade logic. (#460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasstrba tomasstrba tomasstrba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mallexxx @tomasstrba