Hotfix: suggestion selection crash #469
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/inbox/1199237043628108/1201958708460468/1201958708499920
Tech Design URL:
CC:
Description:
Fixes crash when selecting shorter suggestion:
Seems that touchbar doesn't get the updated string value before "willChangeSelection" is called and using an old string range value
in the reproduction steps below it got {0, 27} range whereas the real range is {0, 23}
So the async call is not for the threads issue but to get the touchbar updated before we call redraw
Steps to test this PR:
0. Activate Xcode->Window->Touch Bar->Show Touch Bar
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM