Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix launch link when no windows are open #470

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Mar 15, 2022

Task/Issue URL: https://app.asana.com/0/1199178362774117/1201965913072538
Tech Design URL:
CC:

Description:

Ensure when browser is open but now windows are open that links launch in a new tab.

Steps to test this PR:

  1. Launch the browser, open a new tab, load a URL. Check all open in new tab / new window functions (menus, keyboard short cuts, etc).
  2. Close (Cmd-Q) the app, then click on a link in a third party app. The app should launch and a new window should open, with a new tab that loads the URL.
  3. Close all tabs but do not close the app, then click on a link in a third party app. A new window should open, with a new tab that loads the URL.
  • Test with Release configuration

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@Bunn Bunn self-requested a review March 15, 2022 19:47
@brindy brindy changed the title Brindy/fix launch link fix launch link when no windows are open Mar 15, 2022
@samsymons samsymons self-assigned this Mar 15, 2022
Copy link
Collaborator

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brindy brindy merged commit caeeb0b into develop Mar 15, 2022
@brindy brindy deleted the brindy/fix-launch-link branch March 15, 2022 21:29
samsymons added a commit that referenced this pull request Mar 16, 2022
* develop:
  fix launch link when no windows are open (#470)
  Version 0.20.1
  Update storyboards to use correct color names. (#468)
  Fix suggestion selection crash (#469)
  Version 0.20.0
  Dev tools visibility fix (#457)
  Fix BrowserTabViewController leakage (#463)
  Remove the upgrade logic. (#460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants