Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix storyboard color usage #468

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Fix storyboard color usage #468

merged 1 commit into from
Mar 14, 2022

Conversation

samsymons
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1177771139624306/1201956542814249/f
Tech Design URL:
CC:

Description:

This PR fixes a misnamed color in storyboards. Offending values were found with rg "HomepageBackgroundColor -C 10", if you want to verify that no other uses of this exist.

Steps to test this PR:

  1. Run the app in light and dark modes, check colors on the home page to make sure everything looks fine
  2. Check that the main preferences screen looks fine in light and dark mode
  3. Check that the preferences About page looks fine in light and dark mode
    Testing checklist:
  • Test with Release configuration
Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@brindy brindy changed the base branch from develop to release/0.20.1 March 14, 2022 13:26
brindy
brindy approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

(I changed the base to be the next release branch)

@samsymons samsymons merged commit db93571 into release/0.20.1 Mar 14, 2022
@samsymons samsymons deleted the sam/fix-preferences-background-color branch March 14, 2022 17:42
samsymons added a commit that referenced this pull request Mar 16, 2022
@samsymons
Merge branch 'develop' into sam/autofill-cards-and-identities
e947e7a 
* develop:
  fix launch link when no windows are open (#470)
  Version 0.20.1
  Update storyboards to use correct color names. (#468)
  Fix suggestion selection crash (#469)
  Version 0.20.0
  Dev tools visibility fix (#457)
  Fix BrowserTabViewController leakage (#463)
  Remove the upgrade logic. (#460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy approved these changes

Assignees

@samsymons samsymons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsymons @brindy