Update BSK with Autofill changes #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
* develop: Update URL param ref tests (#1096) Downloads list + enhanced file handling (#1095) Fix for the initial onboarding title not using the correct font (#1080) iOS Voice Search - Custom Dialog & Experiment (#1083) Bump app version to 7.65.13 Improve local storage & cookie clearing by stopping all operations in open tabs (#1084)
ayoy
approved these changes
Mar 25, 2022
samsymons
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Mar 29, 2022
Task/Issue URL: https://app.asana.com/0/0/1201938691568505/f iOS PR: duckduckgo/iOS#1086 macOS PR: duckduckgo/macos-browser#461 Optional: CC: @brindy Description: This PR updates BrowserServicesKit to handle the new pmHandlerStoreData call. As a part of this, it runs some logic to look up whether the provided payment method or address already exist in the database. Steps to test this PR: See macOS PR for more information
# By Michal Smaga (4) and others # Via Michal Smaga (2) and GitHub (1) * develop: Fix Xcode 13.3 compilation. (#1099) Update to BSK with a fix for percent encoding (#1091) Update the release notes Set version to 7.66.0 Downloads UI tweaks (#1098) Fix for proper toolbar hiding when leaving Unprotected Sites view (#1097) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Apr 6, 2022
# By Michal Smaga (9) and others # Via Jacek Łyp (2) and others * develop: (21 commits) Update BSK with a fix for MacOS Website Breakage reporting (#1108) Improve swift style + swiftlint (#1092) Update the release notes Set version to 7.66.1 Fix for not sending errors inside ContentBlockerRulesManager (#1107) Use local file url instead of remote url for getting file size (#1106) Change the logic for tab preparation for data clearing (#1100) AMP code extraction into BSK (#1101) Fix incorrect m_download_tried_to_present_preview_without_tab pixel reporting (#1105) Fix AR previews not working on iOS 15.4 (#1104) Update BSK with Autofill changes (#1086) Fix Xcode 13.3 compilation. (#1099) Update to BSK with a fix for percent encoding (#1091) Update the release notes Set version to 7.66.0 Downloads UI tweaks (#1098) Fix for proper toolbar hiding when leaving Unprotected Sites view (#1097) Update URL param ref tests (#1096) Downloads list + enhanced file handling (#1095) Fix for the initial onboarding title not using the correct font (#1080) ... # Conflicts: # Core/UserDefaultsPropertyWrapper.swift # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo/UserText.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1201946516267418/f
Tech Design URL:
CC: @ayoy
Description:
This PR bumps the BSK commit to account for Autofill changes that are coming. None of these are used in iOS.
Steps to test this PR:
Device Testing:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM