Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animate dashboard resizing #454

Merged
merged 3 commits into from
Mar 8, 2022
Merged

Animate dashboard resizing #454

merged 3 commits into from
Mar 8, 2022

Conversation

SlayterDev
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1177771139624306/1201319270019235/f
Tech Design URL:
CC:

Description:
This PR animates height changes for the dashboard popover

Steps to test this PR:

  1. Open dashboard
  2. Click into tracker details and other areas. Height changes should animate smoothly

Testing checklist:

  • Test with Release configuration

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@tomasstrba tomasstrba self-requested a review March 4, 2022 11:07
@tomasstrba tomasstrba self-assigned this Mar 4, 2022
@bstandaert-ddg
Copy link

One minor issue (maybe not worth fixing): when you switch to a section with a shorter height and then reopen the dashboard, it starts short and animates down:

Screen.Recording.2022-03-04.at.2.30.23.PM.mov

Other than that, the behavior seems fine.

@SlayterDev
Copy link
Contributor Author

One minor issue (maybe not worth fixing): when you switch to a section with a shorter height and then reopen the dashboard, it starts short and animates down:

Other than that, the behavior seems fine.

Thanks @bstandaert-ddg! I've fixed this.

Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Very nice! 🥇🎖️

@tomasstrba tomasstrba assigned SlayterDev and unassigned tomasstrba Mar 8, 2022
@SlayterDev SlayterDev merged commit 0e754d6 into develop Mar 8, 2022
@SlayterDev SlayterDev deleted the brad/dash-resize branch March 8, 2022 13:48
samsymons added a commit that referenced this pull request Mar 8, 2022
# By Dominik Kapusta (2) and others
# Via GitHub
* develop:
  Animate dashboard resizing (#454)
  Dashboard in background tabs (#458)
  Fix resubmitting search with spaces (#456)
  Use smarter encryption feature from the BSK (#441)
  Use pageZoom instead of magnification when adjusting web view zoom level (#455)
  Version 0.19.2

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Mar 10, 2022
* develop:
  Advance content scope scripts forwards (#453)
  Animate dashboard resizing (#454)
  Dashboard in background tabs (#458)
  Fix resubmitting search with spaces (#456)
  Use smarter encryption feature from the BSK (#441)
  Use pageZoom instead of magnification when adjusting web view zoom level (#455)
  Version 0.19.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants