Advance content-scope-scripts forward #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tomasstrba
approved these changes
Mar 9, 2022
There was a problem hiding this comment.
LGTM! 👍 Please see my comment in duckduckgo/BrowserServicesKit#73
jonathanKingston
force-pushed
the
jkt/advance-css
branch
from
981ada8 to
1882a69
Compare
samsymons
added a commit
that referenced
this pull request
Mar 10, 2022
* develop: Advance content scope scripts forwards (#453) Animate dashboard resizing (#454) Dashboard in background tabs (#458) Fix resubmitting search with spaces (#456) Use smarter encryption feature from the BSK (#441) Use pageZoom instead of magnification when adjusting web view zoom level (#455) Version 0.19.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/569473074191537/1201894298881763/f
Tech Design URL:
CC:
Description:
Draft commit to test: https://app.asana.com/0/569473074191537/1201894298881763/f and duckduckgo/BrowserServicesKit#73
Steps to test this PR:
Check for globals that look defined by us (the test gets outdated per Safari release: but previously we had 'init' and 'contentScopeFeatures' leaked)
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM