Use pageZoom instead of magnification when adjusting web view zoom level #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WKWebView.pageZoom adjusts layout instead of canvas, but is only available on macOS >11, so the fix does not cover macOS 10.15.
samsymons
added a commit
that referenced
this pull request
Mar 8, 2022
# By Dominik Kapusta (2) and others # Via GitHub * develop: Animate dashboard resizing (#454) Dashboard in background tabs (#458) Fix resubmitting search with spaces (#456) Use smarter encryption feature from the BSK (#441) Use pageZoom instead of magnification when adjusting web view zoom level (#455) Version 0.19.2 # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Mar 10, 2022
* develop: Advance content scope scripts forwards (#453) Animate dashboard resizing (#454) Dashboard in background tabs (#458) Fix resubmitting search with spaces (#456) Use smarter encryption feature from the BSK (#441) Use pageZoom instead of magnification when adjusting web view zoom level (#455) Version 0.19.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1200398379892840/f
Tech Design URL:
CC:
Description:
I updated zoom level manipulation methods to operate on
WKWebView.pageZoominstead ofWKWebView.magnificationwhere possible (i.e. >=macOS 11). According to the docs,pageZoomadjusts CSS zoom attribute which is what we want here, whilemagnificationapplies a scale transform to the canvas (which is appropriate e.g. for pinch zooming). This change gives us the behavior similar to Safari.Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM