Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resubmitting search with spaces #456

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented Mar 4, 2022

Task/Issue URL: https://app.asana.com/0/1177771139624306/1201865561825271/f
Tech Design URL:
CC:

Description:
Fixed by a change in BSK.

Steps to test this PR:

  1. Search for Battlestar Galactica
  2. Click in the address field
  3. Hit enter
  4. The search should be resubmitted, instead of changing to Battlestar+Galactica

Testing checklist:

  • Test with Release configuration

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Once you resolve conflicts and update your dependency, feel free to build.

Fixed by a change in BSK (URL.addParameter).

Task/Issue URL: https://app.asana.com/0/1177771139624306/1201865561825271/f
@ayoy ayoy force-pushed the bugfix/dominik/resubmit-search-with-spaces branch from f3edbe0 to 66c8538 Compare March 8, 2022 11:00
@ayoy ayoy removed the don’t merge label Mar 8, 2022
@ayoy ayoy merged commit 520c6a8 into develop Mar 8, 2022
@ayoy ayoy deleted the bugfix/dominik/resubmit-search-with-spaces branch March 8, 2022 12:04
samsymons added a commit that referenced this pull request Mar 8, 2022
# By Dominik Kapusta (2) and others
# Via GitHub
* develop:
  Animate dashboard resizing (#454)
  Dashboard in background tabs (#458)
  Fix resubmitting search with spaces (#456)
  Use smarter encryption feature from the BSK (#441)
  Use pageZoom instead of magnification when adjusting web view zoom level (#455)
  Version 0.19.2

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Mar 10, 2022
* develop:
  Advance content scope scripts forwards (#453)
  Animate dashboard resizing (#454)
  Dashboard in background tabs (#458)
  Fix resubmitting search with spaces (#456)
  Use smarter encryption feature from the BSK (#441)
  Use pageZoom instead of magnification when adjusting web view zoom level (#455)
  Version 0.19.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants