Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-beta copy updates #472

Merged
merged 11 commits into from
Mar 17, 2022
Merged

Pre-beta copy updates #472

merged 11 commits into from
Mar 17, 2022

Conversation

samsymons
Copy link
Collaborator

@samsymons samsymons commented Mar 16, 2022

Task/Issue URL: https://app.asana.com/0/1199230911884351/1201977962257433/f
Tech Design URL:
CC:

Description:

This PR updates copy throughout the app in accordance with the changes requested by the copy team.

Steps to test this PR:

  1. Check the four subtasks here and verify that this PR matches those requests.

Testing checklist:

  • Test with Release configuration

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@brindy brindy self-assigned this Mar 17, 2022
@brindy
Copy link
Contributor

brindy commented Mar 17, 2022

This seems wrong?

Screenshot 2022-03-17 at 11 22 20

Screenshot 2022-03-17 at 11 22 24

@brindy
Copy link
Contributor

brindy commented Mar 17, 2022

Also not quite right - the casing on Geolocation should be geolocation right? Might be worth clarifying that.

Screenshot 2022-03-17 at 11 29 06

Screenshot 2022-03-17 at 11 28 28

Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple not quite right. Ping me and I can do a quick follow up review.

@brindy brindy assigned samsymons and unassigned brindy Mar 17, 2022
@brindy brindy assigned brindy and unassigned samsymons Mar 17, 2022
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brindy brindy assigned samsymons and unassigned brindy Mar 17, 2022
@samsymons samsymons merged commit ad62970 into develop Mar 17, 2022
@samsymons samsymons deleted the sam/copy-updates branch March 17, 2022 20:21
samsymons added a commit that referenced this pull request Mar 25, 2022
# By Tomas Strba (3) and others
# Via GitHub
* develop:
  Testing Checklist Updates (#480)
  Xcode Clean Up (#479)
  External App Scheme permission (#419)
  Update dashboard to correct version (#477)
  Update BSK to fix percent encoding query parameters (#475)
  bump version 0.21.0
  add alternate for paste and match with style (#474)
  First reponder issues when switching tabs (#464)
  Pre-beta copy updates (#472)
  Improvements to data clearing (#467)
  Open feedback form upon tapping "Send Feedback" in the About page (#473)
  new tab tweaks (#471)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	DuckDuckGo/Secure Vault/View/SaveIdentityPopover.swift
#	DuckDuckGo/Secure Vault/View/SaveIdentityViewController.swift
#	DuckDuckGo/Secure Vault/View/SavePaymentMethodPopover.swift
#	DuckDuckGo/Secure Vault/View/SavePaymentMethodViewController.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants