Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add alternate menu item for paste and match with style #474

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Mar 17, 2022

Task/Issue URL: https://app.asana.com/0/392891325557410/1201908561430620
Tech Design URL:
CC:

Description:

Add alternate menu shortcut for paste and match with style

Steps to test this PR:

  1. Open https://twitter.com/duckduckgo and copy the page
  2. Open https://www.richtexteditor.com/demos/
  3. Cmd-V into the text area and you see a bunch of rich text pasted
  4. Delete the contents of the text area (or refresh the page)
  5. Check that cmd-shift-v and option-shift-cmd-v to paste both paste plain text

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@brindy brindy changed the title add alternate for paste and match with style add alternate menu item for paste and match with style Mar 17, 2022
Copy link
Collaborator

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Followed the steps and it worked as expected.

@brindy brindy merged commit ee3fb53 into develop Mar 18, 2022
@brindy brindy deleted the brindy/cmd-shift-v branch March 18, 2022 01:31
samsymons added a commit that referenced this pull request Mar 25, 2022
# By Tomas Strba (3) and others
# Via GitHub
* develop:
  Testing Checklist Updates (#480)
  Xcode Clean Up (#479)
  External App Scheme permission (#419)
  Update dashboard to correct version (#477)
  Update BSK to fix percent encoding query parameters (#475)
  bump version 0.21.0
  add alternate for paste and match with style (#474)
  First reponder issues when switching tabs (#464)
  Pre-beta copy updates (#472)
  Improvements to data clearing (#467)
  Open feedback form upon tapping "Send Feedback" in the About page (#473)
  new tab tweaks (#471)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	DuckDuckGo/Secure Vault/View/SaveIdentityPopover.swift
#	DuckDuckGo/Secure Vault/View/SaveIdentityViewController.swift
#	DuckDuckGo/Secure Vault/View/SavePaymentMethodPopover.swift
#	DuckDuckGo/Secure Vault/View/SavePaymentMethodViewController.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants