Update BSK to fix percent encoding query parameters #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@mallexxx, FYI, I assigned this to you since you picked duckduckgo/BrowserServicesKit#78 (comment) |
ayoy
force-pushed
the
dominik/fix-query-percent-encoding
branch
2 times, most recently
from
a3d3cc4 to
c1bad6b
Compare
ayoy
force-pushed
the
dominik/fix-query-percent-encoding
branch
from
c1bad6b to
6c51e5b
Compare
samsymons
added a commit
that referenced
this pull request
Mar 25, 2022
# By Tomas Strba (3) and others # Via GitHub * develop: Testing Checklist Updates (#480) Xcode Clean Up (#479) External App Scheme permission (#419) Update dashboard to correct version (#477) Update BSK to fix percent encoding query parameters (#475) bump version 0.21.0 add alternate for paste and match with style (#474) First reponder issues when switching tabs (#464) Pre-beta copy updates (#472) Improvements to data clearing (#467) Open feedback form upon tapping "Send Feedback" in the About page (#473) new tab tweaks (#471) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/Secure Vault/View/SaveIdentityPopover.swift # DuckDuckGo/Secure Vault/View/SaveIdentityViewController.swift # DuckDuckGo/Secure Vault/View/SavePaymentMethodPopover.swift # DuckDuckGo/Secure Vault/View/SavePaymentMethodViewController.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1201985700849146/f
Tech Design URL:
CC: @tomasstrba
Description:
When adding a new query parameter to an existing URL, manually percent encode the name and value and add them to percentEncodedQueryItems. When percent-encoding the parameter, use a modified allowed characters set that does not include "URI query reserved characters" as they need to be percent encoded (when part of the parameter name or value).
Steps to test this PR:
star;trekand not forstar.Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM