Improvements to data clearing #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwaresiak
changed the title
|
@bwaresiak I had a quick look at this. The counter is obviously reset, but then it usually has a value of 1 or 3, something like that after the fire button. |
brindy
approved these changes
Mar 17, 2022
tomasstrba
reviewed
Mar 17, 2022
| userContentController.removeAllUserScripts() | ||
|
|
||
| webView.navigationDelegate = caller | ||
| webView.load(URL(string: "about:blank")!) |
There was a problem hiding this comment.
There is a probability about:black will be reused in multiple places. Could be defined in Common folder
tomasstrba
reviewed
Mar 17, 2022
|
|
||
| Once done, remove Tab objects. | ||
| */ | ||
| final class TabDataCleaner: NSObject, WKNavigationDelegate { |
There was a problem hiding this comment.
Why is this class called TabDataCleaner when data are cleaned outside of it, in clearData() of fileprivate extension TabCollectionViewModel?
samsymons
added a commit
that referenced
this pull request
Mar 25, 2022
# By Tomas Strba (3) and others # Via GitHub * develop: Testing Checklist Updates (#480) Xcode Clean Up (#479) External App Scheme permission (#419) Update dashboard to correct version (#477) Update BSK to fix percent encoding query parameters (#475) bump version 0.21.0 add alternate for paste and match with style (#474) First reponder issues when switching tabs (#464) Pre-beta copy updates (#472) Improvements to data clearing (#467) Open feedback form upon tapping "Send Feedback" in the About page (#473) new tab tweaks (#471) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/Secure Vault/View/SaveIdentityPopover.swift # DuckDuckGo/Secure Vault/View/SaveIdentityViewController.swift # DuckDuckGo/Secure Vault/View/SavePaymentMethodPopover.swift # DuckDuckGo/Secure Vault/View/SavePaymentMethodViewController.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/856498667320406/1201649423461228
Tech Design URL:
CC:
Description:
Ensure data is fully flushed to disk before we burn the tab.
Steps to test this PR:
Open Test Page (https://privacy-test-pages.glitch.me/features/local-storage.html) - check if fire button works correctly in all scenarios (all, some domains only, fireproof, etc).
General some tests.
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM