New Tab Page #433

brindy · 2022-02-20T15:19:44Z

Task/Issue URL: https://app.asana.com/0/392891325557410/1201829216434626
Tech Design URL:
CC:

Description:

All new tab page re-written in Swift UI.

Steps to test this PR:

Default Browser prompt is shown
Favorites show correctly and menu works as expected
Empty state for feed looks correct
Open a bunch of site and check the feed
Ensuring burning sites works
Ensure favoriting works (note that the ordering is determined by the lifecycle of the bookmark which may get created in order to create the favorite)
Check double tap the shield easter egg to toggle permanently showing the feed list

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

…button

brindy · 2022-02-20T15:20:46Z

DuckDuckGo/BrowserTab/Model/Tab.swift

@@ -138,6 +138,10 @@ final class Tab: NSObject {
        super.init()

        setupWebView(shouldLoadInBackground: shouldLoadInBackground)
+
+        if content == .homepage {


Ensures the home page enters the history so that it can be navigated back to without causing back/forward list complexity.

DuckDuckGo/BrowserTab/Model/Tab.swift

brindy · 2022-02-20T15:22:44Z

DuckDuckGo/Common/View/SwiftUI/ColorExtensions.swift

+
+import SwiftUI
+
+extension Color {


Copied from iOS to give consistent, but seemingly random, colours for favorites.

brindy · 2022-02-20T15:24:20Z

DuckDuckGo/Common/View/SwiftUI/FaviconView.swift

+    let size: CGFloat
+
+    @State var image: NSImage?
+    @State private var timer = Timer.publish(every: 0.3, tolerance: 0, on: .main, in: .default, options: nil).autoconnect()


If the SwiftUI view is shown too quickly then the Favicon cache does not appear to load and give the cached image. This refreshes the image after a short time, but only once as the timer is cancelled after being fired.

I think this is probably fine, though ideally the FaviconManager should publish when the favicon cache loads or changes, after which this view could just subscribe to that (probably debouncing the events within a short period in case of rapid changes). Though if this is just for setting up the view and canceled right after, then I think this is fine.

Agree, but didn't want to change the FaviconManager if I could avoid it. I did look at making a publisher but the areFaviconsLoaded var is a composite so didn't seem like a quick refactor.

But actually I will make one improvement here and that's to check until the caches are loaded.

brindy · 2022-02-20T15:26:31Z

DuckDuckGo/Common/View/SwiftUI/MoreOrLessView.swift

+
+import SwiftUI
+
+struct MoreOrLess: View {


A component that shows a "More ^" or "Less v" link that can be used to hide and show other views.

brindy · 2022-02-20T15:27:26Z

DuckDuckGo/Common/View/SwiftUI/ViewExtensions.swift

@@ -40,4 +40,17 @@ extension View {
        }
    }

+    func link(onHoverChanged: ((Bool) -> Void)? = nil, clicked: @escaping () -> Void) -> some View {
+        self.onHover { over in


Updates the cursor to show pointy hand. Unfortunately if the containing view also uses this flag to change itself, then Swift UI rebuilds the view resets the point back to the normal arrow.

brindy · 2022-02-20T15:28:45Z

DuckDuckGo/History/Model/HistoryCoordinator.swift

+        var historyDictionary = self.historyDictionary ?? [:]
+        historyDictionary[entry.url] = entry
+        self.historyDictionary = historyDictionary
+        self._history = self.makeHistory(from: historyDictionary)
+


I noticed both existing functions called this same code and I was about to add another to do the same just refactored it into here.

brindy · 2022-02-20T15:31:50Z

DuckDuckGo/Homepage/Model/HomepageFavoritesModel.swift

+
+    struct FavoriteModel {
+
+        static let addButtonUUID = UUID()


The add button is a specialised "Favorite" so we need to be able to identify it. This reduces the amount of logic required in the view / model for determining when to show the add button based on how many rows of favorites are already showing.

DuckDuckGo/Preferences/Model/DefaultBrowserPreferences.swift

samsymons

Only just started working on this, one question and one bug:

Question: What's the expected order of the tracker feed on the home page? It almost always adds new sites on chronological order, but in some cases I can visit two sites in sequence and they'll be backwards. For instance, if I visit Amazon, and then the NY Times, Amazon appears as the most recent visited website still, with NY Times second.
Bug: When you have text selected in the new tab's address bar, visiting another tab will have the same number of characters selected in the address bar.

DuckDuckGo/Common/Extensions/DateExtension.swift

DuckDuckGo/Common/Localizables/UserText.swift

samsymons · 2022-03-07T20:02:44Z

DuckDuckGo/Common/View/SwiftUI/FaviconView.swift

+    let size: CGFloat
+
+    @State var image: NSImage?
+    @State private var timer = Timer.publish(every: 0.3, tolerance: 0, on: .main, in: .default, options: nil).autoconnect()


I think this is probably fine, though ideally the FaviconManager should publish when the favicon cache loads or changes, after which this view could just subscribe to that (probably debouncing the events within a short period in case of rapid changes). Though if this is just for setting up the view and canceled right after, then I think this is fine.

DuckDuckGo/Home Page/Model/HomePageFavoritesModel.swift

brindy · 2022-03-08T13:00:15Z

Thanks @samsymons !

It's possibly because we exclude the domain root from the list so even though you visit NY after Amazon, it's not changed the list per se. I think I can fix that.
Yep, am working on this today.

…hen on

…pts blocked

brindy · 2022-03-09T13:31:28Z

Ah 1) is caused because we're truncating the date of the history ... it was being trunacted to the same day, now it's being truncated to the same minute. Actully, I need to run a privacy triage on that.

samsymons

🥇

* develop: New Tab Page (#433) Make website URLs clickable in Logins+ (#462) Correction of URL if it is missing one slash '/' (#459)

brindy added 19 commits February 15, 2022 10:43

pull in swiftui for home page

43200b7

support address bar sizing on new tab page

e835023

Merge branch 'develop' into brindy/new-tab-page

a74bc4d

fix favorites bug

e00107c

consistent hover states, assert if favorite is not a bookmark or add …

8cb9bf1

…button

sizing the add button

8114407

add privacy summary text placeholder

0094aa1

default browser prompt

50d8adf

update nav buttons and other tweaks

00f6e8e

style the address bar based on it it being on the home page

dd62c13

address bar size tweaks

ca3d30e

manage address bar state on different home page correctly

47c74bd

change row heights if suggestions are on home page

f41b724

set global accent colour

5cb53ea

reduce the font size slightly

f5fe65b

count number of trackers per history url

697450c

extra views in their own files

74271be

fix favorites, use more user text

48b44c7

show nav buttons on home tab

2716543

brindy commented Feb 20, 2022

View reviewed changes

DuckDuckGo/BrowserTab/Model/Tab.swift Show resolved Hide resolved

brindy commented Feb 20, 2022

View reviewed changes

DuckDuckGo/Preferences/Model/DefaultBrowserPreferences.swift Show resolved Hide resolved

brindy added 2 commits February 20, 2022 15:59

extra strings into user text

ba55cf9

fix tests

51f14d2

samsymons self-assigned this Mar 7, 2022

samsymons self-requested a review March 7, 2022 19:36

samsymons requested changes Mar 7, 2022

View reviewed changes

make default browser prompt part of the scroll view at the top

210174e

brindy changed the title ~~[draft] New Tab Page - Phase 1~~ New Tab Page Mar 8, 2022

brindy added 9 commits March 8, 2022 13:36

fix some feedback comments, make it so the alt state disables hover w…

26fdd43

…hen on

fix first responder

a1367e3

design tweaks

a06b5cf

fix responder issues

1b57476

move comment

8fc01f8

update copy and remove file

29b275b

hide no trackers block string and format the number of tracking attem…

a676ffa

…pts blocked

tweak copy clean code a little

7e07931

Merge branch 'develop' into brindy/new-tab-page

de6d850

brindy added 6 commits March 9, 2022 14:09

fully remove bookmark when using menu (like in current prod)

0874ac7

hide default browser prompt when needed

f1a4e90

design tweaks

c41dc43

tweak more or less controller colours

3dccfc9

redraw after selection to remove artifacts

03e12ca

add a comment

c23d3d7

samsymons approved these changes Mar 9, 2022

View reviewed changes

brindy added 2 commits March 10, 2022 12:38

remove min height and add padding for default mode

6b56e56

Show alt text instead of seconds for relative time

98b03c4

brindy assigned brindy and unassigned samsymons Mar 10, 2022

brindy merged commit 5a216e1 into develop Mar 10, 2022

brindy deleted the brindy/new-tab-page branch March 10, 2022 16:47

samsymons added a commit that referenced this pull request Mar 10, 2022

Merge branch 'develop' into sam/autofill-cards-and-identities

c36cebf

* develop: New Tab Page (#433) Make website URLs clickable in Logins+ (#462) Correction of URL if it is missing one slash '/' (#459)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Tab Page #433

New Tab Page #433

brindy commented Feb 20, 2022 •

edited

Loading

brindy Feb 20, 2022

brindy Feb 20, 2022

brindy Feb 20, 2022

samsymons Mar 7, 2022

brindy Mar 8, 2022

brindy Feb 20, 2022

brindy Feb 20, 2022

brindy Feb 20, 2022

brindy Feb 20, 2022

samsymons left a comment

samsymons Mar 7, 2022

brindy commented Mar 8, 2022

brindy commented Mar 9, 2022

samsymons left a comment

New Tab Page #433

New Tab Page #433

Conversation

brindy commented Feb 20, 2022 • edited Loading

Internal references:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samsymons left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brindy commented Mar 8, 2022

brindy commented Mar 9, 2022

samsymons left a comment

Choose a reason for hiding this comment

brindy commented Feb 20, 2022 •

edited

Loading