Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the number of pending requests to BookKeeper to save the broker from OODM #18

Open
wants to merge 60 commits into
base: master
Choose a base branch
from

Conversation

eolivelli
Copy link
Owner

Upstream PR: apache#17953

ddieruf and others added 29 commits October 6, 2022 12:51
* [improve][doc] add developers-landing page

The Pulsar for Developers content block on the documentation landing page needs to link to this page.

* Update getting-started-standalone.md

* Update getting-started-standalone.md

* move the file to /site2/docs/

* Update about.md

* Update site2/docs/developers-landing.md

Co-authored-by: tison <[email protected]>

* Update site2/docs/getting-started-standalone.md

Co-authored-by: tison <[email protected]>

* [doc][improve] Update concepts-messaging.md

Minor content edits, add / replace images to improve clarity and consistency.

* Update site2/docs/concepts-messaging.md

Co-authored-by: Anonymitaet <[email protected]>

Co-authored-by: momo-jun <[email protected]>
Co-authored-by: tison <[email protected]>
Co-authored-by: Anonymitaet <[email protected]>
…#17968)

* [cleanup][broker][Modernizer] fix violations in pulsar-broker
* [fxi][doc] Rewrite the steps of docker-deploy
### Motivation
The old implementation is incompletely.
### Modification
Rewrite it.
…ered when using batch receive and trigger timeout. (apache#17318)
* [fix][doc] SVG files and references

Signed-off-by: tison <[email protected]>
Co-authored-by: Dave Duggins <[email protected]>

* fix one more broken syntax on the fly

Signed-off-by: tison <[email protected]>

Signed-off-by: tison <[email protected]>
Co-authored-by: Dave Duggins <[email protected]>
…18002)

* [fix][CI] Use GitHub Actions actions/checkout@v3

- Node.js 12 actions are deprecated.
  For more information see:
  https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

* Also upgrade actions/cache and actions/setup-java
…Codecov (apache#17382)

* [improve][ci] Generate jacoco code coverage reports and upload to CodeCov

* [improve][ci] Generate jacoco code coverage reports and upload to CodeCov

* [improve][ci] Generate jacoco code coverage reports and upload to CodeCov

* [improve][ci] Generate jacoco code coverage reports and upload to CodeCov

* Add codecov configuration file

* Update codecov.yml

Co-authored-by: tison <[email protected]>

* Change codecov comment behaviour configuration to default to reduce the email notification times.

* Allow CodeCov upload report job can be failure

* Include only apache/pulsar class to generate jacoco tests

* Include only apache/pulsar class to generate jacoco tests

* Exclude class files in META-INF and skip pulsar-all-docker-image in test_group_other

* Remove generate jacoco reports step in pulsar-ci

Co-authored-by: tison <[email protected]>
RobertIndie and others added 4 commits October 12, 2022 11:48
…#16225)

### Motivation

In apache#13950, we switched an error log to an info log. @hsaputra requested on Pulsar Slack we use warn level so that alerts still fire in for the case when the topic is not found.

### Modifications

* Replace `info` with `warn` when topic is not found in the `ServerCnx` class.
- [x] `doc-not-needed`
@eolivelli eolivelli force-pushed the impl/max-consumer-buffer-size branch from 4e68b80 to 030b8a5 Compare October 12, 2022 07:12
eolivelli and others added 22 commits October 12, 2022 10:58
)

### Motivation
The TransactionImpl stores a lot of future. This uses a lot of memory and can be optimized to two futures.
### Modification
Optimize the future list to a single future.
…w and Qa. (apache#18003)

* [improve][docs] Improve docs for Bookkeeper E, Qw and Qa.
* [improve][misc] Highlight change to threading 

Whenever a PR changes the threading model we need to make clear that we should track these changes

* Fix typo
… from OODM

Modifications:
- limit the global number of pending reads to BookKeeper
- new configuration entry managedLedgerMaxPendingReadsBufferSizeInMB (0 = feature disabled)
- we estimate the entry size per-topic, using the size of the last read entry (new metric pulsar_ml_pending_reads_estimated_entry_size, per topic)
- new metric pulsar_ml_pending_reads_buffer_sizeto get the estimated size of in-flight read requests in bytes
- if the feature is disabled this changed does not add significant overhead

Result:
This prevents the broker from going to OutOfMemory (direct memory) in case of many concurrent reads from the bookie
…agedLedgerFactoryConfig.java

Co-authored-by: Michael Marshall <[email protected]>
@eolivelli eolivelli force-pushed the impl/max-consumer-buffer-size branch from 4616050 to 88c9bc4 Compare October 14, 2022 07:43
@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.