forked from apache/pulsar
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit the number of pending requests to BookKeeper to save the broker from OODM #18
Open
eolivelli
wants to merge
60
commits into
master
Choose a base branch
from
impl/max-consumer-buffer-size
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
* [improve][doc] add developers-landing page The Pulsar for Developers content block on the documentation landing page needs to link to this page. * Update getting-started-standalone.md * Update getting-started-standalone.md * move the file to /site2/docs/ * Update about.md * Update site2/docs/developers-landing.md Co-authored-by: tison <[email protected]> * Update site2/docs/getting-started-standalone.md Co-authored-by: tison <[email protected]> * [doc][improve] Update concepts-messaging.md Minor content edits, add / replace images to improve clarity and consistency. * Update site2/docs/concepts-messaging.md Co-authored-by: Anonymitaet <[email protected]> Co-authored-by: momo-jun <[email protected]> Co-authored-by: tison <[email protected]> Co-authored-by: Anonymitaet <[email protected]>
Signed-off-by: Zixuan Liu <[email protected]>
Co-authored-by: leolinchen <[email protected]>
…pache#17797) Co-authored-by: leolinchen <[email protected]>
…#17968) * [cleanup][broker][Modernizer] fix violations in pulsar-broker
* [fxi][doc] Rewrite the steps of docker-deploy ### Motivation The old implementation is incompletely. ### Modification Rewrite it.
…ered when using batch receive and trigger timeout. (apache#17318)
* [fix][doc] SVG files and references Signed-off-by: tison <[email protected]> Co-authored-by: Dave Duggins <[email protected]> * fix one more broken syntax on the fly Signed-off-by: tison <[email protected]> Signed-off-by: tison <[email protected]> Co-authored-by: Dave Duggins <[email protected]>
…18002) * [fix][CI] Use GitHub Actions actions/checkout@v3 - Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ * Also upgrade actions/cache and actions/setup-java
…Codecov (apache#17382) * [improve][ci] Generate jacoco code coverage reports and upload to CodeCov * [improve][ci] Generate jacoco code coverage reports and upload to CodeCov * [improve][ci] Generate jacoco code coverage reports and upload to CodeCov * [improve][ci] Generate jacoco code coverage reports and upload to CodeCov * Add codecov configuration file * Update codecov.yml Co-authored-by: tison <[email protected]> * Change codecov comment behaviour configuration to default to reduce the email notification times. * Allow CodeCov upload report job can be failure * Include only apache/pulsar class to generate jacoco tests * Include only apache/pulsar class to generate jacoco tests * Exclude class files in META-INF and skip pulsar-all-docker-image in test_group_other * Remove generate jacoco reports step in pulsar-ci Co-authored-by: tison <[email protected]>
…QueueFull enabled (apache#17795)
…#16225) ### Motivation In apache#13950, we switched an error log to an info log. @hsaputra requested on Pulsar Slack we use warn level so that alerts still fire in for the case when the topic is not found. ### Modifications * Replace `info` with `warn` when topic is not found in the `ServerCnx` class. - [x] `doc-not-needed`
4e68b80
to
030b8a5
Compare
…eadsManager (apache#17995) Co-authored-by: Enrico Olivelli <il>
Co-authored-by: leolinchen <[email protected]>
…w and Qa. (apache#18003) * [improve][docs] Improve docs for Bookkeeper E, Qw and Qa.
* [improve][misc] Highlight change to threading Whenever a PR changes the threading model we need to make clear that we should track these changes * Fix typo
…ache#18024) Co-authored-by: huangzegui <[email protected]>
… from OODM Modifications: - limit the global number of pending reads to BookKeeper - new configuration entry managedLedgerMaxPendingReadsBufferSizeInMB (0 = feature disabled) - we estimate the entry size per-topic, using the size of the last read entry (new metric pulsar_ml_pending_reads_estimated_entry_size, per topic) - new metric pulsar_ml_pending_reads_buffer_sizeto get the estimated size of in-flight read requests in bytes - if the feature is disabled this changed does not add significant overhead Result: This prevents the broker from going to OutOfMemory (direct memory) in case of many concurrent reads from the bookie
…agedLedgerFactoryConfig.java Co-authored-by: Michael Marshall <[email protected]>
4616050
to
88c9bc4
Compare
The pr had no activity for 30 days, mark with Stale label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream PR: apache#17953