Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][doc] Add doc preview reminder to PR template #17999

Merged
merged 2 commits into from
Oct 11, 2022
Merged

[improve][doc] Add doc preview reminder to PR template #17999

merged 2 commits into from
Oct 11, 2022

Conversation

Anonymitaet
Copy link
Member

@Anonymitaet Anonymitaet commented Oct 11, 2022 •
edited
Loading

This PR adds a reminder for users to attach local preview screenshots to PR descriptions.

Context: #17853 (comment)

  • doc

@Anonymitaet Anonymitaet added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Oct 11, 2022
@Anonymitaet Anonymitaet added this to the 2.11.0 milestone Oct 11, 2022
@Anonymitaet Anonymitaet self-assigned this Oct 11, 2022
@Anonymitaet Anonymitaet mentioned this pull request Oct 11, 2022
Merged
@Anonymitaet
Copy link
Member Author

@tisonkun @liangyepianzhou @momo-jun @DaveDuggins
could you please review this PR? Thank you!

tisonkun
tisonkun approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't no harm to add it. Although, I think the final guard should be always better reviews :)

@Anonymitaet Anonymitaet merged commit 3680685 into apache:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@liangyepianzhou liangyepianzhou liangyepianzhou approved these changes

@momo-jun momo-jun momo-jun approved these changes

Assignees

@Anonymitaet Anonymitaet

Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. ready-to-test
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Anonymitaet @tisonkun @liangyepianzhou @momo-jun