[fix][broker] Fix system service namespace create internal event topic. #17867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
added
type/enhancement
pulsar-broker/src/test/java/org/apache/pulsar/broker/systopic/PartitionedSystemTopicTest.java
Show resolved
Hide resolved
codelipenghui
approved these changes
Oct 8, 2022
mattisonchao
approved these changes
Oct 8, 2022
| @@ -1567,7 +1567,8 @@ public CompletableFuture<ManagedLedgerConfig> getManagedLedgerConfig(TopicName t | |||
| RetentionPolicies retentionPolicies = null; | |||
| OffloadPoliciesImpl topicLevelOffloadPolicies = null; | |||
|
|
|||
| if (pulsar.getConfig().isTopicLevelPoliciesEnabled()) { | |||
| if (pulsar.getConfig().isTopicLevelPoliciesEnabled() | |||
| && !NamespaceService.isSystemServiceNamespace(namespace.toString())) { | |||
There was a problem hiding this comment.
Maybe we can also move this check !NamespaceService.isSystemServiceNamespace(namespace.toString()) to pulsar.getTopicPoliciesService().getTopicPolicies(topicName)?
Because I see you already check it at SystemTopicBasedTopicPoliciesService#sendTopicPolicyEvent.
There was a problem hiding this comment.
Ah, we should avoid creating the topic first. This is the root cause.
mattisonchao
reviewed
Oct 8, 2022
| @@ -101,6 +101,10 @@ public CompletableFuture<Void> updateTopicPoliciesAsync(TopicName topicName, Top | |||
|
|
|||
| private CompletableFuture<Void> sendTopicPolicyEvent(TopicName topicName, ActionType actionType, | |||
| TopicPolicies policies) { | |||
| if (NamespaceService.isHeartbeatNamespace(topicName.getNamespaceObject())) { | |||
There was a problem hiding this comment.
Why don't we use NamespaceService#isSystemServiceNamespace?
There was a problem hiding this comment.
Keep the same with line 240.
Technoboy-
force-pushed
the
fix-health-check-topic-policy-1
branch
from
ee9c33b to
e5c3372
Compare
Technoboy-
force-pushed
the
fix-health-check-topic-policy-1
branch
from
e5c3372 to
cf1d485
Compare
Codecov Report
@@ Coverage Diff @@
## master #17867 +/- ##
=========================================
Coverage ? 46.73%
Complexity ? 17838
=========================================
Files ? 1573
Lines ? 128214
Branches ? 14099
=========================================
Hits ? 59923
Misses ? 62135
Partials ? 6156
Flags with carried forward coverage won't be shown. Click here to find out more. |
Technoboy-
added a commit
that referenced
this pull request
Oct 13, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 13, 2022
…c. (apache#17867) (cherry picked from commit 29baa0b)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 10, 2023
…c. (apache#17867) (cherry picked from commit 29baa0b) (cherry picked from commit 14d68a4)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 11, 2023
…c. (apache#17867) (cherry picked from commit 29baa0b) (cherry picked from commit 14d68a4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix system service namespace(heartbeat namespace) creates internal
__change_eventstopics:Documentation
doc-not-needed(Please explain why)
Matching PR in forked repository
PR in forked repository: https://github.com/Technoboy-/pulsar/pull/8