Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system service namespace create internal event topic. #8

Closed
wants to merge 7 commits into from

Conversation

Technoboy-
Copy link
Owner

Fixes #

Master Issue: #

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

Matching PR in forked repository

PR in forked repository: <!-- ENTER URL HERE

After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.

apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.

The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.

-->

@Technoboy- Technoboy- force-pushed the fix-health-check-topic-policy-1 branch from ee9c33b to e5c3372 Compare October 10, 2022 04:37
michaeljmarshall and others added 6 commits October 12, 2022 00:06
…#16225)

### Motivation

In apache#13950, we switched an error log to an info log. @hsaputra requested on Pulsar Slack we use warn level so that alerts still fire in for the case when the topic is not found.

### Modifications

* Replace `info` with `warn` when topic is not found in the `ServerCnx` class.
- [x] `doc-not-needed`
@Technoboy- Technoboy- force-pushed the fix-health-check-topic-policy-1 branch from e5c3372 to cf1d485 Compare October 12, 2022 07:03
@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Nov 12, 2022
@Technoboy- Technoboy- closed this Dec 8, 2022
@Technoboy- Technoboy- deleted the fix-health-check-topic-policy-1 branch November 11, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants