[improve][misc] Highlight change to threading #18025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever a PR changes the threading model we need to make clear that we should track these changes
dave2wave
requested review from
Anonymitaet,
michaeljmarshall and
urfreespace
michaeljmarshall
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
LGTM. Do we have a central doc for tracking this model? I know you've started the work, but maybe we need an issue to track its completion? It would also make sense to (eventually) document our concurrency model in the contributors guide. Thanks for starting this work @dave2wave!
tisonkun
reviewed
Oct 13, 2022
Anonymitaet
approved these changes
Oct 13, 2022
I'm going to sorting out the following resource to a contribution guide (doc page) like: https://devguide.python.org/:
The display, instead of the content layout, will be like: https://inlong.apache.org/community/how-to-contribute/ Perhaps start a discussion on the mailing list with a prototype later this month. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a PR changes the threading model we need to make clear that we should track these changes
Motivation
I want follow changes in the threading model in order to help understand and document Pulsar's internal architecture.
Adding a checkbox should hopefully make developers more thoughtful about explicitly noting changes to the threading model.
Modifications
Adds a checkbox about "the threading model"
Verifying this change
This change is to the PULL REQUEST TEMPLATE no test coverage required.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-complete