Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Update 404 message for deleteSubscription #17134

Merged
merged 3 commits into from
Oct 10, 2022

Conversation

lordcheng10
Copy link
Contributor

@lordcheng10 lordcheng10 commented Aug 17, 2022

Motivation

Update deleteSubscription returns 404 meaning: Topic or subscription does not exist:
image

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

Matching PR in forked repository

PR in forked repository: lordcheng10#24

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Aug 17, 2022
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10 lordcheng10 changed the title [fix][doc] Update deleteSubscription returns 404 meaning: Topic or subscription does not exist [fix][doc] Update deleteSubscription 404 doc: Topic or subscription does not exist Aug 18, 2022
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@Anonymitaet Anonymitaet added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-not-needed Your PR changes do not impact docs labels Aug 22, 2022
@Anonymitaet Anonymitaet added this to the 2.11.0 milestone Aug 22, 2022
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

3 similar comments
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10 lordcheng10 force-pushed the fix_doc_deleteSubscription branch from 9fadb33 to 9bff019 Compare August 26, 2022 03:49
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

2 similar comments
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10 lordcheng10 force-pushed the fix_doc_deleteSubscription branch from 9bff019 to d09e685 Compare September 1, 2022 12:04
@lordcheng10 lordcheng10 changed the title [fix][doc] Update deleteSubscription 404 doc: Topic or subscription does not exist [fix][broker] Update deleteSubscription 404 doc: Topic or subscription does not exist Sep 2, 2022
@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. labels Sep 2, 2022
@lordcheng10 lordcheng10 force-pushed the fix_doc_deleteSubscription branch from d09e685 to 056a21a Compare October 9, 2022 03:27
@lordcheng10 lordcheng10 changed the title [fix][broker] Update deleteSubscription 404 doc: Topic or subscription does not exist [fix][broker] Update 404 message for deleteSubscription Oct 9, 2022
@lordcheng10
Copy link
Contributor Author

CI all passed: lordcheng10#24

@AnonHxy
Copy link
Contributor

AnonHxy commented Oct 10, 2022

/pulsarbot run-failure-checks

@AnonHxy AnonHxy modified the milestones: 2.11.0, 2.12.0 Oct 10, 2022
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@AnonHxy AnonHxy merged commit 5e6736a into apache:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants