-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Fix incorrect bundle split count metric #17970
Merged
codelipenghui
merged 2 commits into
apache:master
from
Shawyeok:fix-bundle-split-metric
Oct 11, 2022
Merged
[fix][broker] Fix incorrect bundle split count metric #17970
codelipenghui
merged 2 commits into
apache:master
from
Shawyeok:fix-bundle-split-metric
Oct 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2bd42d7
to
1b7140a
Compare
@Shawyeok Please add the following content to your PR description and select a checkbox:
|
@hangc0276 Please take a review, thanks. |
/pulsarbot rerun-failure-checks |
1 similar comment
/pulsarbot rerun-failure-checks |
codelipenghui
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me.
hangc0276
approved these changes
Oct 10, 2022
Technoboy-
approved these changes
Oct 10, 2022
congbobo184
pushed a commit
that referenced
this pull request
Nov 26, 2022
(cherry picked from commit 882fcfb)
momo-jun
added a commit
to momo-jun/pulsar
that referenced
this pull request
Dec 9, 2022
4 tasks
liangyepianzhou
pushed a commit
that referenced
this pull request
Dec 14, 2022
(cherry picked from commit 882fcfb)
4 tasks
Technoboy-
pushed a commit
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
cherry-picked/branch-2.9
Archived: 2.9 is end of life
cherry-picked/branch-2.10
cherry-picked/branch-2.11
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
ready-to-test
release/2.9.4
release/2.10.3
release/2.11.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Suppose there is a non-partitioned topic has more than 1000 producers (1000 is
loadBalancerNamespaceBundleMaxSessions
default value),pulsar_lb_bundles_split_count
metric will increase constantly due to corresponding bundle reached maxBundleSessions, even the bundle range is 1 (upper - lower) that actually will skip this bundle.Modifications
Only increase
pulsar_lb_bundles_split_count
metric if bundle splits succeed.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
Matching PR in forked repository
PR in forked repository: Shawyeok#2