Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Fix incorrect bundle split count metric #17970

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

Shawyeok
Copy link
Contributor

@Shawyeok Shawyeok commented Oct 8, 2022

Motivation

Suppose there is a non-partitioned topic has more than 1000 producers (1000 is loadBalancerNamespaceBundleMaxSessions default value), pulsar_lb_bundles_split_count metric will increase constantly due to corresponding bundle reached maxBundleSessions, even the bundle range is 1 (upper - lower) that actually will skip this bundle.

Modifications

Only increase pulsar_lb_bundles_split_count metric if bundle splits succeed.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc

Matching PR in forked repository

PR in forked repository: Shawyeok#2

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 8, 2022
@Shawyeok Shawyeok force-pushed the fix-bundle-split-metric branch from 2bd42d7 to 1b7140a Compare October 8, 2022 18:34
@github-actions github-actions bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs labels Oct 8, 2022
@github-actions
Copy link

github-actions bot commented Oct 8, 2022

@Shawyeok Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-label-missing labels Oct 8, 2022
@Shawyeok
Copy link
Contributor Author

Shawyeok commented Oct 9, 2022

@hangc0276 Please take a review, thanks.

@Shawyeok Shawyeok changed the title [broker] Fix incorrect bundle split count metric [fix][broker] Fix incorrect bundle split count metric Oct 9, 2022
@Shawyeok
Copy link
Contributor Author

Shawyeok commented Oct 9, 2022

/pulsarbot rerun-failure-checks

1 similar comment
@Shawyeok
Copy link
Contributor Author

Shawyeok commented Oct 9, 2022

/pulsarbot rerun-failure-checks

Copy link
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me.

@codelipenghui codelipenghui merged commit 882fcfb into apache:master Oct 11, 2022
@congbobo184 congbobo184 added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Nov 14, 2022
congbobo184 pushed a commit that referenced this pull request Nov 26, 2022
momo-jun added a commit to momo-jun/pulsar that referenced this pull request Dec 9, 2022
liangyepianzhou pushed a commit that referenced this pull request Dec 14, 2022
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jan 10, 2023
(cherry picked from commit 882fcfb)
(cherry picked from commit c0e7cdf)
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jan 11, 2023
(cherry picked from commit 882fcfb)
(cherry picked from commit c0e7cdf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker cherry-picked/branch-2.9 Archived: 2.9 is end of life cherry-picked/branch-2.10 cherry-picked/branch-2.11 doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. ready-to-test release/2.9.4 release/2.10.3 release/2.11.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants