Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][doc] Sync 2.9.4-specific updates to 2.9.x docs #18830

Closed
wants to merge 6 commits into from

Conversation

momo-jun
Copy link
Contributor

@momo-jun momo-jun commented Dec 9, 2022

Modifications

Sync 2.9.4-specific updates to 2.9.x docs as per

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Dec 9, 2022
@momo-jun momo-jun changed the title [feature][doc] Sync 2.9.4/2.10.3-specific updates to 2.9.x/2.10.x docs [feat][doc] Sync 2.9.4-specific updates to 2.9.x docs Dec 9, 2022
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Does it mean that we add new configure option even in a patch release?

@momo-jun
Copy link
Contributor Author

momo-jun commented Dec 9, 2022

Interesting. Does it mean that we add new configure option even in a patch release?

Seems true and there is no boundary clarified on this as far as I know. Maybe it was added for specific users to fix their needs with an upgrade.

@momo-jun momo-jun marked this pull request as ready for review December 29, 2022 03:09
@momo-jun momo-jun self-assigned this Dec 29, 2022
# When using the InMemoryDelayedDeliveryTrackerFactory (the default DelayedDeliverTrackerFactory), whether
# the deliverAt time is strictly followed. When false (default), messages may be sent to consumers before the deliverAt
# time by as much as the tickTimeMillis. This can reduce the overhead on the broker of maintaining the delayed index
# for a potentially very short time period. When true, messages will not be sent to consumer until the deliverAt time
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# for a potentially very short time period. When true, messages will not be sent to consumer until the deliverAt time
# for a potentially very short time period. When true, messages are not sent to consumers until the deliverAt time

@momo-jun
Copy link
Contributor Author

Since the docs have been migrated to the Pulsar-site repo, so I've replicated the updates in apache/pulsar-site#350 and closed this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants