[improve][connector] JDBC sink: allow any jdbc driver #17951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
approved these changes
Oct 9, 2022
|
/pulsarbot rerun-failure-checks |
nicoloboschi
added a commit
to datastax/pulsar
that referenced
this pull request
Oct 18, 2022
(cherry picked from commit 5c31c9a)
Technoboy-
pushed a commit
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
At the moment in the JDBC core module there's a mapping between JDBC url and the driver class name. This limits the possibility to take the JDBC core and put a different JDBC driver. Also the class name driver initialization is not helpful at all since the first time the JDBC api will try to find a driver is just in the next line while creating a new connection.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete