Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][io] Fix builtin sink transformation on k8s #18019

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

cbornet
Copy link
Contributor

@cbornet cbornet commented Oct 12, 2022

Motivation

Fixes a NPE with transform-function+Sink on k8s because builtin is null in getFunctionPackageLocation.
There is no issue when not in k8s because then the packageUrl is used for the packagePath and its value is builtin://xxx

Modifications

Use the builtin from the functionDetails that was previously set in SinkConfigUtils::convert

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: cbornet#3

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 12, 2022
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbornet cbornet changed the title [fix][connectors] Fix builtin sink transformation on k8s [fix][io] Fix builtin sink transformation on k8s Oct 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@92b4708). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #18019   +/-   ##
=========================================
  Coverage          ?   50.97%           
  Complexity        ?     8716           
=========================================
  Files             ?      607           
  Lines             ?    53396           
  Branches          ?     5712           
=========================================
  Hits              ?    27218           
  Misses            ?    23125           
  Partials          ?     3053           
Flag Coverage Δ
unittests 50.97% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/function doc-not-needed Your PR changes do not impact docs type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants