Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][test] Improve KeySharedSubscriptionTest to reduce the execution time #18027

Merged

Conversation

poorbarcode
Copy link
Contributor

@poorbarcode poorbarcode commented Oct 13, 2022

Fixes #17635

Modifications

  • Use the namespace-clean instead pulsar-restart, saves pulsar.start() and pulsar.stop() time before and after each method.

After improve, KeySharedSubscriptionTest cost 210s

[INFO] Tests run: 43, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 210.841 s - in org.apache.pulsar.client.api.KeySharedSubscriptionTest

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@poorbarcode poorbarcode changed the title [ci-run][improve][test] Improve KeySharedSubscriptionTest to reduce the execution time [improve][test] Improve KeySharedSubscriptionTest to reduce the execution time Oct 13, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 13, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #18027 (bedf413) into master (6c65ca0) will increase coverage by 5.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18027      +/-   ##
============================================
+ Coverage     34.91%   39.95%   +5.03%     
- Complexity     5707     6382     +675     
============================================
  Files           607      607              
  Lines         53396    53400       +4     
  Branches       5712     5712              
============================================
+ Hits          18644    21336    +2692     
+ Misses        32119    29172    -2947     
- Partials       2633     2892     +259     
Flag Coverage Δ
unittests 39.95% <ø> (+5.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...naming/RangeEquallyDivideBundleSplitAlgorithm.java 0.00% <0.00%> (-100.00%) ⬇️
...r/common/naming/NamespaceBundleSplitAlgorithm.java 0.00% <0.00%> (-61.54%) ⬇️
...on/buffer/impl/InMemTransactionBufferProvider.java 0.00% <0.00%> (-50.00%) ⬇️
...apache/pulsar/common/naming/BundleSplitOption.java 0.00% <0.00%> (-40.00%) ⬇️
...ar/broker/loadbalance/impl/SimpleResourceUnit.java 28.57% <0.00%> (-23.81%) ⬇️
...ar/broker/loadbalance/impl/BundleSplitterTask.java 57.77% <0.00%> (-20.01%) ⬇️
...e/pulsar/common/naming/NamespaceBundleFactory.java 36.66% <0.00%> (-16.12%) ⬇️
...g/apache/pulsar/broker/admin/impl/TenantsBase.java 29.07% <0.00%> (-12.77%) ⬇️
.../apache/pulsar/common/naming/NamespaceBundles.java 57.83% <0.00%> (-10.85%) ⬇️
...ersistentStickyKeyDispatcherMultipleConsumers.java 45.19% <0.00%> (-10.58%) ⬇️
... and 127 more

@poorbarcode
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@Technoboy- Technoboy- merged commit 1ecb9c7 into apache:master Oct 14, 2022
@poorbarcode poorbarcode deleted the slow/KeySharedSubscriptionTest branch October 14, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slowly-test: KeySharedSubscriptionTest
3 participants