[fix][broker] Update the log print content of createSubscriptions #18024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnonHxy
approved these changes
Oct 13, 2022
Jason918
approved these changes
Oct 13, 2022
Jason918
changed the title
Technoboy-
approved these changes
Oct 13, 2022
Technoboy-
changed the title
Codecov Report
@@ Coverage Diff @@
## master #18024 +/- ##
=========================================
Coverage ? 51.19%
Complexity ? 7125
=========================================
Files ? 393
Lines ? 43422
Branches ? 4462
=========================================
Hits ? 22230
Misses ? 18724
Partials ? 2468
Flags with carried forward coverage won't be shown. Click here to find out more. |
congbobo184
pushed a commit
that referenced
this pull request
Nov 14, 2022
…8024) Co-authored-by: huangzegui <[email protected]> (cherry picked from commit 230e7dc)
liangyepianzhou
pushed a commit
that referenced
this pull request
Dec 7, 2022
…8024) Co-authored-by: huangzegui <[email protected]> (cherry picked from commit 230e7dc)
congbobo184
pushed a commit
that referenced
this pull request
Dec 7, 2022
…8024) Co-authored-by: huangzegui <[email protected]> (cherry picked from commit 230e7dc)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 10, 2023
…ache#18024) Co-authored-by: huangzegui <[email protected]> (cherry picked from commit 230e7dc) (cherry picked from commit 7041727)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 11, 2023
…ache#18024) Co-authored-by: huangzegui <[email protected]> (cherry picked from commit 230e7dc) (cherry picked from commit 7041727)
Technoboy-
pushed a commit
that referenced
this pull request
Feb 8, 2023
…8024) Co-authored-by: huangzegui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In
org.apache.pulsar.broker.admin.impl.PersistentTopicsBase#createSubscriptions, when subscriptions are successfully created on the new partitions, the log print content is "successfully created new partitions", not "successfully created subscriptions on new partitions".Modifications
In
org.apache.pulsar.broker.admin.impl.PersistentTopicsBase#createSubscriptions, when subscriptions are successfully created on the new partitions, change the log printing content from "Successfully created new partitions" to "Successfully created subscriptions on new partitions".Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: Pomelongan#8