Merge dro's RWHV and my EwkViewWrapper #9

rakuco · 2013-06-18T14:22:40Z

SSIA.

(cherry picked from commit 0bc0e7d)

(cherry picked from commit 071f50b)

This is a hack that allows us to have an Evas_Object to return in WebContentsViewEfl even when we don't have a parent yet.

Here be dragons: reinterpret_casts everywhere etc.

xingnan · 2013-06-18T14:22:49Z

Trybot Dashboard

Building status:

Finished the build of the PATCH in this pull request

[content_linux] Failed LOGS
[content_win] Failed LOGS
[content_android] Failed LOGS

Rebuild the failed bots you want!

Select the bots:

content_linux
content_win
content_android

Start the building:

< START >

…w_proto Fix scale factor

In crrev.com/228189, we had to add horrible hacks to workaround an urgent P1 issue, which needed to be merged to M31 branch immediately. The hacks are no longer necesssary, as the system salt is obtained before DeviceOAuth2TokenService is created. See crbug.com/309959 for details. BUG=306547 TEST=see the bug comment #9 [email protected] Review URL: https://codereview.chromium.org/43203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230969 0039d316-1c4b-4281-b951-d872f2087c98

…org/140583003/) Reason for revert: Appears to have caused a memory leak. http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%282%29/builds/23519/steps/content_unittests/logs/AvailableService Indirect leak of 176 byte(s) in 1 object(s) allocated from: #0 0x49c001 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:54 #1 0xf42228 in content::PowerProfilerServiceTest::ServiceStartTest() content/browser/power_profiler/power_profiler_service_unittest.cc:85 #2 0xf4212d in content::PowerProfilerServiceTest_AvailableService_Test::TestBody() content/browser/power_profiler/power_profiler_service_unittest.cc:138 #3 0x2d3587a in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #4 0x2d3587a in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #5 0x2d379ca in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #6 0x2d38793 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #7 0x2d4984a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #8 0x2d48e30 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #9 0x2d48e30 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #10 0x2cc09cc in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #11 0x2cc09cc in base::TestSuite::Run() base/test/test_suite.cc:213 #12 0x2cb4041 in Run base/callback.h:401 #13 0x2cb4041 in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494 #14 0x195d8ce in main content/test/run_all_unittests.cc:14 #15 0x7f515353d76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > This CL implemented part of chrome power profiler, including the service, data provider and observer base. > > BUG=337138 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254116 [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=337138 Review URL: https://codereview.chromium.org/184583004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254146 0039d316-1c4b-4281-b951-d872f2087c98

This caused a memory leak. It appears |suggestions| was mismanaged? http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASAN%20Tests%20%283%29/builds/13714/steps/unit_tests/logs/OfflinePageDontProceed Direct leak of 40 byte(s) in 1 object(s) allocated from: #0 0x4b1711 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:54 #1 0x61e7518 in LocalizedError::GetStrings(int, std::string const&, GURL const&, bool, bool, std::string const&, std::string const&, scoped_ptr\u003CLocalizedError::ErrorPageParams, base::DefaultDeleter\u003CLocalizedError::ErrorPageParams> >, base::DictionaryValue*) chrome/common/localized_error.cc:686 #2 0x111d82c0 in chromeos::OfflineLoadPage::GetHTMLContents() chrome/browser/chromeos/offline/offline_load_page.cc:98 #3 0xfb6f1fd in content::InterstitialPageImpl::Show() content/browser/frame_host/interstitial_page_impl.cc:248 #4 0x13fc43e in chromeos::OfflineLoadPageTest::ShowInterstitial(char const*) chrome/browser/chromeos/offline/offline_load_page_unittest.cc:71 #5 0x13fc870 in chromeos::OfflineLoadPageTest_OfflinePageDontProceed_Test::TestBody() chrome/browser/chromeos/offline/offline_load_page_unittest.cc:128 #6 0x800bf1a in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #7 0x800bf1a in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #8 0x800e349 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #9 0x800f0c3 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #10 0x801fd1a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #11 0x801f320 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #12 0x801f320 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #13 0x129f3154 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #14 0x129f3154 in base::TestSuite::Run() base/test/test_suite.cc:213 #15 0x129ea3b7 in Run base/callback.h:401 #16 0x129ea3b7 in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494 #17 0x820ee6d in main chrome/test/base/run_all_unittests.cc:13 #18 0x7f1d7d44d76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 > Switch to using the new Link Doctor API. > > The new API allows Link Doctor results to be integrated into Chrome's > own error pages. > > BUG=64832 > [email protected], [email protected], [email protected], [email protected] > > Review URL: https://codereview.chromium.org/137623011 [email protected] Review URL: https://codereview.chromium.org/185003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254241 0039d316-1c4b-4281-b951-d872f2087c98

This made the Asan bot unhappy http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASan%2BLSan%20Tests%20%282%29&number=396 P2PSocketHostTest.TestInvalidTurnChannelMessages (run #1): [ RUN ] P2PSocketHostTest.TestInvalidTurnChannelMessages ================================================================= ==13684==ERROR: AddressSanitizer: global-buffer-overflow on address 0x00000cc54404 at pc 0x278fe5c bp 0x7fff34be4350 sp 0x7fff34be4348 READ of size 1 at 0x00000cc54404 thread T0 #0 0x278fe5b in IsRtpPacket content/browser/renderer_host/p2p/socket_host.cc:54 #1 0x278fe5b in content::packet_processing_helpers::GetRtpPacketStartPositionAndLength(char*, int, int*, int*) content/browser/renderer_host/p2p/socket_host.cc:304 #2 0x1f5a542 in content::P2PSocketHostTest_TestInvalidTurnChannelMessages_Test::TestBody() content/browser/renderer_host/p2p/socket_host_unittest.cc:208 #3 0x2c38e7a in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #4 0x2c38e7a in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #5 0x2c3afca in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #6 0x2c3bd93 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #7 0x2c4ce4a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #8 0x2c4c430 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #9 0x2c4c430 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #10 0x2bcad1c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #11 0x2bcad1c in base::TestSuite::Run() base/test/test_suite.cc:213 #12 0x2bbebbb in Run base/callback.h:401 #13 0x2bbebbb in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494 #14 0x198401e in main content/test/run_all_unittests.cc:14 #15 0x7f28c9fa576c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 #16 0x4b322c in _start (/b/build/slave/Linux_ASan_LSan_Tests__2_/build/src/out/Release/content_unittests+0x4b322c) 0x00000cc54404 is located 60 bytes to the left of global variable 'kRtpMsgWith2ByteExtnHeader' from '../../content/browser/renderer_host/p2p/socket_host_unittest.cc' (0xcc54440) of size 20 0x00000cc54404 is located 0 bytes to the right of global variable 'kTurnChannelMsgWithZeroLength' from '../../content/browser/renderer_host/p2p/socket_host_unittest.cc' (0xcc54400) of size 4 SUMMARY: AddressSanitizer: global-buffer-overflow content/browser/renderer_host/p2p/socket_host.cc:54 IsRtpPacket Shadow bytes around the buggy address: 0x000081982830: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x000081982840: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x000081982850: 00 00 f9 f9 f9 f9 f9 f9 00 00 f9 f9 f9 f9 f9 f9 0x000081982860: 00 00 04 f9 f9 f9 f9 f9 00 00 04 f9 f9 f9 f9 f9 0x000081982870: 00 00 00 04 f9 f9 f9 f9 00 f9 f9 f9 f9 f9 f9 f9 =>0x000081982880:[04]f9 f9 f9 f9 f9 f9 f9 00 00 04 f9 f9 f9 f9 f9 0x000081982890: 00 00 00 f9 f9 f9 f9 f9 00 00 00 00 00 04 f9 f9 0x0000819828a0: f9 f9 f9 f9 00 00 00 00 00 00 00 f9 f9 f9 f9 f9 0x0000819828b0: 00 00 f9 f9 f9 f9 f9 f9 00 00 00 f9 f9 f9 f9 f9 0x0000819828c0: 03 f9 f9 f9 f9 f9 f9 f9 00 00 05 f9 f9 f9 f9 f9 0x0000819828d0: 04 f9 f9 f9 f9 f9 f9 f9 00 00 00 00 00 00 00 00 > This CL adds methods to manipulate RTP header extension, particularly > AbsoulteSendTime extension. If there is matching extension ID present > in RTP packet, we will update with the current time. > > [email protected], [email protected], [email protected] > > BUG= > > Review URL: https://codereview.chromium.org/159353002 [email protected] Review URL: https://codereview.chromium.org/197933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256584 0039d316-1c4b-4281-b951-d872f2087c98

The linux asan bot went red ResourceDispatcherHostTest.DownloadToFile (run #1): [ RUN ] ResourceDispatcherHostTest.DownloadToFile [ OK ] ResourceDispatcherHostTest.DownloadToFile (212 ms) [----------] 1 test from ResourceDispatcherHostTest (212 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (213 ms total) [ PASSED ] 1 test. YOU HAVE 5 DISABLED TESTS ================================================================= ==9125==ERROR: LeakSanitizer: detected memory leaks Direct leak of 16 byte(s) in 1 object(s) allocated from: #0 0x49be81 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:54 #1 0x23ce695 in content::ResourceDispatcherHostImpl::BeginRequest(int, ResourceHostMsg_Request const&, IPC::Message*, int) content/browser/loader/resource_dispatcher_host_impl.cc:1045 #2 0x23cba80 in OnRequestResource content/browser/loader/resource_dispatcher_host_impl.cc:879 #3 0x23cba80 in Dispatch\u003Ccontent::ResourceDispatcherHostImpl, content::ResourceDispatcherHostImpl, int, const ResourceHostMsg_Request &> content/common/resource_messages.h:305 #4 0x23cba80 in content::ResourceDispatcherHostImpl::OnMessageReceived(IPC::Message const&, content::ResourceMessageFilter*, bool*) content/browser/loader/resource_dispatcher_host_impl.cc:841 #5 0xe04954 in content::ResourceDispatcherHostTest_DownloadToFile_Test::TestBody() content/browser/loader/resource_dispatcher_host_unittest.cc:2840 #6 0x2c10c9a in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #7 0x2c10c9a in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #8 0x2c12dea in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #9 0x2c13bb3 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #10 0x2c24c6a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #11 0x2c24250 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #12 0x2c24250 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #13 0x2b9ed2c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #14 0x2b9ed2c in base::TestSuite::Run() base/test/test_suite.cc:213 #15 0x2b92bcb in Run base/callback.h:401 #16 0x2b92bcb in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494 #17 0x199a83e in main content/test/run_all_unittests.cc:14 #18 0x7f6e898bf76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 SUMMARY: AddressSanitizer: 16 byte(s) leaked in 1 allocation(s). http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%282%29/builds/409 > Fix various issues in RedirectToFileResourceHandler. > > - Handle errors in creating temporary files. > - Cancel on write failure instead of resuming. This used to work, but got > lost in some refactoring in r142108. > - Fix the OnResponseCompleted resume logic to account for partial writes. > - Don't lose write errors which occur after OnResponseCompleted is received. > - WeakPtrFactory goes after other members. > - OnWillStart was never forwarded to downstream handlers. > - Make sure the file is closed before deleting it. > > Also add a lot of machinery so we can better unit test this stack. > > BUG=316634,347663 > TEST=ResourceDispatcherHostTest.DownloadToFile > ResourceDispatcherHostTest.RegisterDownloadedTempFile > ResourceLoaderTest.RedirectToFile* > TemporaryFileStreamTest.Basic > > Review URL: https://codereview.chromium.org/82273002 [email protected] Review URL: https://codereview.chromium.org/196533013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256704 0039d316-1c4b-4281-b951-d872f2087c98

Turned the chromeos lsan bot red: Indirect leak of 48 byte(s) in 1 object(s) allocated from: #0 0x480201 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:54 #1 0x49e263 in ui::AXTreeSerializer\u003Cviews::View*>::SerializeChangedNodes(views::View*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:372 #2 0x49b75a in ui::AXTreeSerializer\u003Cviews::View*>::SerializeChanges(views::View*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:329 #3 0x49992d in views::AXTreeSourceViewsTest_SimpleSerialization_Test::TestBody() ui/views/accessibility/ax_tree_source_views_unittest.cc:75 #4 0xb859ba in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #5 0xb859ba in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #6 0xb874c9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #7 0xb88243 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #8 0xb98e9a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #9 0xb984a0 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #10 0xb984a0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #11 0xb51664 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #12 0xb51664 in base::TestSuite::Run() base/test/test_suite.cc:213 #13 0xb47d1d in Run base/callback.h:401 #14 0xb47d1d in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494 #15 0x80bdba in main ui/views/run_all_unittests.cc:46 #16 0x7f0caf06376c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%2BLSan%20Tests%20%281%29/builds/222/steps/views_unittests/logs/SimpleSerialization > Reland r256396 Add views implementation for AXTreeSource. > > BUG=318758 > [email protected] > > Review URL: https://codereview.chromium.org/196603003 [email protected] Review URL: https://codereview.chromium.org/196953009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256745 0039d316-1c4b-4281-b951-d872f2087c98

Leaks: Linux LSan: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/1508 E.g.: Indirect leak of 1544 byte(s) in 1 object(s) allocated from: #0 0x4fc78b in operator new(unsigned long) /usr/local/google/home/thakis/src/chrome/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 #1 0x232ebeb in allocate /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/ext/new_allocator.h:92 #2 0x232ebeb in _M_allocate /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_vector.h:150 #3 0x232ebeb in _M_allocate_and_copy<std::move_iterator<__gnu_cxx::_Hashtable_node<std::pair<const std::basic_string<char>, content::SiteInstance *> > **> > /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_vector.h:1052 #4 0x232ebeb in reserve /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/vector.tcc:74 crosswalk-project#5 0x232ebeb in _M_initialize_buckets /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/backward/hashtable.h:577 crosswalk-project#6 0x232ebeb in __gnu_cxx::hashtable<std::pair<std::string const, content::SiteInstance*>, std::string, __gnu_cxx::hash<std::string>, std::_Select1st<std::pair<std::string const, content::SiteInstance*> >, std::equal_to<std::string>, std::allocator<content::SiteInstance*> >::hashtable(unsigned long, __gnu_cxx::hash<std::string> const&, std::equal_to<std::string> const&, std::allocator<std::pair<std::string const, content::SiteInstance*> > const&) /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/backward/hashtable.h:334 crosswalk-project#7 0x232cb58 in RefCounted /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/ext/hash_map:126 crosswalk-project#8 0x232cb58 in content::BrowsingInstance::BrowsingInstance(content::BrowserContext*) content/browser/browsing_instance.cc:18 crosswalk-project#9 0x28d4131 in content::SiteInstance::Create(content::BrowserContext*) content/browser/site_instance_impl.cc:220 crosswalk-project#10 0x2db9c92 in CreateTestWebContents content/public/test/test_renderer_host.cc:138 crosswalk-project#11 0x2db9c92 in content::RenderViewHostTestHarness::SetUp() content/public/test/test_renderer_host.cc:182 crosswalk-project#12 0xda5e2d in content::RenderFrameHostManagerTest::SetUp() content/browser/frame_host/render_frame_host_manager_unittest.cc:204 crosswalk-project#13 0x2eea0f2 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2045 crosswalk-project#14 0x2eea0f2 in testing::Test::Run() testing/gtest/src/gtest.cc:2057 crosswalk-project#15 0x2eec3a9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 crosswalk-project#16 0x2eed183 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 crosswalk-project#17 0x2efe463 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 crosswalk-project#18 0x2efda30 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 crosswalk-project#19 0x2efda30 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 crosswalk-project#20 0x2e7712c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 crosswalk-project#21 0x2e7712c in base::TestSuite::Run() base/test/test_suite.cc:213 crosswalk-project#22 0x2e6aebd in Run base/callback.h:401 crosswalk-project#23 0x2e6aebd in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback<int ()> const&, int) base/test/launcher/unit_test_launcher.cc:494 crosswalk-project#24 0x1bfec66 in main content/test/run_all_unittests.cc:14 crosswalk-project#25 0x7f853fc5876c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 > Introduce RenderFrameProxyHost object and use it in RFHM. > > This is the first CL in a series to create RenderFrameProxy(Host) infrastructure. Before the Blink codebase is ready to transform local and remote frames, the proxy objects will keep internally the existing RF/RFH in swapped out state. This CL creates the browser side proxy object and wraps the swapped out RFH. > > BUG=357747 > > Review URL: https://codereview.chromium.org/217163007 [email protected] Review URL: https://codereview.chromium.org/236003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263367 0039d316-1c4b-4281-b951-d872f2087c98

…correctly. (https://codereview.chromium.org/255543009/) Reason for revert: Causes leaks: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/2046/steps/browser_tests/logs/SadTabCancelsSubframeDialogs Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x56973b in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 #1 0x52464ce in IPC::SyncMessage::GenerateReply(IPC::Message const*) ipc/ipc_sync_message.cc:99 #2 0x9f6ec47 in Tuple4 ipc/ipc_message_utils.h:877 #3 0x9f6ec47 in bool FrameHostMsg_RunJavaScriptMessage::DispatchDelayReply\u003Ccontent::RenderFrameHostImpl, void (content::RenderFrameHostImpl::*)(std::basic_string\u003Cunsigned short, base::string16_char_traits, std::allocator\u003Cunsigned short> > const&, std::basic_string\u003Cunsigned short, base::string16_char_traits, std::allocator\u003Cunsigned short> > const&, GURL const&, content::JavaScriptMessageType, IPC::Message*)>(IPC::Message const*, content::RenderFrameHostImpl*, void (content::RenderFrameHostImpl::*)(std::basic_string\u003Cunsigned short, base::string16_char_traits, std::allocator\u003Cunsigned short> > const&, std::basic_string\u003Cunsigned short, base::string16_char_traits, std::allocator\u003Cunsigned short> > const&, GURL const&, content::JavaScriptMessageType, IPC::Message*)) content/common/frame_messages.h:545 #4 0x9f6b9d3 in content::RenderFrameHostImpl::OnMessageReceived(IPC::Message const&) content/browser/frame_host/render_frame_host_impl.cc:287 #5 0xa1185d9 in content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const&) content/browser/renderer_host/render_process_host_impl.cc:1346 #6 0x5239eec in IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&) ipc/ipc_channel_proxy.cc:269 #7 0x3256fbf in Run base/callback.h:401 #8 0x3256fbf in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:450 #9 0x3258e35 in DeferOrRunPendingTask base/message_loop/message_loop.cc:462 #10 0x3258e35 in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:576 #11 0x32fab87 in base::MessagePumpGlib::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_glib.cc:270 #12 0x3290314 in base::RunLoop::Run() base/run_loop.cc:49 #13 0xc55c305 in content::RunThisRunLoop(base::RunLoop*) content/public/test/test_utils.cc:103 #14 0xc55e252 in operator-> content/public/test/test_utils.cc:165 #15 0xc55e252 in content::WindowedNotificationObserver::Wait() content/public/test/test_utils.cc:225 #16 0x31af7c1 in ui_test_utils::WaitForAppModalDialog() chrome/test/base/ui_test_utils.cc:342 #17 0x19c1ed8 in BrowserTest_SadTabCancelsSubframeDialogs_Test::RunTestOnMainThread() chrome/browser/ui/browser_browsertest.cc:585 #18 0x31996b8 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:419 Original issue's description: > Ensure that modal dialogs from subframes can be cleaned up correctly. > > BUG=366510 > TEST=See bug comment 7 for repro steps. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266638 [email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=366510 Review URL: https://codereview.chromium.org/257863004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266669 0039d316-1c4b-4281-b951-d872f2087c98

…es. (https://codereview.chromium.org/339073002/) Reason for revert: Brand new test fails in ASAN: Direct leak of 112 byte(s) in 1 object(s) allocated from: #0 0x462ccb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55 #1 0x7ee8f9 in CreateNextFrame remoting/host/video_frame_recorder_unittest.cc:96 #2 0x7ee8f9 in remoting::VideoFrameRecorderTest::CreateTestFrames() remoting/host/video_frame_recorder_unittest.cc:112 #3 0x7f1184 in remoting::VideoFrameRecorderTest_EncodeButDontRecord_Test::TestBody() remoting/host/video_frame_recorder_unittest.cc:269 #4 0xb3bf38 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2045 #5 0xb3bf38 in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #6 0xb3e1c9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #7 0xb3ef56 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #8 0xb5206a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #9 0xb516a0 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #10 0xb516a0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #11 0xab66bc in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #12 0xab66bc in base::TestSuite::Run() base/test/test_suite.cc:227 #13 0xaada32 in Run base/callback.h:401 #14 0xaada32 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498 #15 0xaad3ad in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:553 #16 0x4e8067 in main chrome/test/base/run_all_remoting_unittests.cc:31 #17 0x7f1f660df76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > Add VideoFrameRecorder for use recording test frame sequences. > > This will be used to record representative frame sequences for performance evaluation of the new VP9 encoder. > > BUG=260879 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279795 [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=260879 Review URL: https://codereview.chromium.org/350903003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279805 0039d316-1c4b-4281-b951-d872f2087c98

Seems to have introduced leaks: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/3527/steps/net_unittests/logs/stdio For example: Direct leak of 112 byte(s) in 1 object(s) allocated from: #0 0x5166cb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55 #1 0x16ce6be in MockDiskCache::CreateEntry(std::string const&, disk_cache::Entry**, base::Callback<void (int)> const&) net/http/mock_http_cache.cc:408 #2 0x37654a7 in DoCreate net/http/disk_based_cert_cache.cc:187 #3 0x37654a7 in net::DiskBasedCertCache::WriteWorker::DoLoop(int) net/http/disk_based_cert_cache.cc:158 #4 0x3768f23 in Start net/http/disk_based_cert_cache.cc:125 #5 0x3768f23 in net::DiskBasedCertCache::Set(CERTCertificateStr*, base::Callback<void (std::string const&)> const&) net/http/disk_based_cert_cache.cc:533 #6 0x10d0ffa in net::DiskBasedCertCache_SyncSet_Test::TestBody() net/http/disk_based_cert_cache_unittest.cc:231 #7 0x33ce728 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2045 #8 0x33ce728 in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #9 0x33d0f09 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #10 0x33d1c96 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #11 0x33e4daa in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #12 0x33e43e0 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #13 0x33e43e0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #14 0x40a6d1c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #15 0x40a6d1c in base::TestSuite::Run() base/test/test_suite.cc:227 #16 0x409b4e2 in Run base/callback.h:401 #17 0x409b4e2 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498 #18 0x409ae5d in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:553 #19 0x2b986cc in main net/test/run_all_unittests.cc:64 #20 0x7fc4683a976c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 > Creation of a new and improved object for the caching of certificate objects on disk. > > Review URL: https://codereview.chromium.org/329733002 [email protected] Review URL: https://codereview.chromium.org/349533004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280492 0039d316-1c4b-4281-b951-d872f2087c98

Broke the Linux ASan LSan Test(2) bot Direct leak of 16 byte(s) in 1 object(s) allocated from: #0 0x5ac35b in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55 #1 0x1df3a96 in (anonymous namespace)::BuildFaviconService(content::BrowserContext*) chrome/browser/favicon/favicon_handler_unittest.cc:1408 #2 0xf2c3cc0 in BrowserContextKeyedServiceFactory::GetServiceForBrowserContext(content::BrowserContext*, bool) components/keyed_service/content/browser_context_keyed_service_factory.cc:88 #3 0x549067a in FaviconServiceFactory::GetForProfile(Profile*, Profile::ServiceAccessType) chrome/browser/favicon/favicon_service_factory.cc:25 #4 0x1df00f4 in (anonymous namespace)::FaviconHandlerTest_UnableToDownloadFavicon_Test::TestBody() chrome/browser/favicon/favicon_handler_unittest.cc:1432 #5 0x6cc96f8 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #6 0x6cc96f8 in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #7 0x6ccbed9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #8 0x6cccc66 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #9 0x6cdfd7a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #10 0x6cdf3b0 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #11 0x6cdf3b0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #12 0x1021320c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #13 0x1021320c in base::TestSuite::Run() base/test/test_suite.cc:227 #14 0x1020a9d2 in Run base/callback.h:401 #15 0x1020a9d2 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498 #16 0x1020a34d in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:553 #17 0x6df1bee in main chrome/test/base/run_all_unittests.cc:15 #18 0x7f93160dc76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 > Pass an instance of FaviconClient to FaviconService. > > This is an intermediary CL where the FaviconClient is not used by the FaviconService. > Subsequent CLs will start using the FaviconClient in the FaviconService to abstract usage of chrome/ code. > > BUG=377505 > > Review URL: https://codereview.chromium.org/302433010 [email protected] Review URL: https://codereview.chromium.org/370663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281309 0039d316-1c4b-4281-b951-d872f2087c98

…https://codereview.chromium.org/373153002/) Reason for revert: Causing memory leaks: Indirect leak of 328 byte(s) in 1 object(s) allocated from: #0 0x515feb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55 #1 0xc334cfb in BookmarkModel::CreatePermanentNode(BookmarkNode::Type) components/bookmarks/browser/bookmark_model.cc:910 #2 0xc326772 in BookmarkModel::CreateLoadDetails(std::string const&) components/bookmarks/browser/bookmark_model.cc:1006 #3 0xc326553 in BookmarkModel::Load(PrefService*, std::string const&, base::FilePath const&, scoped_refptr\u003Cbase::SequencedTaskRunner> const&, scoped_refptr\u003Cbase::SequencedTaskRunner> const&) components/bookmarks/browser/bookmark_model.cc:151 #4 0x232a4d7 in BookmarkModelFactory::BuildServiceInstanceFor(content::BrowserContext*) const chrome/browser/bookmarks/bookmark_model_factory.cc:65 #5 0xc0bc85f in BrowserContextKeyedServiceFactory::GetServiceForBrowserContext(content::BrowserContext*, bool) components/keyed_service/content/browser_context_keyed_service_factory.cc:91 #6 0x260de89 in ProfileImpl::DoFinalInit() chrome/browser/profiles/profile_impl.cc:657 #7 0x260beb5 in ProfileImpl::OnPrefsLoaded(bool) chrome/browser/profiles/profile_impl.cc:881 #8 0x260ae3e in ProfileImpl::ProfileImpl(base::FilePath const&, Profile::Delegate*, Profile::CreateMode, base::SequencedTaskRunner*) chrome/browser/profiles/profile_impl.cc:492 #9 0x2608ddb in Profile::CreateProfile(base::FilePath const&, Profile::Delegate*, Profile::CreateMode) chrome/browser/profiles/profile_impl.cc:297 #10 0x18de165 in ProfileBrowserTest::CreateProfile(base::FilePath const&, Profile::Delegate*, Profile::CreateMode) chrome/browser/profiles/profile_browsertest.cc:106 #11 0x18df8f8 in ProfileBrowserTest_CreateOldProfileSynchronous_Test::RunTestOnMainThread() chrome/browser/profiles/profile_browsertest.cc:153 #12 0x33f5434 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:427 #13 0x2e6ca18 in Run base/callback.h:401 #14 0x2e6ca18 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1548 #15 0x2e69666 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:975 #16 0x59381d7 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:694 #17 0x5c8f207 in Run base/callback.h:401 #18 0x5c8f207 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45 #19 0x59342e0 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:594 #20 0x5e8a153 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:106 #21 0xf0228a0 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:22 #22 0xef6cbc4 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:763 #23 0xef69d3f in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19 #24 0xcf5b57f in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:253 #25 0x33f2563 in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:210 #26 0x3e81941 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #27 0x3e81941 in testing::Test::Run() testing/gtest/src/gtest.cc:2057 #28 0x3e83cd9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #29 0x3e84a66 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #30 0x3e97b7a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #31 0x3e971b0 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #32 0x3e971b0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #33 0x359557c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #34 0x359557c in base::TestSuite::Run() base/test/test_suite.cc:227 Original issue's description: > Fixed use-after-free in LoadCallback in bookmark_storage.cc > > BookmarkStorage isn't ref counted anymore since > https://codereview.chromium.org/370323002, and the LoadCallback() task > now gets a WeakPtr to the owning BookmarkStorage. However, it gets a > raw pointer to the BookmarkLoadDetails object, which is still owned > by BookmarkStorage and may have been destroyed when the background > task runs. > > This happened on iOS tests after a recent merge. > > [email protected] > BUG=165760 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281830 [email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=165760 Review URL: https://codereview.chromium.org/379643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281843 0039d316-1c4b-4281-b951-d872f2087c98

…ttps://codereview.chromium.org/386043002/) Reason for revert: Causes LSAN errors on CrOS: http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/2299/steps/ui_unittests/logs/DoubleTap e.g. Indirect leak of 2904 byte(s) in 1 object(s) allocated from: #0 0x44edfb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55 #1 0x9fbc47 in CreateStrategy ui/events/gesture_detection/velocity_tracker.cc:201 #2 0x9fbc47 in ui::VelocityTracker::VelocityTracker(ui::VelocityTracker::Strategy) ui/events/gesture_detection/velocity_tracker.cc:234 #3 0x9fa322 in ui::VelocityTrackerState::VelocityTrackerState() ui/events/gesture_detection/velocity_tracker_state.cc:18 #4 0x9f5d64 in ui::GestureDetector::GestureDetector(ui::GestureDetector::Config const&, ui::GestureDetector::GestureListener*, ui::GestureDetector::DoubleTapListener*) ui/events/gesture_detection/gesture_detector.cc:191 #5 0x1431ddf in GestureListenerImpl ui/events/gesture_detection/gesture_provider.cc:296 #6 0x1431ddf in ui::GestureProvider::InitGestureDetectors(ui::GestureProvider::Config const&) ui/events/gesture_detection/gesture_provider.cc:629 #7 0x142ebdd in ui::FilteredGestureProvider::FilteredGestureProvider(ui::GestureProvider::Config const&, ui::GestureProviderClient*) ui/events/gesture_detection/filtered_gesture_provider.cc:19 #8 0x1410cd3 in ui::GestureProviderAura::GestureProviderAura(ui::GestureProviderAuraClient*) ui/events/gestures/gesture_provider_aura.cc:19 #9 0x9e9bcd in ui::TouchExplorationController::TouchExplorationController(aura::Window*) ui/chromeos/touch_exploration_controller.cc:33 #10 0x663c47 in ui::TouchExplorationTest::SwitchTouchExplorationMode(bool) ui/chromeos/touch_exploration_controller_unittest.cc:214 #11 0x674532 in ui::TouchExplorationTest_DoubleTap_Test::TestBody() ui/chromeos/touch_exploration_controller_unittest.cc:563 #12 0x7babc8 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #13 0x7babc8 in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #14 0x7bcd08 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #15 0x7bda46 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #16 0x7d072a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #17 0x7cfd70 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #18 0x7cfd70 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #19 0x7770b4 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #20 0x7770b4 in base::TestSuite::Run() base/test/test_suite.cc:227 #21 0x76e0c1 in Run base/callback.h:401 #22 0x76e0c1 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498 #23 0x76da5c in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:553 #24 0x59cfaa in main ui/base/test/run_all_unittests.cc:105 #25 0x7fd0195b276c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > Added wrapper test class for touch_exploration_controller. > Wrapper class is currently located in the unittest file and is a friend of touch_exploration_controller. > > BUG=377040 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283741 [email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=377040 Review URL: https://codereview.chromium.org/404473006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283811 0039d316-1c4b-4281-b951-d872f2087c98

…://codereview.chromium.org/397233002/) Reason for revert: Broke 'Chromium Linux on Linux Clang (dbg)': http://build.chromium.org/p/chromium.linux/builders/Linux%20Clang%20%28dbg%29/builds/62289 AutofillDialogControllerTest.BillingVsShippingStreetAddress (run #1): [ RUN ] AutofillDialogControllerTest.BillingVsShippingStreetAddress Xlib: extension "RANDR" missing on display ":9". /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/debug/safe_iterator.h:289: error: attempt to advance a past-the-end iterator 1 steps, which falls outside its valid range. Objects involved in the operation: iterator @ 0x0x7fffd4a50d58 { state = past-the-end; references sequence @ 0x0x7fffd4a50d58 } Received signal 6 #0 0x7f716d77ecee base::debug::StackTrace::StackTrace() #1 0x7f716d77e827 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f7168451cb0 \u003Cunknown> #3 0x7f71648cf425 gsignal #4 0x7f71648d2b8b abort #5 0x7f7164ed25ad __gnu_debug::_Error_formatter::_M_error() #6 0x0000026271ce __gnu_debug::_Safe_iterator\u003C>::operator+=() #7 0x0000026270f5 __gnu_debug::_Safe_iterator\u003C>::operator+() #8 0x000005506f39 i18n::addressinput::(anonymous namespace)::CombineLinesForLanguage() #9 0x00000550703a i18n::addressinput::GetStreetAddressLinesAsSingleLine() #10 0x000005548289 autofill::(anonymous namespace)::FillStreetAddress() #11 0x000005547b91 autofill::AutofillField::FillFormField() #12 0x0000055907cd autofill::FormStructure::FillFields() #13 0x000004972335 autofill::AutofillDialogControllerImpl::Show() #14 0x000001ec0f2a autofill::(anonymous namespace)::AutofillDialogControllerTest::SetUpControllerWithFormData() #15 0x000001ece5c8 autofill::AutofillDialogControllerTest_BillingVsShippingStreetAddress_Test::TestBody() #16 0x0000039fcc63 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>() #17 0x0000039e9f9e testing::internal::HandleExceptionsInMethodIfSupported\u003C>() #18 0x0000039e0e05 testing::Test::Run() #19 0x0000039e151b testing::TestInfo::Run() #20 0x0000039e1b0a testing::TestCase::Run() #21 0x0000039e6118 testing::internal::UnitTestImpl::RunAllTests() #22 0x0000039f5973 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>() #23 0x0000039ebb0e testing::internal::HandleExceptionsInMethodIfSupported\u003C>() #24 0x0000039e5da4 testing::UnitTest::Run() #25 0x000005b72b61 RUN_ALL_TESTS() #26 0x000005b71be7 base::TestSuite::Run() #27 0x000005b8455d content::UnitTestTestSuite::Run() #28 0x000003aa40d2 base::internal::RunnableAdapter\u003C>::Run() #29 0x000003aa403c base::internal::InvokeHelper\u003C>::MakeItSo() #30 0x000003aa3fea base::internal::Invoker\u003C>::Run() #31 0x000002a29e9e base::Callback\u003C>::Run() #32 0x000005b6b830 base::(anonymous namespace)::LaunchUnitTestsInternal() #33 0x000005b6b527 base::LaunchUnitTests() #34 0x000003aa3db5 main #35 0x7f71648ba76d __libc_start_main #36 0x000000715159 \u003Cunknown> r8: 00007f715f665980 r9: 00007fffd4a507d8 r10: 0000000000000008 r11: 0000000000000206 r12: 00007fffd4a50aa0 r13: 0000000000000001 r14: 0000000000000001 r15: 0000000000000000 di: 00000000000016b2 si: 00000000000016b2 bp: 0000000000000002 bx: 00007fffd4a50a30 dx: 0000000000000006 ax: 0000000000000000 cx: ffffffffffffffff sp: 00007fffd4a50828 ip: 00007f71648cf425 efl: 0000000000000206 cgf: 0000000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 Original issue's description: > Use language-specific street address line separators > > Fill street address into a single-line text input field with separators > that depend on the language code of the profile. > > TEST=components_unittests:AutofillFieldTest.FillStreetAddress* > BUG=270261 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284335 [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=270261 Review URL: https://codereview.chromium.org/401103004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284340 0039d316-1c4b-4281-b951-d872f2087c98

Reverting as broke chrome and chromeos dbg builders: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32615/steps/browser_tests/logs/SuccessfulLoadUMA [ RUN ] NaClBrowserTestPnacl.SuccessfulLoadUMA Xlib: extension "RANDR" missing on display ":9". Xlib: extension "RANDR" missing on display ":9". [18889:18889:0722/130648:WARNING:password_store_factory.cc(215)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options. HTTP server started on http://127.0.0.1:56115... sending server_data: {"host": "127.0.0.1", "port": 56115} (36 bytes) [9:10:0722/130650:ERROR:pnacl_translation_resource_host.cc(135)] Got invalid platformfilefortransit /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/debug/vector:461: error: attempt to insert into container with an iterator from a different container. Objects involved in the operation: sequence "this" @ 0x0x392ba6c93260 { } iterator "__position" @ 0x0x7fff9ff24e20 { state = past-the-end; references sequence @ 0x0x7fff9ff24e20 } [18889:18938:0722/130651:WARNING:raw_channel_posix.cc(214)] recvmsg: Connection reset by peer BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x7fe4bf491cee base::debug::StackTrace::StackTrace() #1 0x000004af93fa content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7fe4b68074a0 \u003Cunknown> #3 0x7fe4b68b9a43 __poll #4 0x7fe4b76faff6 \u003Cunknown> #5 0x7fe4b76fb124 g_main_context_iteration #6 0x7fe4bf44ff75 base::MessagePumpGlib::Run() #7 0x7fe4bf54b1f0 base::MessageLoop::RunHandler() #8 0x7fe4bf5b18e2 base::RunLoop::Run() #9 0x000004b63969 content::RunThisRunLoop() #10 0x000004b638fa content::RunMessageLoop() #11 0x000004b0ea15 content::JavascriptTestObserver::Run() #12 0x000001312927 NaClBrowserTestBase::RunJavascriptTest() #13 0x000001312a48 NaClBrowserTestBase::RunLoadTest() #14 0x00000130f514 (anonymous namespace)::NaClBrowserTestPnacl_SuccessfulLoadUMA_Test::RunTestOnMai ... > Pepper: Delete FileDownloader in trusted plugin. > > This simplifies PnaclCoordinator considerably and reduces the total > amount of code in the trusted plugin. > > BUG=239656 > > Review URL: https://codereview.chromium.org/393693004 [email protected] Review URL: https://codereview.chromium.org/406323003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284791 0039d316-1c4b-4281-b951-d872f2087c98

BUG=390624 TEST=Load the sample manifest from the bug, comment #9. It should fail to load. Review URL: https://codereview.chromium.org/416263002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285492 0039d316-1c4b-4281-b951-d872f2087c98

…um.org/420603011/) Reason for revert: Appears to have broken Linux Chromium OS ASan LSan Tests (3) (stats): http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29 athena_unittests failed 13 Basic Accelerators AppSelection BasicTransition VirtualKeyboardTransition Basic CreateContainer GrabAndMouseCapture GrabInputContainer GrabShouldNotBlockVirtualKeyboard NonActivatableContainer Zorder Empty [ RUN ] ActivityManagerTest.Basic ================================================================= ==8808==ERROR: AddressSanitizer: heap-use-after-free on address 0x60200000ad70 at pc 0x00000054eebe bp 0x7fff975aaa70 sp 0x7fff975aaa68 READ of size 8 at 0x60200000ad70 thread T0 #0 0x54eebd in __find<__gnu_cxx::__normal_iterator<athena::WindowManagerObserver **, std::vector<athena::WindowManagerObserver *, std::allocator<athena::WindowManagerObserver *> > >, athena::WindowManagerObserver *> /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_algo.h:190:8 #1 0x54eebd in find<__gnu_cxx::__normal_iterator<athena::WindowManagerObserver **, std::vector<athena::WindowManagerObserver *, std::allocator<athena::WindowManagerObserver *> > >, athena::WindowManagerObserver *> /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_algo.h:4402 #2 0x54eebd in ObserverListBase<athena::WindowManagerObserver>::RemoveObserver(athena::WindowManagerObserver*) base/observer_list.h:168 #3 0x560f79 in ~SplitViewController athena/wm/split_view_controller.cc:63:3 #4 0x560f79 in athena::SplitViewController::~SplitViewController() athena/wm/split_view_controller.cc:62 #5 0x54d340 in operator() base/memory/scoped_ptr.h:137:5 #6 0x54d340 in ~scoped_ptr_impl base/memory/scoped_ptr.h:220 #7 0x54d340 in ~scoped_ptr base/memory/scoped_ptr.h:432 #8 0x54d340 in athena::(anonymous namespace)::WindowManagerImpl::~WindowManagerImpl() athena/wm/window_manager_impl.cc:124 #9 0x54d57d in athena::(anonymous namespace)::WindowManagerImpl::~WindowManagerImpl() athena/wm/window_manager_impl.cc:116:41 #10 0x567127 in athena::ShutdownAthena() athena/main/athena_launcher.cc:86:3 #11 0x5657af in athena::test::AthenaTestHelper::TearDown() athena/test/athena_test_helper.cc:98:3 #12 0x5645b6 in athena::test::AthenaTestBase::TearDown() athena/test/athena_test_base.cc:51:3 #13 0x4fc938 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #14 0x4fd676 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #15 0x5138f5 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #16 0x512ee6 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #17 0x512ee6 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #18 0x1602b74 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #19 0x1602b74 in base::TestSuite::Run() base/test/test_suite.cc:227 #20 0x15fa231 in Run base/callback.h:401:12 #21 0x15fa231 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498 #22 0x15faf7e in base::LaunchUnitTestsSerially(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:564:10 #23 0x4d74ca in main athena/test/athena_unittests.cc:51:10 #24 0x7f9020d2d76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 #25 0x4d726c in _start (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__3_/build/src/out/Release/athena_unittests+0x4d726c) Please follow instructions on how to setup ASan on your workstation here: http://www.chromium.org/developers/testing/addresssanitizer LSan may also be of use: http://www.chromium.org/developers/testing/leaksanitizer You may also want run your patch through the linux_lsan try bot. Original issue's description: > Split Screen mode implementation. > > Implements Split Screen mode and window cycling behavior. > > BUG=383421 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288593 TBR=oshima,sadrul,mfomitchev,mukai NOTRY=true Review URL: https://codereview.chromium.org/451363002 Cr-Commit-Position: refs/heads/master@{#288607} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288607 0039d316-1c4b-4281-b951-d872f2087c98

…um.org/420603011/) Reason for revert: Appears to have broken Linux Chromium OS ASan LSan Tests (3) (stats): http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29 athena_unittests failed 13 Basic Accelerators AppSelection BasicTransition VirtualKeyboardTransition Basic CreateContainer GrabAndMouseCapture GrabInputContainer GrabShouldNotBlockVirtualKeyboard NonActivatableContainer Zorder Empty [ RUN ] ActivityManagerTest.Basic ================================================================= ==8808==ERROR: AddressSanitizer: heap-use-after-free on address 0x60200000ad70 at pc 0x00000054eebe bp 0x7fff975aaa70 sp 0x7fff975aaa68 READ of size 8 at 0x60200000ad70 thread T0 #0 0x54eebd in __find<__gnu_cxx::__normal_iterator<athena::WindowManagerObserver **, std::vector<athena::WindowManagerObserver *, std::allocator<athena::WindowManagerObserver *> > >, athena::WindowManagerObserver *> /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_algo.h:190:8 #1 0x54eebd in find<__gnu_cxx::__normal_iterator<athena::WindowManagerObserver **, std::vector<athena::WindowManagerObserver *, std::allocator<athena::WindowManagerObserver *> > >, athena::WindowManagerObserver *> /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_algo.h:4402 #2 0x54eebd in ObserverListBase<athena::WindowManagerObserver>::RemoveObserver(athena::WindowManagerObserver*) base/observer_list.h:168 #3 0x560f79 in ~SplitViewController athena/wm/split_view_controller.cc:63:3 #4 0x560f79 in athena::SplitViewController::~SplitViewController() athena/wm/split_view_controller.cc:62 #5 0x54d340 in operator() base/memory/scoped_ptr.h:137:5 #6 0x54d340 in ~scoped_ptr_impl base/memory/scoped_ptr.h:220 #7 0x54d340 in ~scoped_ptr base/memory/scoped_ptr.h:432 #8 0x54d340 in athena::(anonymous namespace)::WindowManagerImpl::~WindowManagerImpl() athena/wm/window_manager_impl.cc:124 #9 0x54d57d in athena::(anonymous namespace)::WindowManagerImpl::~WindowManagerImpl() athena/wm/window_manager_impl.cc:116:41 #10 0x567127 in athena::ShutdownAthena() athena/main/athena_launcher.cc:86:3 #11 0x5657af in athena::test::AthenaTestHelper::TearDown() athena/test/athena_test_helper.cc:98:3 #12 0x5645b6 in athena::test::AthenaTestBase::TearDown() athena/test/athena_test_base.cc:51:3 #13 0x4fc938 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #14 0x4fd676 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #15 0x5138f5 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #16 0x512ee6 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #17 0x512ee6 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #18 0x1602b74 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #19 0x1602b74 in base::TestSuite::Run() base/test/test_suite.cc:227 #20 0x15fa231 in Run base/callback.h:401:12 #21 0x15fa231 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498 #22 0x15faf7e in base::LaunchUnitTestsSerially(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:564:10 #23 0x4d74ca in main athena/test/athena_unittests.cc:51:10 #24 0x7f9020d2d76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 #25 0x4d726c in _start (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__3_/build/src/out/Release/athena_unittests+0x4d726c) Please follow instructions on how to setup ASan on your workstation here: http://www.chromium.org/developers/testing/addresssanitizer LSan may also be of use: http://www.chromium.org/developers/testing/leaksanitizer You may also want run your patch through the linux_lsan try bot. Original issue's description: > Split Screen mode implementation. > > Implements Split Screen mode and window cycling behavior. > > BUG=383421 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288593 TBR=oshima,sadrul,mfomitchev,mukai NOTRY=true Review URL: https://codereview.chromium.org/451363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288607 0039d316-1c4b-4281-b951-d872f2087c98

…ion sensors. (patchset #12 of https://codereview.chromium.org/431183003/) Reason for revert: Speculative, athena_unittests and ui_unittests started failing in this build:http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/2771 ==6568==ERROR: AddressSanitizer: heap-use-after-free on address 0x60700000ba10 at pc 0x00000167d52a bp 0x7fff95f266f0 sp 0x7fff95f266e8 READ of size 8 at 0x60700000ba10 thread T0 #0 0x167d529 in DeleteInternal base/memory/ref_counted.h:190:44 #1 0x167d529 in Destruct base/memory/ref_counted.h:153 #2 0x167d529 in Release base/memory/ref_counted.h:181 #3 0x167d529 in ~scoped_refptr base/memory/ref_counted.h:289 #4 0x167d529 in ~SystemUIImpl athena/system/system_ui_impl.cc:27 #5 0x167d529 in athena::(anonymous namespace)::SystemUIImpl::~SystemUIImpl() athena/system/system_ui_impl.cc:26 #6 0x167d257 in athena::SystemUI::Shutdown() athena/system/system_ui_impl.cc:49:3 #7 0x577fa6 in athena::ShutdownAthena() athena/main/athena_launcher.cc:92:3 #8 0x57645f in athena::test::AthenaTestHelper::TearDown() athena/test/athena_test_helper.cc:98:3 #9 0x575266 in athena::test::AthenaTestBase::TearDown() athena/test/athena_test_base.cc:53:3 #10 0x505bc8 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #11 0x506906 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #12 0x51cb85 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #13 0x51c176 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #14 0x51c176 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #15 0xac6fb4 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #16 0xac6fb4 in base::TestSuite::Run() base/test/test_suite.cc:227 #17 0xabe39d in Run base/callback.h:401:12 #18 0xabe39d in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498 #19 0xabf0de in base::LaunchUnitTestsSerially(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:564:10 #20 0x4d7bba in main athena/test/athena_unittests.cc:51:10 #21 0x7fd394e3476c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 #22 0x4d795c in _start (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__3_/build/src/out/Release/athena_unittests+0x4d795c) 0x60700000ba10 is located 0 bytes inside of 72-byte region [0x60700000ba10,0x60700000ba58) freed by thread T0 here: #0 0x452fcb in operator delete(void*) (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__3_/build/src/out/Release/athena_unittests+0x452fcb) #1 0x168323d in DeleteInternal base/memory/ref_counted.h:190:44 #2 0x168323d in Destruct base/memory/ref_counted.h:153 #3 0x168323d in Release base/memory/ref_counted.h:181 #4 0x168323d in ~scoped_refptr base/memory/ref_counted.h:289 #5 0x168323d in athena::OrientationController::OrientationController(scoped_refptr\u003Cbase::TaskRunner>) athena/system/orientation_controller.cc:66 #6 0x167cfea in SystemUIImpl athena/system/system_ui_impl.cc:23:61 #7 0x167cfea in athena::SystemUI::Create(scoped_refptr\u003Cbase::TaskRunner>) athena/system/system_ui_impl.cc:42 #8 0x577db0 in athena::StartAthena(aura::Window*, athena::ActivityFactory*, athena::AppModelBuilder*) athena/main/athena_launcher.cc:73:3 #9 0x576159 in athena::test::AthenaTestHelper::SetUp(ui::ContextFactory*) athena/test/athena_test_helper.cc:90:3 #10 0x503eb1 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12 #11 0x503eb1 in testing::Test::Run() testing/gtest/src/gtest.cc:2430 #12 0x505bc8 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #13 0x506906 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #14 0x51cb85 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #15 0x51c176 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #16 0x51c176 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #17 0xac6fb4 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #18 0xac6fb4 in base::TestSuite::Run() base/test/test_suite.cc:227 #19 0xabe39d in Run base/callback.h:401:12 #20 0xabe39d in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498 #21 0xabf0de in base::LaunchUnitTestsSerially(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:564:10 #22 0x4d7bba in main athena/test/athena_unittests.cc:51:10 #23 0x7fd394e3476c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 previously allocated by thread T0 here: #0 0x452a8b in operator new(unsigned long) (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__3_/build/src/out/Release/athena_unittests+0x452a8b) #1 0x167cfb5 in SystemUIImpl athena/system/system_ui_impl.cc:23:61 #2 0x167cfb5 in athena::SystemUI::Create(scoped_refptr\u003Cbase::TaskRunner>) athena/system/system_ui_impl.cc:42 #3 0x577db0 in athena::StartAthena(aura::Window*, athena::ActivityFactory*, athena::AppModelBuilder*) athena/main/athena_launcher.cc:73:3 #4 0x576159 in athena::test::AthenaTestHelper::SetUp(ui::ContextFactory*) athena/test/athena_test_helper.cc:90:3 #5 0x503eb1 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12 #6 0x503eb1 in testing::Test::Run() testing/gtest/src/gtest.cc:2430 #7 0x505bc8 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #8 0x506906 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #9 0x51cb85 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #10 0x51c176 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #11 0x51c176 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #12 0xac6fb4 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #13 0xac6fb4 in base::TestSuite::Run() base/test/test_suite.cc:227 #14 0xabe39d in Run base/callback.h:401:12 #15 0xabe39d in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498 #16 0xabf0de in base::LaunchUnitTestsSerially(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:564:10 #17 0x4d7bba in main athena/test/athena_unittests.cc:51:10 #18 0x7fd394e3476c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 TBR=oshima NOTRY=true NOTREECHECKS=true Original issue's description: > Rotate screen in response to accelerator or device orientation sensors. > > BUG=385295 > TEST=Press Ctrl+Shift+F3, screen rotates. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290007 Review URL: https://codereview.chromium.org/475533008 Cr-Commit-Position: refs/heads/master@{#290089} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290089 0039d316-1c4b-4281-b951-d872f2087c98

[20526:20526:0815/151613:1174431576:FATAL:touch_exploration_controller.cc(763)] Check failed: false. tap timer fired in unrecognized state: CORNER_PASSTHROUGH #0 0x7f485532361e base::debug::StackTrace::StackTrace() #1 0x7f48553ba882 logging::LogMessage::~LogMessage() #2 0x7f485314bcfc ui::TouchExplorationController::OnTapTimerFired() #3 0x7f485314af2b ui::TouchExplorationController::RewriteEvent() #4 0x7f48531c89a6 ui::EventSource::SendEventToProcessor() #5 0x0000005f6bc0 ui::EventSourceTestApi::SendEventToProcessor() #6 0x0000005f396f ui::test::EventGenerator::DoDispatchEvent() #7 0x0000005f1480 ui::test::EventGenerator::Dispatch() #8 0x00000051a1a5 ui::TouchExplorationTest::AssertCornerPassthroughWorking() #9 0x0000005153fb ui::TouchExplorationTest_ActivateLeftCornerPassthrough_Test::TestBody() #10 0x0000005a49f3 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>() #11 0x00000059005e testing::internal::HandleExceptionsInMethodIfSupported\u003C>() #12 0x000000583ed5 testing::Test::Run() #13 0x0000005845db testing::TestInfo::Run() In ActivateLeftCornerPassthrough, ActivateRightCornerPassthrough, and SingleTapLongPress tests. > Modified state flow for touch explore released in touch_exploration_controller. > > Now when performing single tap, the tap timer to begin one finger passthrough is not started. This problem originally arose because touch explore released state and single tap released state are treated similarly in the code, but one finger passthrough should be a state reachable only from single tap released. > > Another state change is that if the user presses in single tap/touch explore released and there is no previous touch exploration location, the user is redirected to the wait state. > > TEST=TouchExplorationTest.SingleTapLongPress > BUG=402544 > > Review URL: https://codereview.chromium.org/465543003 [email protected] Review URL: https://codereview.chromium.org/483443002 Cr-Commit-Position: refs/heads/master@{#290092} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290092 0039d316-1c4b-4281-b951-d872f2087c98

Broke ASan/LSan: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/6376 @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@Direct leak of 136 byte(s) in 1 object(s) allocated from:@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #0 0x4f295b in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__2_/build/src/out/Release/browser_tests+0x4f295b)@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #1 0x4f41e33 in GrGpuGL::onCreateIndexBuffer(unsigned long, bool) third_party/skia/src/gpu/gl/GrGpuGL.cpp:1374:13@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #2 0x4ec41b3 in createIndexBuffer third_party/skia/src/gpu/GrGpu.cpp:159:12@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #3 0x4ec41b3 in GrGpu::getQuadIndexBuffer() const third_party/skia/src/gpu/GrGpu.cpp:273@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #4 0x4ecbad0 in GrInOrderDrawBuffer::onDrawRect(SkRect const&, SkRect const*, SkMatrix const*) third_party/skia/src/gpu/GrInOrderDrawBuffer.cpp:174:34@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #5 0x4e998f8 in drawRect third_party/skia/src/gpu/GrDrawTarget.h:384:9@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #6 0x4e998f8 in drawSimpleRect third_party/skia/src/gpu/GrDrawTarget.h:391@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #7 0x4e998f8 in GrContext::drawRect(GrPaint const&, SkRect const&, GrStrokeInfo const*) third_party/skia/src/gpu/GrContext.cpp:904@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #8 0xf895e0c in SkAlphaThresholdFilterImpl::asNewEffect(GrEffect**, GrTexture*, SkMatrix const&, SkIRect const&) const third_party/skia/src/effects/SkAlphaThresholdFilter.cpp:287:17@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #9 0x4d531c9 in SkImageFilter::filterImageGPU(SkImageFilter::Proxy*, SkBitmap const&, SkImageFilter::Context const&, SkBitmap*, SkIPoint*) const third_party/skia/src/core/SkImageFilter.cpp:272:5@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #10 0xf8b4aad in filter_texture(SkBaseDevice*, GrContext*, GrTexture*, SkImageFilter const*, int, int, SkImageFilter::Context const&, SkBitmap*, SkIPoint*) third_party/skia/src/gpu/SkGpuDevice.cpp:1398:16@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #11 0xf8b3d42 in SkGpuDevice::drawSprite(SkDraw const&, SkBitmap const&, int, int, SkPaint const&) third_party/skia/src/gpu/SkGpuDevice.cpp:1434:13@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #12 0x4d16942 in SkCanvas::drawSprite(SkBitmap const&, int, int, SkPaint const*) third_party/skia/src/core/SkCanvas.cpp:1194:13@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #13 0xe2828c3 in cc::ApplyImageFilter(scoped_ptr\u003Ccc::GLRenderer::ScopedUseGrContext, base::DefaultDeleter\u003Ccc::GLRenderer::ScopedUseGrContext> >, cc::ResourceProvider*, gfx::Point const&, gfx::Vector2dF const&, SkImageFilter*, cc::ScopedResource*) cc/output/gl_renderer.cc:722:3@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #14 0xe275474 in cc::GLRenderer::DrawRenderPassQuad(cc::DirectRenderer::DrawingFrame*, cc::RenderPassDrawQuad const*) cc/output/gl_renderer.cc:1051:13@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #15 0xe4598a4 in cc::DirectRenderer::DrawRenderPass(cc::DirectRenderer::DrawingFrame*, cc::RenderPass const*) cc/output/direct_renderer.cc:385:7@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #16 0xe458480 in cc::DirectRenderer::DrawFrame(cc::ScopedPtrVector\u003Ccc::RenderPass>*, float, gfx::Rect const&, gfx::Rect const&, bool) cc/output/direct_renderer.cc:232:5@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #17 0xe3bd5cc in cc::LayerTreeHostImpl::DrawLayers(cc::LayerTreeHostImpl::FrameData*, base::TimeTicks) cc/trees/layer_tree_host_impl.cc:1578:5@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #18 0xe3fb78e in cc::SingleThreadProxy::DoComposite(base::TimeTicks, cc::LayerTreeHostImpl::FrameData*) cc/trees/single_thread_proxy.cc:438:7@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #19 0xe3fade5 in cc::SingleThreadProxy::CompositeImmediately(base::TimeTicks) cc/trees/single_thread_proxy.cc:356:7@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #20 0x651589b in ui::Compositor::Draw() ui/compositor/compositor.cc:234:5@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #21 0x345c43f in Run base/callback.h:401:12@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #22 0x345c43f in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #23 0x339b64c in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:435:3@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #24 0x339c710 in DeferOrRunPendingTask base/message_loop/message_loop.cc:445:5@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #25 0x339c710 in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:552@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #26 0x3445422 in HandleDispatch base/message_loop/message_pump_glib.cc:267:7@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #27 0x3445422 in base::(anonymous namespace)::WorkSourceDispatch(_GSource*, int (*)(void*), void*) base/message_loop/message_pump_glib.cc:109@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #28 0x7f5f9395dd12 in g_main_dispatch /build/buildd/glib2.0-2.32.4/./glib/gmain.c:2539@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #29 0x7f5f9395dd12 in g_main_context_dispatch /build/buildd/glib2.0-2.32.4/./glib/gmain.c:3075@@@ > Skia roll de21804:94ce9ac > > https://skia.googlesource.com/skia/+log/de218041b99e8f9af0e80b34452b0e8d7f770765..94ce9ac8624dbb45656b8f5c992fad9c9ff3ee5f > > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel > [email protected] > BUG= > > Review URL: https://codereview.chromium.org/485173003 [email protected],[email protected] Review URL: https://codereview.chromium.org/485523003 Cr-Commit-Position: refs/heads/master@{#290648} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290648 0039d316-1c4b-4281-b951-d872f2087c98

…r_tests compiling on MacViews (patchset #7 of https://codereview.chromium.org/486063002/) Reason for revert: browser_test fails in Linux ASAN/LSAN test. WebDialogBrowserTest.SizeWindow (run #1): [ RUN ] WebDialogBrowserTest.SizeWindow [30383:30383:0820/232516:ERROR:browser_main_loop.cc(162)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on. Xlib: extension "RANDR" missing on display ":9". Xlib: extension "RANDR" missing on display ":9". [30383:30383:0820/232516:WARNING:password_store_factory.cc(215)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options. [30473:30473:0820/232516:ERROR:renderer_main.cc(204)] Running without renderer sandbox [30496:30496:0820/232516:ERROR:renderer_main.cc(204)] Running without renderer sandbox ================================================================= ==30383==ERROR: LeakSanitizer: detected memory leaks Direct leak of 128 byte(s) in 1 object(s) allocated from: #0 0x4f2bbb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x4f2bbb) #1 0x1dace96 in WebDialogBrowserTest_SizeWindow_Test::RunTestOnMainThread() chrome/browser/ui/views/web_dialog_view_browsertest.cc:95:3 #2 0x32aaae3 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:434:5 #3 0x2d6de03 in Run base/callback.h:401:12 #4 0x2d6de03 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1555 #5 0x2d6a146 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:980:18 #6 0x59d80b7 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:736:5 #7 0x5d3ac48 in Run base/callback.h:401:12 #8 0x5d3ac48 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45 #9 0x59d40a0 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:636:3 #10 0x5f3839d in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:106:5 #11 0xf90f1a5 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:22:19 #12 0xf8416c0 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:764:12 #13 0xf83db5f in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:15 #14 0xd6b57e1 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:257:3 #15 0x32a773b in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:217:3 #16 0x3de9f81 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12 #17 0x3de9f81 in testing::Test::Run() testing/gtest/src/gtest.cc:2430 #18 0x3dec559 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #19 0x3ded5b6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #20 0x3e03055 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #21 0x3e02664 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #22 0x3e02664 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #23 0x348e02f in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #24 0x348e02f in base::TestSuite::Run() base/test/test_suite.cc:227 #25 0x20fb8cd in ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/browser_tests_main.cc:14:12 #26 0xd737de7 in content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) content/public/test/test_launcher.cc:469:12 #27 0x32a4b8b in LaunchChromeTests(int, ChromeTestSuiteRunner*, int, char**) chrome/test/base/chrome_test_launcher.cc:124:10 #28 0x20fb7b8 in main chrome/test/base/browser_tests_main.cc:21:10 #29 0x7feeddc6676c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 ----------------------------------------------------- Suppressions used: count bytes template 1767 75328 libfontconfig ----------------------------------------------------- SUMMARY: AddressSanitizer: 128 byte(s) leaked in 1 allocation(s). [0820/232518:ERROR:nacl_helper_linux.cc(282)] NaCl helper process running without a sandbox! Most likely you need to configure your SUID sandbox correctly WebDialogBrowserTest.SizeWindow (run #2): [ RUN ] WebDialogBrowserTest.SizeWindow [16767:16767:0820/232720:ERROR:browser_main_loop.cc(162)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on. Xlib: extension "RANDR" missing on display ":9". Xlib: extension "RANDR" missing on display ":9". [16767:16767:0820/232720:WARNING:password_store_factory.cc(215)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options. [16871:16871:0820/232720:ERROR:renderer_main.cc(204)] Running without renderer sandbox [16911:16911:0820/232720:ERROR:renderer_main.cc(204)] Running without renderer sandbox ================================================================= ==16767==ERROR: LeakSanitizer: detected memory leaks Direct leak of 128 byte(s) in 1 object(s) allocated from: #0 0x4f2bbb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x4f2bbb) #1 0x1dace96 in WebDialogBrowserTest_SizeWindow_Test::RunTestOnMainThread() chrome/browser/ui/views/web_dialog_view_browsertest.cc:95:3 #2 0x32aaae3 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:434:5 #3 0x2d6de03 in Run base/callback.h:401:12 #4 0x2d6de03 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1555 #5 0x2d6a146 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:980:18 #6 0x59d80b7 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:736:5 #7 0x5d3ac48 in Run base/callback.h:401:12 #8 0x5d3ac48 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45 #9 0x59d40a0 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:636:3 #10 0x5f3839d in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:106:5 #11 0xf90f1a5 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:22:19 #12 0xf8416c0 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:764:12 #13 0xf83db5f in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:15 #14 0xd6b57e1 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:257:3 #15 0x32a773b in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:217:3 #16 0x3de9f81 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12 #17 0x3de9f81 in testing::Test::Run() testing/gtest/src/gtest.cc:2430 #18 0x3dec559 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #19 0x3ded5b6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #20 0x3e03055 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #21 0x3e02664 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #22 0x3e02664 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #23 0x348e02f in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #24 0x348e02f in base::TestSuite::Run() base/test/test_suite.cc:227 #25 0x20fb8cd in ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/browser_tests_main.cc:14:12 #26 0xd737de7 in content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) content/public/test/test_launcher.cc:469:12 #27 0x32a4b8b in LaunchChromeTests(int, ChromeTestSuiteRunner*, int, char**) chrome/test/base/chrome_test_launcher.cc:124:10 #28 0x20fb7b8 in main chrome/test/base/browser_tests_main.cc:21:10 #29 0x7fb13f28476c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 ----------------------------------------------------- Suppressions used: count bytes template 1767 75328 libfontconfig ----------------------------------------------------- SUMMARY: AddressSanitizer: 128 byte(s) leaked in 1 allocation(s). [0820/232722:ERROR:nacl_helper_linux.cc(282)] NaCl helper process running without a sandbox! Most likely you need to configure your SUID sandbox correctly WebDialogBrowserTest.SizeWindow (run #3): [ RUN ] WebDialogBrowserTest.SizeWindow [16994:16994:0820/232723:ERROR:browser_main_loop.cc(162)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on. Xlib: extension "RANDR" missing on display ":9". Xlib: extension "RANDR" missing on display ":9". [16994:16994:0820/232724:WARNING:password_store_factory.cc(215)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options. [17026:17026:0820/232724:ERROR:renderer_main.cc(204)] Running without renderer sandbox [17038:17038:0820/232724:ERROR:renderer_main.cc(204)] Running without renderer sandbox ================================================================= ==16994==ERROR: LeakSanitizer: detected memory leaks Direct leak of 128 byte(s) in 1 object(s) allocated from: #0 0x4f2bbb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x4f2bbb) #1 0x1dace96 in WebDialogBrowserTest_SizeWindow_Test::RunTestOnMainThread() chrome/browser/ui/views/web_dialog_view_browsertest.cc:95:3 #2 0x32aaae3 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:434:5 #3 0x2d6de03 in Run base/callback.h:401:12 #4 0x2d6de03 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1555 #5 0x2d6a146 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:980:18 #6 0x59d80b7 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:736:5 #7 0x5d3ac48 in Run base/callback.h:401:12 #8 0x5d3ac48 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45 #9 0x59d40a0 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:636:3 #10 0x5f3839d in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:106:5 #11 0xf90f1a5 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:22:19 #12 0xf8416c0 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:764:12 #13 0xf83db5f in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:15 #14 0xd6b57e1 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:257:3 #15 0x32a773b in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:217:3 #16 0x3de9f81 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12 #17 0x3de9f81 in testing::Test::Run() testing/gtest/src/gtest.cc:2430 #18 0x3dec559 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #19 0x3ded5b6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #20 0x3e03055 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #21 0x3e02664 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #22 0x3e02664 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #23 0x348e02f in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #24 0x348e02f in base::TestSuite::Run() base/test/test_suite.cc:227 #25 0x20fb8cd in ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/browser_tests_main.cc:14:12 #26 0xd737de7 in content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) content/public/test/test_launcher.cc:469:12 #27 0x32a4b8b in LaunchChromeTests(int, ChromeTestSuiteRunner*, int, char**) chrome/test/base/chrome_test_launcher.cc:124:10 #28 0x20fb7b8 in main chrome/test/base/browser_tests_main.cc:21:10 #29 0x7f0688ff376c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 ----------------------------------------------------- Suppressions used: count bytes template 1767 75328 libfontconfig ----------------------------------------------------- SUMMARY: AddressSanitizer: 128 byte(s) leaked in 1 allocation(s). [0820/232725:ERROR:nacl_helper_linux.cc(282)] NaCl helper process running without a sandbox! Most likely you need to configure your SUID sandbox correctly WebDialogBrowserTest.SizeWindow (run #4): [ RUN ] WebDialogBrowserTest.SizeWindow [17073:17073:0820/232726:ERROR:browser_main_loop.cc(162)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on. Xlib: extension "RANDR" missing on display ":9". Xlib: extension "RANDR" missing on display ":9". [17073:17073:0820/232726:WARNING:password_store_factory.cc(215)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options. [17105:17105:0820/232726:ERROR:renderer_main.cc(204)] Running without renderer sandbox [17116:17116:0820/232726:ERROR:renderer_main.cc(204)] Running without renderer sandbox ================================================================= ==17073==ERROR: LeakSanitizer: detected memory leaks Direct leak of 128 byte(s) in 1 object(s) allocated from: #0 0x4f2bbb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x4f2bbb) #1 0x1dace96 in WebDialogBrowserTest_SizeWindow_Test::RunTestOnMainThread() chrome/browser/ui/views/web_dialog_view_browsertest.cc:95:3 #2 0x32aaae3 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:434:5 #3 0x2d6de03 in Run base/callback.h:401:12 #4 0x2d6de03 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1555 #5 0x2d6a146 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:980:18 #6 0x59d80b7 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:736:5 #7 0x5d3ac48 in Run base/callback.h:401:12 #8 0x5d3ac48 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45 #9 0x59d40a0 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:636:3 #10 0x5f3839d in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:106:5 #11 0xf90f1a5 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:22:19 #12 0xf8416c0 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:764:12 #13 0xf83db5f in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:15 #14 0xd6b57e1 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:257:3 #15 0x32a773b in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:217:3 #16 0x3de9f81 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12 #17 0x3de9f81 in testing::Test::Run() testing/gtest/src/gtest.cc:2430 #18 0x3dec559 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #19 0x3ded5b6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #20 0x3e03055 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #21 0x3e02664 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #22 0x3e02664 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #23 0x348e02f in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #24 0x348e02f in base::TestSuite::Run() base/test/test_suite.cc:227 #25 0x20fb8cd in ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/browser_tests_main.cc:14:12 #26 0xd737de7 in content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) content/public/test/test_launcher.cc:469:12 #27 0x32a4b8b in LaunchChromeTests(int, ChromeTestSuiteRunner*, int, char**) chrome/test/base/chrome_test_launcher.cc:124:10 #28 0x20fb7b8 in main chrome/test/base/browser_tests_main.cc:21:10 #29 0x7f5f8410c76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 ----------------------------------------------------- Suppressions used: count bytes template 1767 75328 libfontconfig ----------------------------------------------------- SUMMARY: AddressSanitizer: 128 byte(s) leaked in 1 allocation(s). [0820/232728:ERROR:nacl_helper_linux.cc(282)] NaCl helper process running without a sandbox! Most likely you need to configure your SUID sandbox correctly Original issue's description: > MacViews: Fix WebDialogBrowserTest.SizeWindow to get browser_tests compiling on MacViews > > gyp changes are made to filter out toolkit-views browser_tests that > aren't yet compiled in to a toolkit-views Chrome binary on Mac. > > One, WebDialogBrowserTest.SizeWindow, was a disabled test (disabled for > 4 years :o). It was preventing browser_tests compiling on MacViews > because it was passing a gfx::NativeWindow to CreateWindowWithParent, > which takes a view. > > The parent isn't important for the test - it's just adding widget > context. This CL changes the parent to be web_contents->GetNativeView() > instead so the test compiles. > > To ensure nothing breaks, the test needs to be enabled. According to the > comment, the reasons for it being disabled on Windows still seem > relevant. However, on Linux the test was just timing out due to a quirk > of the test. So the quirk is fixed, and WebDialogBrowserTest.SizeWindow > is enabled on Linux Aura. > > The test is also enabled on Mac, but currently fails because > NativeViewHost isn't implemented yet. That's coming, and leaving the > test enabled will ensure we check it. > > With this change browser_tests compiles and links on toolkit-views Mac. > > BUG=404979, 399191, 52602 > TEST=browser_tests > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290998 [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=404979, 399191, 52602 Review URL: https://codereview.chromium.org/490123002 Cr-Commit-Position: refs/heads/master@{#291014} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291014 0039d316-1c4b-4281-b951-d872f2087c98

…hset #9 id:160001 of https://codereview.chromium.org/414503004/) Reason for revert: clang Original issue's description: > android: Use hw acceleration in android_webview_shell > > This creates a (GL)SurfaceView overlay on top of the shell > container view which runs its own thread for rendering. > It calls into the native draw functor through a small > dynamic library (drawgl.so). > > NOTRY=True > > Committed: https://chromium.googlesource.com/chromium/src/+/09acbf59e7e8f1de574498ee5ba8eae0b0775438 [email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/524933002 Cr-Commit-Position: refs/heads/master@{#292728}

…_background (patchset #9 of https://codereview.chromium.org/485743002/) Reason for revert: I believe the flakiness may have been fixed by https://codereview.chromium.org/520683002 BUG= Review URL: https://codereview.chromium.org/531733004 Cr-Commit-Position: refs/heads/master@{#292950}

…hset #5 id:100001 of https://codereview.chromium.org/516293007/) Reason for revert: Chrome OS build with DCHECKs enabled fails on start. This CL breaks assumption, that GAIA extension can be loaded without performing IO-operations. Log and stack trace: [16275:16275:0903/161435:WARNING:renderer_freezer.cc(55)] Cgroup freezer does not exist or is not writable. Processes will not be frozen during suspend. [16275:16275:0903/161435:WARNING:configuration_policy_pref_store.cc(30)] Policy RemoteAccessClientFirewallTraversal: This policy has been deprecated. [16275:16275:0903/161437:FATAL:thread_restrictions.cc(38)] Function marked as IO-only was called from a thread that disallows IO! If this thread really should be allowed to make IO calls, adjust the call to base::ThreadRestrictions::SetIOAllowed() in this thread's startup. #0 0x7fe3122e555e base::debug::StackTrace::StackTrace() #1 0x7fe31237c462 logging::LogMessage::~LogMessage() #2 0x7fe3124824af base::ThreadRestrictions::AssertIOAllowed() #3 0x7fe3123630a1 base::PathExists() #4 0x7fe321cfd5f3 extensions::(anonymous namespace)::CollectPlatformSpecificResourceArchs() #5 0x7fe321cfad22 extensions::Extension::InitFromValue() #6 0x7fe321cfa490 extensions::Extension::Create() #7 0x7fe321cfa114 extensions::Extension::Create() #8 0x7fe3233ebe1b extensions::ComponentLoader::Load() #9 0x7fe3233ec3cf extensions::ComponentLoader::Add() #10 0x7fe3233ec32a extensions::ComponentLoader::Add() #11 0x7fe3233ec2b0 extensions::ComponentLoader::Add() #12 0x7fe32437505f (anonymous namespace)::LoadGaiaAuthExtension() #13 0x7fe324374d5e extensions::GaiaAuthExtensionLoader::LoadIfNeeded() #14 0x7fe324237f7e ScopedGaiaAuthExtension::ScopedGaiaAuthExtension() #15 0x7fe322f68bb2 chromeos::WebUILoginView::Init() #16 0x7fe322f556ef chromeos::LoginDisplayHostImpl::InitLoginWindowAndView() #17 0x7fe322f52640 chromeos::LoginDisplayHostImpl::LoadURL() #18 0x7fe322f5226a chromeos::LoginDisplayHostImpl::StartWizard() #19 0x7fe322f54acd chromeos::LoginDisplayHostImpl::StartPostponedWebUI() #20 0x7fe322f541f8 chromeos::LoginDisplayHostImpl::Observe() #21 0x7fe322f54bfd chromeos::LoginDisplayHostImpl::Observe() #22 0x7fe31b222377 content::NotificationServiceImpl::Notify() #23 0x7fe322d51a24 chromeos::(anonymous namespace)::UserWallpaperDelegate::OnWallpaperAnimationFinished() #24 0x7fe31188692f ash::RootWindowController::OnWallpaperAnimationFinished() #25 0x7fe3117c633a ash::(anonymous namespace)::ShowWallpaperAnimationObserver::OnImplicitAnimationsCompleted() #26 0x7fe311f72d30 ui::ImplicitAnimationObserver::CheckCompleted() #27 0x7fe311f72cd5 ui::ImplicitAnimationObserver::SetActive() #28 0x7fe311f965d5 ui::ScopedLayerAnimationSettings::~ScopedLayerAnimationSettings() #29 0x7fe3117c5ec7 ash::DesktopBackgroundWidgetController::StartAnimating() #30 0x7fe3117bbb0c ash::DesktopBackgroundController::InstallDesktopController() #31 0x7fe3117bbc03 ash::DesktopBackgroundController::InstallDesktopControllerForAllWindows() #32 0x7fe3117bb3cc ash::DesktopBackgroundController::SetDesktopBackgroundImageMode() #33 0x7fe3117bb096 ash::DesktopBackgroundController::SetWallpaperImage() #34 0x7fe322f9a6b9 chromeos::WallpaperManager::DoSetDefaultWallpaper() #35 0x7fe322f99b73 chromeos::WallpaperManager::PendingWallpaper::ProcessRequest() #36 0x7fe322fbac72 base::internal::RunnableAdapter<>::Run() #37 0x7fe322fbabe9 base::internal::InvokeHelper<>::MakeItSo() #38 0x7fe322fbaba5 base::internal::Invoker<>::Run() #39 0x7fe3122cc9ce base::Callback<>::Run() #40 0x7fe312488f86 base::Timer::RunScheduledTask() #41 0x7fe3124890bc base::BaseTimerTaskInternal::Run() #42 0x7fe312489382 base::internal::RunnableAdapter<>::Run() #43 0x7fe3124892ec base::internal::InvokeHelper<>::MakeItSo() #44 0x7fe312489295 base::internal::Invoker<>::Run() #45 0x7fe3122cc9ce base::Callback<>::Run() #46 0x7fe3122eb9b3 base::debug::TaskAnnotator::RunTask() #47 0x7fe3123a1c57 base::MessageLoop::RunTask() #48 0x7fe3123a1d9b base::MessageLoop::DeferOrRunPendingTask() #49 0x7fe3123a228d base::MessageLoop::DoDelayedWork() #50 0x7fe3122a1f25 base::MessagePumpGlib::Run() #51 0x7fe3123a17f0 base::MessageLoop::RunHandler() #52 0x7fe3124093b2 base::RunLoop::Run() #53 0x7fe324217e4d ChromeBrowserMainParts::MainMessageLoopRun() #54 0x7fe31ad2a8bf content::BrowserMainLoop::RunMainMessageLoopParts() #55 0x7fe31ad344c7 content::BrowserMainRunnerImpl::Run() #56 0x7fe31ad251b1 content::BrowserMain() #57 0x7fe31abb997f content::RunNamedProcessTypeMain() #58 0x7fe31abbcce8 content::ContentMainRunnerImpl::Run() #59 0x7fe31abb8ee5 content::ContentMain() #60 0x7fe3206d3505 ChromeMain #61 0x7fe3206d34b2 main Cannot upload crash dump: cannot exec /sbin/crash_reporter Crash_reporter failed to process crash report Original issue's description: > Enable forced extension updates on NaCl arch mismatch > > This makes extensions aware of the platforms for which > they have platform-specific resources installed, if any. > > This also hooks up the extension update code with some > additional logic to place an extension in forced-update > mode if it has platform-specific resources which don't > match the current NaCl architecture. > > BUG=409948 > TEST=install an extension which uses NaCl (QuickOffice for example). Rename the _platform-specific/<your-nacl-arch> directory some something else and force an update (e.g. via chrome://extensions button). Observe that a new CRX is downloaded and installed. > > Committed: https://chromium.googlesource.com/chromium/src/+/4a92281fa5d331860d65a59ba45dc882a5c71df4 [email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=409948 Review URL: https://codereview.chromium.org/532183003 Cr-Commit-Position: refs/heads/master@{#293128}

…atchset #9 id:160001 of https://codereview.chromium.org/376653002/) Reason for revert: Ignorer-bot project has been delayed to determine whether it is necessary at all. This doesn't have to be in the repo. Original issue's description: > Created an empty expectations file to ignore flaky tests > > This is used by https://codereview.chromium.org/373223003/ > > BUG=390600 > [email protected], [email protected], [email protected] > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284062 [email protected],[email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=390600 Review URL: https://codereview.chromium.org/549103003 Cr-Commit-Position: refs/heads/master@{#293750}

…::ExecuteCommands. (patchset #1 id:1 of https://codereview.chromium.org/547783002/) Reason for revert: Broke Linux ChromiumOS Tests (dbg)(3) http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/1206 BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x7f3bcf3aa67e base::debug::StackTrace::StackTrace() #1 0x0000041c884a content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f3bc709f4a0 <unknown> #3 0x7f3bc7151a43 __poll #4 0x7f3bc7b8dff6 <unknown> #5 0x7f3bc7b8e124 g_main_context_iteration #6 0x7f3bcf366f35 base::MessagePumpGlib::Run() #7 0x7f3bcf468180 base::MessageLoop::RunHandler() #8 0x7f3bcf4cfcc2 base::RunLoop::Run() #9 0x0000041e0729 content::RunThisRunLoop() #10 0x0000041e06ba content::RunMessageLoop() #11 0x000000668feb ExtensionApiTest::ResultCatcher::GetNextResult() #12 0x0000006a30dd extensions::CommandsApiTest_ContinuePropagation_Test::RunTestOnMainThread() #13 0x0000006a3712 extensions::CommandsApiTest_ContinuePropagation_Test::RunTestOnMainThread() #14 0x00000176be8b InProcessBrowserTest::RunTestOnMainThreadLoop() #15 0x0000041c85c8 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #16 0x0000041c9cf2 base::internal::RunnableAdapter<>::Run() #17 0x0000041c9c69 base::internal::InvokeHelper<>::MakeItSo() #18 0x0000041c9c25 base::internal::Invoker<>::Run() #19 0x00000063f0de base::Callback<>::Run() #20 0x0000042dddd2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #21 0x0000042dca92 ChromeBrowserMainParts::PreMainMessageLoopRun() #22 0x000002e77daf chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #23 0x7f3bd7bd2e96 content::BrowserMainLoop::PreMainMessageLoopRun() #24 0x7f3bd7bd96f2 base::internal::RunnableAdapter<>::Run() #25 0x7f3bd7bd965c base::internal::InvokeHelper<>::MakeItSo() #26 0x7f3bd7bd960a base::internal::Invoker<>::Run() #27 0x7f3bd80a852e base::Callback<>::Run() #28 0x7f3bd841bd2b content::StartupTaskRunner::RunAllTasksNow() #29 0x7f3bd7bd12f0 content::BrowserMainLoop::CreateStartupTasks() #30 0x7f3bd7bdcc72 content::BrowserMainRunnerImpl::Initialize() #31 0x7f3bd7bcda55 content::BrowserMain() #32 0x7f3bd7a6224f content::RunNamedProcessTypeMain() #33 0x7f3bd7a655b8 content::ContentMainRunnerImpl::Run() #34 0x7f3bd7a617b5 content::ContentMain() #35 0x0000041c82cb content::BrowserTestBase::SetUp() #36 0x00000176afc3 InProcessBrowserTest::SetUp() #37 0x000000674823 ExtensionBrowserTest::SetUp() #38 0x000000674852 ExtensionBrowserTest::SetUp() #39 0x0000018298a3 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #40 0x00000181686e testing::internal::HandleExceptionsInMethodIfSupported<>() #41 0x00000180ad73 testing::Test::Run() #42 0x00000180b4cb testing::TestInfo::Run() #43 0x00000180baca testing::TestCase::Run() #44 0x000001811009 testing::internal::UnitTestImpl::RunAllTests() #45 0x0000018225b3 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #46 0x0000018185fe testing::internal::HandleExceptionsInMethodIfSupported<>() #47 0x000001810c97 testing::UnitTest::Run() #48 0x0000041a5531 RUN_ALL_TESTS() #49 0x0000041a4547 base::TestSuite::Run() #50 0x0000008026d2 InteractiveUITestSuiteRunner::RunTestSuite() #51 0x000001769618 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite() #52 0x0000041d9efb content::LaunchTests() #53 0x00000176954b LaunchChromeTests() #54 0x00000080262f main #55 0x7f3bc708a76d __libc_start_main #56 0x0000005ffda9 <unknown> [123/334] CommandsApiTest.ContinuePropagation (TIMED OUT) Original issue's description: > Fixes HasEventListener check in ExtensionKeybindingRegistry::ExecuteCommands. > > ExtensionKeybindingRegistry::ExecuteCommands functions in two distinct ways -- execute all commands based on an accelerator, or, execute an accelerator for a given extension. The former behavior is implied by passing an empty string. > > Previously, only the latter case was handled when trying to continue propagating keys. > > BUG=407163 > TEST=try bots (interactive_ui_tests --gtest_filter=CommandsApiTest.*). > > Committed: https://chromium.googlesource.com/chromium/src/+/189a2ed4d209231d517b0e64a722722dead3f17a [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=407163 Review URL: https://codereview.chromium.org/552533003 Cr-Commit-Position: refs/heads/master@{#293780}

…ttps://codereview.chromium.org/543663003/) Reason for revert: Speculative, to see if it helps with ==12563== WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x7f834414fd2c in views::DesktopWindowTreeHostX11::InitX11Window(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1164 #1 0x7f834414dc6e in views::DesktopWindowTreeHostX11::Init(aura::Window*, views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:259 #2 0x7f83441408e9 in views::DesktopNativeWidgetAura::InitNativeWidget(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_native_widget_aura.cc:420 #3 0x7f834411722f in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:358 #4 0x7f834473bc8b in ChromeNativeAppWindowViews::InitializeDefaultWindow(extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:231 #5 0x7f834473f52d in ChromeNativeAppWindowViews::InitializeWindow(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:672 #6 0x7f834c3d8bbe in apps::NativeAppWindowViews::Init(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) apps/ui/views/native_app_window_views.cc:46 #7 0x7f834460443c in ChromeAppsClient::CreateNativeAppWindowImpl(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_apps_client_views.cc:14 #8 0x7f834be98433 in extensions::AppWindow::Init(GURL const&, extensions::AppWindowContents*, extensions::AppWindow::CreateParams const&) extensions/browser/app_window/app_window.cc:281 #9 0x7f834bd6bbfb in extensions::AppWindowCreateFunction::RunAsync() extensions/browser/api/app_window/app_window_api.cc:296 #10 0x7f834bee4510 in AsyncExtensionFunction::Run() extensions/browser/extension_function.cc:452 #11 0x7f834bee9771 in extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*, content::RenderFrameHost*, base::Callback<void (ExtensionFunction::ResponseType, base::ListValue const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)> const&) extensions/browser/extension_function_dispatcher.cc:392 #12 0x7f834bee86b6 in extensions::ExtensionFunctionDispatcher::Dispatch(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*) extensions/browser/extension_function_dispatcher.cc:309 #13 0x7f834bedac91 in OnRequest extensions/browser/extension_host.cc:342 #14 0x7f8345add9d2 in content::WebContentsImpl::OnMessageReceived(content::RenderViewHost*, content::RenderFrameHost*, IPC::Message const&) content/browser/web_contents/web_contents_impl.cc:526 #15 0x7f83459847fe in content::RenderViewHostImpl::OnMessageReceived(IPC::Message const&) content/browser/renderer_host/render_view_host_impl.cc:894 Started happening here http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/104/ (see http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/104/ for symbols), and this looks tangentially related (it touched the file the uninitialized read is in.) Line 1164 is if (params.visible_on_all_workspaces) { state_atom_list.push_back(atom_cache_.GetAtom("_NET_WM_STATE_STICKY")); ui::SetIntProperty(xwindow_, "_NET_WM_DESKTOP", "CARDINAL", kAllDesktops); } https://chromium.googlesource.com/chromium/src/+blame/master/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc Original issue's description: > Fix maximize on some window managers > > On some window managers the Maximize hints are not respected when they > are set on an unmapped window. There was an existing workaround for this > in the code, but the workaround failed whenever ShowWindowWithState > didn't happen to be called with the parameters needed to activate the > workaround. This meant that if a window was first made visible and later > activated, it would not get maximized at all. > > This fix saves whether the maximize hints need to be sent to the window, > and makes sure it gets done after mapping the window. > > BUG= > > Committed: https://chromium.googlesource.com/chromium/src/+/334fca491b7e798d75e76a56c57074d3187602be [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/554843002 Cr-Commit-Position: refs/heads/master@{#293786}

…id:1 of https://codereview.chromium.org/554843002/) Reason for revert: I unchecked cq, not sure why this revert was landed. (I want to revert https://codereview.chromium.org/469993003/ instead) Original issue's description: > Revert of Fix maximize on some window managers (patchset #1 id:1 of https://codereview.chromium.org/543663003/) > > Reason for revert: > Speculative, to see if it helps with > > ==12563== WARNING: MemorySanitizer: use-of-uninitialized-value > #0 0x7f834414fd2c in views::DesktopWindowTreeHostX11::InitX11Window(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1164 > #1 0x7f834414dc6e in views::DesktopWindowTreeHostX11::Init(aura::Window*, views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:259 > #2 0x7f83441408e9 in views::DesktopNativeWidgetAura::InitNativeWidget(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_native_widget_aura.cc:420 > #3 0x7f834411722f in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:358 > #4 0x7f834473bc8b in ChromeNativeAppWindowViews::InitializeDefaultWindow(extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:231 > #5 0x7f834473f52d in ChromeNativeAppWindowViews::InitializeWindow(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:672 > #6 0x7f834c3d8bbe in apps::NativeAppWindowViews::Init(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) apps/ui/views/native_app_window_views.cc:46 > #7 0x7f834460443c in ChromeAppsClient::CreateNativeAppWindowImpl(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_apps_client_views.cc:14 > #8 0x7f834be98433 in extensions::AppWindow::Init(GURL const&, extensions::AppWindowContents*, extensions::AppWindow::CreateParams const&) extensions/browser/app_window/app_window.cc:281 > #9 0x7f834bd6bbfb in extensions::AppWindowCreateFunction::RunAsync() extensions/browser/api/app_window/app_window_api.cc:296 > #10 0x7f834bee4510 in AsyncExtensionFunction::Run() extensions/browser/extension_function.cc:452 > #11 0x7f834bee9771 in extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*, content::RenderFrameHost*, base::Callback<void (ExtensionFunction::ResponseType, base::ListValue const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)> const&) extensions/browser/extension_function_dispatcher.cc:392 > #12 0x7f834bee86b6 in extensions::ExtensionFunctionDispatcher::Dispatch(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*) extensions/browser/extension_function_dispatcher.cc:309 > #13 0x7f834bedac91 in OnRequest extensions/browser/extension_host.cc:342 > #14 0x7f8345add9d2 in content::WebContentsImpl::OnMessageReceived(content::RenderViewHost*, content::RenderFrameHost*, IPC::Message const&) content/browser/web_contents/web_contents_impl.cc:526 > #15 0x7f83459847fe in content::RenderViewHostImpl::OnMessageReceived(IPC::Message const&) content/browser/renderer_host/render_view_host_impl.cc:894 > > Started happening here http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/104/ (see http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/104/ for symbols), and this looks tangentially related (it touched the file the uninitialized read is in.) > > Line 1164 is > > if (params.visible_on_all_workspaces) { > state_atom_list.push_back(atom_cache_.GetAtom("_NET_WM_STATE_STICKY")); > ui::SetIntProperty(xwindow_, "_NET_WM_DESKTOP", "CARDINAL", kAllDesktops); > } > > https://chromium.googlesource.com/chromium/src/+blame/master/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc > > Original issue's description: > > Fix maximize on some window managers > > > > On some window managers the Maximize hints are not respected when they > > are set on an unmapped window. There was an existing workaround for this > > in the code, but the workaround failed whenever ShowWindowWithState > > didn't happen to be called with the parameters needed to activate the > > workaround. This meant that if a window was first made visible and later > > activated, it would not get maximized at all. > > > > This fix saves whether the maximize hints need to be sent to the window, > > and makes sure it gets done after mapping the window. > > > > BUG= > > > > Committed: https://chromium.googlesource.com/chromium/src/+/334fca491b7e798d75e76a56c57074d3187602be > > [email protected],[email protected] > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://chromium.googlesource.com/chromium/src/+/013b6d4051e8e2c8960faa12b92e273925aaee5b [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/551123002 Cr-Commit-Position: refs/heads/master@{#293790}

….chromium.org/469993003) Speculative, to see if it helps with ==12563== WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x7f834414fd2c in views::DesktopWindowTreeHostX11::InitX11Window(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1164 #1 0x7f834414dc6e in views::DesktopWindowTreeHostX11::Init(aura::Window*, views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:259 #2 0x7f83441408e9 in views::DesktopNativeWidgetAura::InitNativeWidget(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_native_widget_aura.cc:420 #3 0x7f834411722f in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:358 #4 0x7f834473bc8b in ChromeNativeAppWindowViews::InitializeDefaultWindow(extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:231 #5 0x7f834473f52d in ChromeNativeAppWindowViews::InitializeWindow(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:672 #6 0x7f834c3d8bbe in apps::NativeAppWindowViews::Init(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) apps/ui/views/native_app_window_views.cc:46 #7 0x7f834460443c in ChromeAppsClient::CreateNativeAppWindowImpl(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_apps_client_views.cc:14 #8 0x7f834be98433 in extensions::AppWindow::Init(GURL const&, extensions::AppWindowContents*, extensions::AppWindow::CreateParams const&) extensions/browser/app_window/app_window.cc:281 #9 0x7f834bd6bbfb in extensions::AppWindowCreateFunction::RunAsync() extensions/browser/api/app_window/app_window_api.cc:296 #10 0x7f834bee4510 in AsyncExtensionFunction::Run() extensions/browser/extension_function.cc:452 #11 0x7f834bee9771 in extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*, content::RenderFrameHost*, base::Callback<void (ExtensionFunction::ResponseType, base::ListValue const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)> const&) extensions/browser/extension_function_dispatcher.cc:392 #12 0x7f834bee86b6 in extensions::ExtensionFunctionDispatcher::Dispatch(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*) extensions/browser/extension_function_dispatcher.cc:309 #13 0x7f834bedac91 in OnRequest extensions/browser/extension_host.cc:342 #14 0x7f8345add9d2 in content::WebContentsImpl::OnMessageReceived(content::RenderViewHost*, content::RenderFrameHost*, IPC::Message const&) content/browser/web_contents/web_contents_impl.cc:526 #15 0x7f83459847fe in content::RenderViewHostImpl::OnMessageReceived(IPC::Message const&) content/browser/renderer_host/render_view_host_impl.cc:894 Started happening here http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/98 (see stdio for symbols), and this looks like the only change in that build. This reverts commit c76ef73. BUG=384644 [email protected] Review URL: https://codereview.chromium.org/550413002 Cr-Commit-Position: refs/heads/master@{#293792}

…ling out in UpdateDisplays (patchset #4 id:60001 of https://codereview.chromium.org/559213002/) Reason for revert: I am reverting this as it resulted in test VirtualKeyboardUsabilityExperimentTest.VirtualKeyboardWindowTest consistently crashing on Linux ChromiumOS Tests, see: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31731 http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/builds/2914 Stack trace: Objects involved in the operation: sequence "this" @ 0x0x3e568fbdcc90 { } Received signal 6 #0 0x7fcb9c8936fe base::debug::StackTrace::StackTrace() #1 0x7fcb9c893230 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7fcb8c474cb0 \u003Cunknown> #3 0x7fcb8bbc4425 gsignal #4 0x7fcb8bbc7b8b abort #5 0x7fcb8c1c75ad __gnu_debug::_Error_formatter::_M_error() #6 0x7fcb9a306513 std::__debug::vector\u003C>::operator[]() #7 0x7fcb9a2fbba9 ash::DisplayManager::GetCurrentDisplayIdPair() #8 0x7fcb9a2d96cf ash::DisplayController::PostDisplayConfigurationChange() #9 0x7fcb9a2d98bc ash::DisplayController::PostDisplayConfigurationChange() #10 0x7fcb9a2fd22a ash::DisplayManager::UpdateDisplays() #11 0x7fcb9a2fdbe8 ash::DisplayManager::SetDisplayRotation() #12 0x7fcb9a33425b ash::VirtualKeyboardWindowController::FlipDisplay() #13 0x7fcb9a3340d7 ash::VirtualKeyboardWindowController::UpdateWindow() #14 0x7fcb9a2d92df ash::DisplayController::CreateOrUpdateNonDesktopDisplay() #15 0x7fcb9a2d937f ash::DisplayController::CreateOrUpdateNonDesktopDisplay() #16 0x7fcb9a300ea9 ash::(anonymous namespace)::NonDesktopDisplayUpdater::~NonDesktopDisplayUpdater() #17 0x7fcb9a300df1 ash::DisplayManager::CreateMirrorWindowIfAny() Original issue's description: > Force calling PostDisplayConfigurationChange() even if earyling out in UpdateDisplays > > When changing from software mirroring mode to sinlge display mode, it > is possible there is no need to update |displays_| and we early out > UpdateDisplays(). But we still want to run the PostDisplayConfigurationChange() > cause there are some clients need to act on this, e.g. > TouchTransformerController needs to adjust the TouchTransformer when > switching from dual displays to single display. > > BUG=chrome-os-partner:31868 > TEST=tested on Big, after existing software mirroring mode, the touch location > transformation is still correct. > > Committed: https://crrev.com/4802a8552a40e1f80606ca7171dc2f79930e7fb3 > Cr-Commit-Position: refs/heads/master@{#294481} [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=chrome-os-partner:31868 Review URL: https://codereview.chromium.org/569553002 Cr-Commit-Position: refs/heads/master@{#294553}

… (patchset #2 id:60001 of https://codereview.chromium.org/562763002/) Reason for revert: This broken the Linux ASan LSan Tests: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7506 http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/5717 Sample callstacks: Direct leak of 400 byte(s) in 10 object(s) allocated from: #0 0x55c6eb in __interceptor_malloc (/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x55c6eb) #1 0xab24bb8 in raw_desc_to_config third_party/libusb/src/libusb/descriptor.c:501:45 #2 0xab24ab9 in libusb_get_active_config_descriptor third_party/libusb/src/libusb/descriptor.c:601:7 #3 0xab14aae in device::UsbDeviceImpl::GetConfiguration() device/usb/usb_device_impl.cc:199:9 #4 0xb37d57b in EnumerateOnFileThread(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>) chrome/browser/devtools/device/usb/android_usb_device.cc:262:42 #5 0xb38aebf in Run base/bind_internal.h:288:12 #6 0xb38aebf in base::internal::InvokeHelper\u003Cfalse, void, base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, void (crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*)>::MakeItSo(base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*) base/bind_internal.h:927 #7 0x2d58bff in Run base/callback.h:401:12 #8 0x2d58bff in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #9 0x2ca519c in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #10 0x2ca629e in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #11 0x2ca629e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #12 0x2c23ddf in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #13 0x2cd57b4 in base::RunLoop::Run() base/run_loop.cc:49:3 #14 0x2ca39c4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #15 0x50fd018 in content::BrowserThreadImpl::FileThreadRun(base::MessageLoop*) content/browser/browser_thread_impl.cc:190:3 #16 0x50fdca7 in content::BrowserThreadImpl::Run(base::MessageLoop*) content/browser/browser_thread_impl.cc:244:14 #17 0x2d1ebc8 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #18 0x2d12b20 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #19 0x7f4d560a3e99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Direct leak of 400 byte(s) in 10 object(s) allocated from: #0 0x55c6eb in __interceptor_malloc (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/browser_tests+0x55c6eb) #1 0xab24bb8 in raw_desc_to_config third_party/libusb/src/libusb/descriptor.c:501:45 #2 0xab24ab9 in libusb_get_active_config_descriptor third_party/libusb/src/libusb/descriptor.c:601:7 #3 0xab14aae in device::UsbDeviceImpl::GetConfiguration() device/usb/usb_device_impl.cc:199:9 #4 0xb37d57b in EnumerateOnFileThread(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>) chrome/browser/devtools/device/usb/android_usb_device.cc:262:42 #5 0xb38aebf in Run base/bind_internal.h:288:12 #6 0xb38aebf in base::internal::InvokeHelper\u003Cfalse, void, base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, void (crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*)>::MakeItSo(base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*) base/bind_internal.h:927 #7 0x2d58bff in Run base/callback.h:401:12 #8 0x2d58bff in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #9 0x2ca519c in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #10 0x2ca629e in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #11 0x2ca629e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #12 0x2c23ddf in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #13 0x2cd57b4 in base::RunLoop::Run() base/run_loop.cc:49:3 #14 0x2ca39c4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #15 0x50fd018 in content::BrowserThreadImpl::FileThreadRun(base::MessageLoop*) content/browser/browser_thread_impl.cc:190:3 #16 0x50fdca7 in content::BrowserThreadImpl::Run(base::MessageLoop*) content/browser/browser_thread_impl.cc:244:14 #17 0x2d1ebc8 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #18 0x2d12b20 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #19 0x7f4aef980e99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Original issue's description: > Convert device::UsbConfigDescriptor and friends to structs. > > These classes do not need to be classes and expecially don't need to be > abstract classes as this leads to a complicated implementation and > complicated tests. All USB devices no matter the platform will have the > same descriptor data. > > This change follows the model of device::HidDeviceInfo. > > BUG= > > Committed: https://crrev.com/be9e363a3af57bd313fbb96ec3b5fa02cef769b5 > Cr-Commit-Position: refs/heads/master@{#294594} [email protected],[email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/567003002 Cr-Commit-Position: refs/heads/master@{#294640}

…ce and (patchset #9 id:160001 of https://codereview.chromium.org/568883003/) Reason for revert: ViewManagerTest failure. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=chromium.win&testType=mojo_view_manager_unittests&tests=ViewManagerTest.AddAncestorFails,ViewManagerTest.AddViewWithNoChange,ViewManagerTest.CantAccessChildrenOfEmbeddedView,ViewManagerTest.CantGetViewTreeOfOtherRoots,ViewManagerTest.CantModifyChildrenOfEmbeddedView,ViewManagerTest.CantRemoveViewsInOtherRoots,ViewManagerTest.CreateView,ViewManagerTest.DeleteView,ViewManagerTest.DeleteViewFromAnotherConnectionDisallowed,ViewManagerTest.EmbedWithSameViewId,ViewManagerTest.EmbedWithSameViewId2,ViewManagerTest.MultipleEmbedRootsBeforeWTHReady,ViewManagerTest.OnViewInput,ViewManagerTest.ReorderView,ViewManagerTest.ReuseDeletedViewId,ViewManagerTest.SetViewVisibility,ViewManagerTest.SetViewVisibilityNotifications,ViewManagerTest.ViewHierarchyChangedAddingKnownToUnknown,ViewManagerTest.ViewHierarchyChangedViews,ViewManagerTest.ViewsRemovedWhenEmbedding Original issue's description: > Second attempt to land change to remove NativeViewportService and > ViewManager from mojo_shell. First attempt here: > https://codereview.chromium.org/477923004/ > > Failed the linux gn dbg build after cq landed: > http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/12251 > > BUG= > [email protected] > > Committed: https://crrev.com/d3e622b0bb31f20c274bc9ad634b8ee7bae99ac1 > Cr-Commit-Position: refs/heads/master@{#295230} [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/578793002 Cr-Commit-Position: refs/heads/master@{#295245}

…disable GCM (patchset #8 id:150001 of https://codereview.chromium.org/561943002/) Reason for revert: this CL might be breaking browser_tests and interactive_ui_tests on ChromeOS because it's starting a request on startup. here's an example: [15345:15369:0918/132152:ERROR:leak_tracker.h(97)] Leaked 0x11cd70da7cc0 which was allocated by: [15345:15369:0918/132152:ERROR:leak_tracker.h(98)] #0 0x7f44b584025e base::debug::StackTrace::StackTrace() #1 0x000000dfc481 base::debug::LeakTracker<>::LeakTracker() #2 0x000000df3e8d SystemURLRequestContextGetter::SystemURLRequestContextGetter() #3 0x000000df57f1 IOThread::InitSystemRequestContext() #4 0x000000df570b IOThread::system_url_request_context_getter() #5 0x000001443d9e BrowserProcessImpl::system_request_context() #6 0x000001028a8e SafeBrowsingService::Initialize() #7 0x0000014462c9 BrowserProcessImpl::CreateSafeBrowsingService() #8 0x000001446196 BrowserProcessImpl::safe_browsing_service() #9 0x0000014b9a06 ChromeResourceDispatcherHostDelegate::ChromeResourceDispatcherHostDelegate() #10 0x0000014466dc BrowserProcessImpl::ResourceDispatcherHostCreated() #11 0x0000008a88e5 chrome::ChromeContentBrowserClient::ResourceDispatcherHostCreated() #12 0x7f44be489a2f content::ResourceDispatcherHostImpl::ResourceDispatcherHostImpl() #13 0x7f44be060f44 content::BrowserMainLoop::BrowserThreadsStarted() #14 0x7f44be068302 base::internal::RunnableAdapter<>::Run() #15 0x7f44be06826c base::internal::InvokeHelper<>::MakeItSo() #16 0x7f44be06821a base::internal::Invoker<>::Run() #17 0x7f44be54e46e base::Callback<>::Run() #18 0x7f44be8d223b content::StartupTaskRunner::RunAllTasksNow() #19 0x7f44be05ff97 content::BrowserMainLoop::CreateStartupTasks() #20 0x7f44be06b824 content::BrowserMainRunnerImpl::Initialize() #21 0x7f44be05c7df content::BrowserMain() #22 0x7f44bdee5f6f content::RunNamedProcessTypeMain() #23 0x7f44bdee9268 content::ContentMainRunnerImpl::Run() #24 0x7f44bdee5505 content::ContentMain() #25 0x0000041aa8cb content::BrowserTestBase::SetUp() #26 0x00000173e117 InProcessBrowserTest::SetUp() #27 0x000000671180 ExtensionBrowserTest::SetUp() #28 0x0000006711b2 ExtensionBrowserTest::SetUp() #29 0x0000017fb993 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #30 0x0000017e8bfe testing::internal::HandleExceptionsInMethodIfSupported<>() #31 0x0000017dd1e3 testing::Test::Run() #32 0x0000017dd92b testing::TestInfo::Run() #33 0x0000017ddf1a testing::TestCase::Run() #34 0x0000017e3413 testing::internal::UnitTestImpl::RunAllTests() #35 0x0000017f47d3 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #36 0x0000017ea96e testing::internal::HandleExceptionsInMethodIfSupported<>() #37 0x0000017e30b1 testing::UnitTest::Run() #38 0x000004187e41 RUN_ALL_TESTS() #39 0x000004186e67 base::TestSuite::Run() #40 0x0000007fcd62 InteractiveUITestSuiteRunner::RunTestSuite() #41 0x00000173c7b8 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite() #42 0x0000041bc2fb content::LaunchTests() #43 0x00000173c6e9 LaunchChromeTests() #44 0x0000007fccbf main #45 0x7f44ad8ed76d __libc_start_main #46 0x000000601389 <unknown> [15345:15369:0918/132152:FATAL:leak_tracker.h(102)] Check failed: 0u == count (0 vs. 1) #0 0x7f44b584025e base::debug::StackTrace::StackTrace() #1 0x7f44b58d7a62 logging::LogMessage::~LogMessage() #2 0x000000dfdd01 base::debug::LeakTracker<>::CheckForLeaks() #3 0x000000df8e13 IOThread::CleanUp() #4 0x7f44be0810b6 content::BrowserThreadImpl::CleanUp() #5 0x7f44be07e852 content::BrowserProcessSubThread::CleanUp() #6 0x7f44b59d0601 base::Thread::ThreadMain() #7 0x7f44b59bba3c base::(anonymous namespace)::ThreadFunc() #8 0x7f44b1aa9e9a start_thread #9 0x7f44ad9c03fd clone Original issue's description: > Add GCMChannelStatusSyncer to schedule requests and enable/disable GCM > > BUG=384041 > TEST=new tests added > > Committed: https://crrev.com/3c23f4a188e171998f3042ad62f4aa5717e66d63 > Cr-Commit-Position: refs/heads/master@{#295524} [email protected],[email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=384041 Review URL: https://codereview.chromium.org/582913003 Cr-Commit-Position: refs/heads/master@{#295549}

…50001 of https://codereview.chromium.org/542733002/) Reason for revert: Introduced memory leaks on linux asan http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/5892: Direct leak of 80 byte(s) in 2 object(s) allocated from: #0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb) #1 0x309f8d7 in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:620:5 #2 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17 #3 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17 #4 0x2e3b0bf in Run base/callback.h:401:12 #5 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #6 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #7 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #8 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #9 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #10 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3 #11 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #12 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #13 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #14 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Indirect leak of 64 byte(s) in 2 object(s) allocated from: #0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb) #1 0x30ebaaf in disk_cache::Rankings::GetNext(disk_cache::StorageBlock<disk_cache::RankingsNode>*, disk_cache::Rankings::List) net/disk_cache/blockfile/rankings.cc:435:5 #2 0x30a219d in disk_cache::BackendImpl::OpenFollowingEntryFromList(disk_cache::Rankings::List, disk_cache::StorageBlock<disk_cache::RankingsNode>**, disk_cache::EntryImpl**) net/disk_cache/blockfile/backend_impl.cc:1694:36 #3 0x309fa3d in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:638:11 #4 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17 #5 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17 #6 0x2e3b0bf in Run base/callback.h:401:12 #7 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #8 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #9 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #10 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #11 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #12 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3 #13 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #14 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #15 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #16 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Indirect leak of 36 byte(s) in 1 object(s) allocated from: #0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb) #1 0x30c0696 in AllocateData net/disk_cache/blockfile/storage_block-inl.h:179:5 #2 0x30c0696 in disk_cache::StorageBlock<disk_cache::RankingsNode>::Load() net/disk_cache/blockfile/storage_block-inl.h:121 #3 0x30e6fe9 in disk_cache::Rankings::GetRanking(disk_cache::StorageBlock<disk_cache::RankingsNode>*) net/disk_cache/blockfile/rankings.cc:586:8 #4 0x30ebd5a in disk_cache::Rankings::GetNext(disk_cache::StorageBlock<disk_cache::RankingsNode>*, disk_cache::Rankings::List) net/disk_cache/blockfile/rankings.cc:440:8 #5 0x30a219d in disk_cache::BackendImpl::OpenFollowingEntryFromList(disk_cache::Rankings::List, disk_cache::StorageBlock<disk_cache::RankingsNode>**, disk_cache::EntryImpl**) net/disk_cache/blockfile/backend_impl.cc:1694:36 #6 0x309fa3d in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:638:11 #7 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17 #8 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17 #9 0x2e3b0bf in Run base/callback.h:401:12 #10 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #11 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #12 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #13 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #14 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #15 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3 #16 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #17 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #18 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #19 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Original issue's description: > Remove void** from disk_cache interface. > > Enumeration and iteration were passing around void**. With this CL, we > instead use an Iterator object. > > [email protected],[email protected],[email protected] > BUG=413644 > > Committed: https://crrev.com/732c8306d4864296511e7a3a252724b1bb34c342 > Cr-Commit-Position: refs/heads/master@{#295659} [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=413644 Review URL: https://codereview.chromium.org/585833002 Cr-Commit-Position: refs/heads/master@{#295677}

…410) (patchset #1 id:1 of https://codereview.chromium.org/590143002/) Reason for revert: Linux ASAN memory leaks after "Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407)" http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7724/steps/content_unittests/logs/stdio ==30366==ERROR: LeakSanitizer: detected memory leaks Direct leak of 34 byte(s) in 1 object(s) allocated from: #0 0x50482b in malloc (/b/build/slave/Linux_ASan_LSan_Tests__2_/build/src/out/Release/content_unittests+0x50482b) #1 0x58b7516 in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:538:20 #2 0x58b7516 in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:554 #3 0x58b7516 in createUninitialized third_party/WebKit/Source/wtf/text/StringImpl.cpp:299 #4 0x58b7516 in WTF::StringImpl::create(unsigned char const*, unsigned int) third_party/WebKit/Source/wtf/text/StringImpl.cpp:418 #5 0x58e809f in WTF::String::fromUTF8(unsigned char const*, unsigned long) third_party/WebKit/Source/wtf/text/WTFString.cpp:911:16 #6 0x58ffa2f in fromUTF8 third_party/WebKit/Source/wtf/text/WTFString.h:400:67 #7 0x58ffa2f in blink::WebString::fromUTF8(char const*, unsigned long) third_party/WebKit/Source/platform/exported/WebString.cpp:91 #8 0x20a09ac in WebString<23> third_party/WebKit/public/platform/WebString.h:113:16 #9 0x20a09ac in content::MockMediaStreamRegistry::AddVideoTrack(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) content/renderer/media/mock_media_stream_registry.cc:36 #10 0x217484a in VideoSourceHandlerTest_OpenWithoutClose_Test content/renderer/media/video_source_handler_unittest.cc:97:1 #11 0x217484a in testing::internal::TestFactoryImpl<content::VideoSourceHandlerTest_OpenWithoutClose_Test>::CreateTest() testing/gtest/include/gtest/internal/gtest-internal.h:486 #12 0x2f13c63 in HandleExceptionsInMethodIfSupported<testing::internal::TestFactoryBase, testing::Test *> testing/gtest/src/gtest.cc:2418:12 #13 0x2f13c63 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2601 #14 0x2f14df6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #15 0x2f28853 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #16 0x2f27e54 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #17 0x2f27e54 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #18 0x2eb1e53 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #19 0x2eb1e53 in base::TestSuite::Run() base/test/test_suite.cc:226 #20 0x2ea717b in Run base/callback.h:401:12 #21 0x2ea717b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498 #22 0x2ea6c70 in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:553:10 #23 0x1ff5d0c in main content/test/run_all_unittests.cc:14:10 #24 0x7f375d21876c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > Roll src/third_party/WebKit 0f6e289:a63b92e (svn 182407:182410) > > Summary of changes available at: > https://chromium.googlesource.com/chromium/blink/+log/0f6e289..a63b92e > > [email protected],[email protected],[email protected] > > Committed: https://crrev.com/09e1192db2fc7c5295eb373626b77945ca10aee3 > Cr-Commit-Position: refs/heads/master@{#295959} [email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/593693004 Cr-Commit-Position: refs/heads/master@{#295961}

…407) (patchset #1 id:1 of https://codereview.chromium.org/588163003/) Reason for revert: Linux ASAN memory leaks after "Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407)" http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7724/steps/content_unittests/logs/stdio ==30366==ERROR: LeakSanitizer: detected memory leaks Direct leak of 34 byte(s) in 1 object(s) allocated from: #0 0x50482b in malloc (/b/build/slave/Linux_ASan_LSan_Tests__2_/build/src/out/Release/content_unittests+0x50482b) #1 0x58b7516 in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:538:20 #2 0x58b7516 in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:554 #3 0x58b7516 in createUninitialized third_party/WebKit/Source/wtf/text/StringImpl.cpp:299 #4 0x58b7516 in WTF::StringImpl::create(unsigned char const*, unsigned int) third_party/WebKit/Source/wtf/text/StringImpl.cpp:418 #5 0x58e809f in WTF::String::fromUTF8(unsigned char const*, unsigned long) third_party/WebKit/Source/wtf/text/WTFString.cpp:911:16 #6 0x58ffa2f in fromUTF8 third_party/WebKit/Source/wtf/text/WTFString.h:400:67 #7 0x58ffa2f in blink::WebString::fromUTF8(char const*, unsigned long) third_party/WebKit/Source/platform/exported/WebString.cpp:91 #8 0x20a09ac in WebString<23> third_party/WebKit/public/platform/WebString.h:113:16 #9 0x20a09ac in content::MockMediaStreamRegistry::AddVideoTrack(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) content/renderer/media/mock_media_stream_registry.cc:36 #10 0x217484a in VideoSourceHandlerTest_OpenWithoutClose_Test content/renderer/media/video_source_handler_unittest.cc:97:1 #11 0x217484a in testing::internal::TestFactoryImpl<content::VideoSourceHandlerTest_OpenWithoutClose_Test>::CreateTest() testing/gtest/include/gtest/internal/gtest-internal.h:486 #12 0x2f13c63 in HandleExceptionsInMethodIfSupported<testing::internal::TestFactoryBase, testing::Test *> testing/gtest/src/gtest.cc:2418:12 #13 0x2f13c63 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2601 #14 0x2f14df6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #15 0x2f28853 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #16 0x2f27e54 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #17 0x2f27e54 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #18 0x2eb1e53 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #19 0x2eb1e53 in base::TestSuite::Run() base/test/test_suite.cc:226 #20 0x2ea717b in Run base/callback.h:401:12 #21 0x2ea717b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498 #22 0x2ea6c70 in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:553:10 #23 0x1ff5d0c in main content/test/run_all_unittests.cc:14:10 #24 0x7f375d21876c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407) > > Summary of changes available at: > https://chromium.googlesource.com/chromium/blink/+log/08e97a9..0f6e289 > > [email protected],[email protected],[email protected] > > Committed: https://crrev.com/f57e3cf2113ac892f16777e5ab225f3c68b94ede > Cr-Commit-Position: refs/heads/master@{#295950} [email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/592783002 Cr-Commit-Position: refs/heads/master@{#295962}

Merge to M39, branch 2171 ----------------Original CL Description----------------------- (This is a stopgap until the zipping mentioned in the bug can happen.) Original Review URL: https://codereview.chromium.org/612143002 Original Cr-Commit-Position: refs/heads/master@{#297266} BUG=33920 TEST=<input type=file multiple />, ensure packages can't be selected [email protected] Review URL: https://codereview.chromium.org/616993003 Cr-Commit-Position: refs/branch-heads/2171@{#9} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}

… background color is changed >Transparency of the background color affects the result of |Label::ComputeDrawStringFlags()|. > >BUG=447932 >R=sky >NOTRY=true > >Review URL: https://codereview.chromium.org/846853003 > >Cr-Commit-Position: refs/heads/master@{#311088} BUG=447932 TBR=sky Review URL: https://codereview.chromium.org/816223004 Cr-Commit-Position: refs/branch-heads/2272@{#9} Cr-Branched-From: 827a380-refs/heads/master@{#310958}

Cr-Commit-Position: refs/branch-heads/2311@{#9} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}

…wn (patchset #9 id:350001 of https://codereview.chromium.org/900063002/) Reason for revert: Causes regression in cold start on Android and maybe Mac. Details in http://crbug.com/457248. Original issue's description: > Fixes for two different HUD issues related to win32k lockdown > > 1. Using a GDI bitmap -- switch to SkSurface instead > > 2. Lazily loading a font. This breaks for two different reasons. > The first is a DCHECK for doing IO on the Compositor thread. This > could have been just ignored in general since it's only for debug > usage, the drawbacks of minor jank are limited. > > However, once lockdown is on, the font load hard fails from the > renderer. So, load the typeface before lockdown and pass it into > CC and the hud via LayerTreeSettings. > > [email protected] > BUG=453731,455104 > TEST=run chrome with --enable-win32k-renderer-lockdown --show-fps-counter --ui-show-fps-counter on Win8 > > Committed: https://crrev.com/616a8e656b2d923ed393bde86adc150e555ba799 > Cr-Commit-Position: refs/heads/master@{#314929} [email protected],[email protected],[email protected] BUG=453731,455104,457248 Review URL: https://codereview.chromium.org/922293006 Cr-Commit-Position: refs/heads/master@{#317648} (cherry picked from commit 1793e04) Review URL: https://codereview.chromium.org/951423003 Cr-Commit-Position: refs/branch-heads/2311@{#25} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}

…-project#6 id:100001 of https://codereview.chromium.org/1103163004/) Reason for revert: It broke Clank bots. Original issue's description: > [Contextual Search] Remove opt-in code. > > This CL requires a downstream change: > https://chrome-internal-review.googlesource.com/#/c/214963/ > > BUG=482618 > [email protected], [email protected], [email protected] > > Committed: https://chromium.googlesource.com/chromium/src/+/277f043bb56fb1e4bb93d9d17fc3de4ada0eb81b [email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=482618 Review URL: https://codereview.chromium.org/1123313006 Cr-Commit-Position: refs/heads/master@{#330248} Review URL: https://codereview.chromium.org/1133403004 Cr-Commit-Position: refs/branch-heads/2403@{crosswalk-project#9} Cr-Branched-From: f54b809-refs/heads/master@{#330231}

To disable media

…default audio output device. BUG=578993 Review URL: https://codereview.chromium.org/1602083003 Cr-Commit-Position: refs/heads/master@{#370113} (cherry picked from commit bbfc18f) Review URL: https://codereview.chromium.org/1607923002 . Cr-Commit-Position: refs/branch-heads/2623@{crosswalk-project#9} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}

BUG=590744 Review URL: https://codereview.chromium.org/1744253002 Cr-Commit-Position: refs/heads/master@{#378218} (cherry picked from commit 75a9511) Review URL: https://codereview.chromium.org/1751673002 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#9} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}

…MACallback. Also added some unit testing for this file. BUG=555690 Review URL: https://codereview.chromium.org/1447643002 Cr-Commit-Position: refs/heads/master@{#359736} (cherry picked from commit 5ee4455) Review URL: https://codereview.chromium.org/1448093002 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#9} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}

Using onCreate and onDestroy means that the user can go into the Google Activity Controls or Sync settings subpages without triggering sync. Note that leaving the sync page will still cause sync to start, but at that point it seems safe to assume the settings are good. BUG=613340 Review-Url: https://codereview.chromium.org/1988133005 Cr-Commit-Position: refs/heads/master@{#395081} (cherry picked from commit 0acf90e) Review URL: https://codereview.chromium.org/2008623002 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#9} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}

[email protected] Change-Id: I3096b54381dbecc4539d171c8154eab6f82a7827 Reviewed-on: https://chromium-review.googlesource.com/648260 Reviewed-by: Michael Moss <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#9} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

Raphael Kubo da Costa and others added 6 commits June 17, 2013 14:27

Remove an unnecessary include added in 2238b7c

d748f63

Adding RWHVEfl

012cc8a

(cherry picked from commit 0bc0e7d)

more renaming in RWHV

440ea61

(cherry picked from commit 071f50b)

Rename header file include guard.

acfe57d

Add a stub EwkViewWrapper.

01e90ec

This is a hack that allows us to have an Evas_Object to return in WebContentsViewEfl even when we don't have a parent yet.

Experiment with passing our EwkViewWrapper around.

ca3a0c8

Here be dragons: reinterpret_casts everywhere etc.

drott closed this Jun 19, 2013

pozdnyakov pushed a commit to pozdnyakov/chromium-crosswalk that referenced this pull request Jul 11, 2013

Merge pull request crosswalk-project#9 from alexshalamov/cameo_webvie…

e0a6e04

…w_proto Fix scale factor

pozdnyakov mentioned this pull request Jan 14, 2015

[Extensions] Build glib message pump on Ozone by default #225

Merged

rakuco pushed a commit that referenced this pull request Mar 2, 2015

Incrementing VERSION to 42.0.2311.7

eb33cd5

Cr-Commit-Position: refs/branch-heads/2311@{#9} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}

PeterWangIntel pushed a commit to PeterWangIntel/chromium-crosswalk that referenced this pull request Dec 29, 2015

Merge pull request crosswalk-project#9 from PeterWangIntel/meida-17

239c7ca

To disable media

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge dro's RWHV and my EwkViewWrapper #9

Merge dro's RWHV and my EwkViewWrapper #9

rakuco commented Jun 18, 2013

xingnan commented Jun 18, 2013

Merge dro's RWHV and my EwkViewWrapper #9

Merge dro's RWHV and my EwkViewWrapper #9

Conversation

rakuco commented Jun 18, 2013

xingnan commented Jun 18, 2013

Trybot Dashboard

Building status:

Finished the build of the PATCH in this pull request

Rebuild the failed bots you want!

Select the bots:

Start the building: