This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[PLEASE NOT MERGE] Rename 'enable_xi21_mt' to 'enable_tizen21_mt' flag #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cameo uses Chromium resource framework (grit/grd). To make sure Cameo resource IDs are unique cross Chromium components, it is required to add new starting resource IDs. Since Cameo is a project built on Chromium, allocate starting IDs from 31000.
Committing on befalf of [email protected]. > Files.app: Changed the text color of selected item in the default action dialog. > > BUG=237159 > > Review URL: https://chromiumcodereview.appspot.com/14628010 [email protected] Review URL: https://codereview.chromium.org/14800013 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199684 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Try fast-fetch rather than full fetch if drive::FileSystem::GetEntryInfo failed. > > GetEntryInfoByPath is not only used for querying an entry info, > but also for just testing the existence of an entry. > So, it is not always desirable to start full fetch when > it does not exist locally. > > The new implementation falls back to full fetch after all > when the parent directory's entry is not ready either. > This should not be an issue, however. > Existence testing most typically happens when user tries to > put a new file in a folder, in which case, the folder is > already opened in UI and hence loaded. > > BUG=236708 > TEST=the steps explained in BUG. > [email protected] > > Review URL: https://codereview.chromium.org/14838003 > > Patch from Kazuhiro Inaba <[email protected]>. [email protected] Review URL: https://codereview.chromium.org/15063005 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199689 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> gpu: Make sure external texture destination is initialized > > When copying a texture from the GL_TEXTURE_EXTERNAL_OES target > (typically a video frame), we expect that the target size also defines > the source frame size. Add a check to make sure the target texture is > initialized when we do this. > > BUG=225781,239276 > > Review URL: https://chromiumcodereview.appspot.com/14858022 [email protected] Review URL: https://codereview.chromium.org/14806005 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199694 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Fixes couple of bugs triggered on chromeos when restoring a tab: > . Makes TabRestoreService go to loaded if asked to restore previous > session and it already has the max number of tabs. > . Adds method to TabRestoreServiceObserver this is sent when loaded. > . Makes ChromeShellDelegate use a TabRestoreServiceObserver to wait > for load to complete then restores. > > BUG=239194 > TEST=add some test coverage > [email protected], [email protected] > > Review URL: https://chromiumcodereview.appspot.com/14620014 [email protected] Review URL: https://codereview.chromium.org/15131002 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199729 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> As a part of switch back to GData WAPI, update DB version. > > Because GData WAPI and Drive API v2 has different resource id format, also the root folder id is different. > So, to switch back to GData WAPI, it is needed to refresh > the user's local metadata. > > BUG=239729 > TEST=Ran unit_tests > [email protected], [email protected] > > Review URL: https://codereview.chromium.org/15067011 [email protected] Review URL: https://codereview.chromium.org/15076004 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199734 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Removes the space for notification icon if it's not visible (2nd) > > GridLayout will make the space for a child even if the child is > not visible, which makes an extra space between status area and > panels when there are no notifications. > > To remove this space, this CL makes StatusAreaWidgetDelegate catch > child's visibility change, and do not count invisible children in > its GridLayout. > > The previous CL was reverted due to test break on win_aura. This > CL includes its fix. > > BUG=238770 > [email protected] > > Review URL: https://chromiumcodereview.appspot.com/14969008 [email protected] Review URL: https://codereview.chromium.org/14731020 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199735 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
git-svn-id: http://src.chromium.org/svn/branches/1500/src@199752 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> [Android] Warning if Left/Right attributes are used in layout and style xmls. > > Since crbug.com/235118, Left/Right attributes are deprecated in favor of Start/End. > So warn if it contains Left/Right. > > BUG=239606 > > Review URL: https://chromiumcodereview.appspot.com/14969022 [email protected] Review URL: https://codereview.chromium.org/14646040 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199759 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> [Android] Auto-generate only necessary v14 resources. > > V14 Resource auto-generation was introduced by crbug.com/235118. > However, some resources doesn't use v17 attributes, so we don't > need to generate for all resources. > > BUG=239742 > > Review URL: https://chromiumcodereview.appspot.com/14812015 [email protected] Review URL: https://codereview.chromium.org/15135002 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199760 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> [Android] Always set "mobile user agent" switch to the right vlaue when launching the browser process. > > This fixes the user agent for the browser process when the browser process has been started by an activity other than Main, like sync, bookmark provider, etc. If > chrome is started as a background process, the switch is never added. Since the > user agent is computed early on during start-up and not recomputed (from users > of content::GetUserAgent) this can lead to incorrect UA being reported and > broken results. > > We probably shouldn't do it this way long-term but this is a minimal fix for m27. > > NOTRY=true > BUG=237471 > > Review URL: https://chromiumcodereview.appspot.com/14682021 [email protected] Review URL: https://codereview.chromium.org/14671011 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199829 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Use a sysroot for Chrome Linux official builds. (try 2) > > BUG=224487 > [email protected] > > Review URL: https://codereview.chromium.org/15030002 [email protected] Review URL: https://codereview.chromium.org/14932012 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199841 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Convert build/linux/install-debian.wheezy.sysroot.wrapper.sh to python for Windows compatibility. > > BUG=224487 > TBR=dbeam > > Review URL: https://codereview.chromium.org/15059002 [email protected] Review URL: https://codereview.chromium.org/15143004 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199842 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
git-svn-id: http://src.chromium.org/svn/branches/1500/src@199853 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Disable Drive API v2 for M-28 release. > > Unfortunately it turned out that the files.search method of Drive API v2 > sometimes un-acceptablly slow. So, this CL temporarily disables Drive API v2 > and moves back to GData WAPI, until the problem is solved. > > BUG=239729 > TEST=Ran unit_tests and try bots > > Review URL: https://chromiumcodereview.appspot.com/14858024 [email protected] Review URL: https://codereview.chromium.org/14991005 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199884 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Revert r196089 "Add default values for Latin script font prefs." > > Reverting because it caused bug 237258. Many sites set lang="en" > which cause the Latin font prefs to be used, and it's surprising > to users that chrome://settings/fonts is not respected. We need > a more obvious way to customize per-script fonts first. > > BUG=237258 > TBR=bauerb > > Review URL: https://chromiumcodereview.appspot.com/14877009 [email protected] Review URL: https://codereview.chromium.org/14667011 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199941 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Move post-signin confirmation bubble to OneClickSigninSyncStarter. > > OneClickSigninSyncStarter now displays the post-signin confirmation bubble so > we can better integrate this with the rest of the signin UI (creating a new > profile, displaying the SAML dialog, etc). > > BUG=174655,232339,236828,238173 > [email protected] > > Review URL: https://codereview.chromium.org/14914003 [email protected] Review URL: https://codereview.chromium.org/14667012 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199943 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
git-svn-id: http://src.chromium.org/svn/branches/1500/src@200010 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Fixes a typo: disabled_extension_ids_ should not be cleared here. > > BUG=238525 > [email protected], > > Review URL: https://chromiumcodereview.appspot.com/14963006 [email protected] Review URL: https://codereview.chromium.org/14566018 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200011 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Changes the order of widget Close() and DecrementDeferCounter(). > > This is a bit tricky scenario, but the current code may lead to > a mismatch of increment/decrement by calling Close(). See the bug > for how the mismatch happens. > > BUG=238477 > > Review URL: https://chromiumcodereview.appspot.com/14820016 [email protected] Review URL: https://codereview.chromium.org/15019018 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200013 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Fixes a crash bug of calling animator without check. > > BUG=239508 > [email protected] > > Review URL: https://chromiumcodereview.appspot.com/14991004 [email protected] Review URL: https://codereview.chromium.org/15019019 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200014 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> PPAPI: Check for NULL dispatcher in PPP_VideoDecoder > > Please see the bug for details. > > BUG=238373 > > Review URL: https://chromiumcodereview.appspot.com/15039003 [email protected] Review URL: https://codereview.chromium.org/14772034 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200018 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Make cloud print dialog work with cloud printer on first signin. > Better check for current URL. > Assign data only to cloud print URLs. > Don't reset data_. > > BUG=236786 > > Review URL: https://chromiumcodereview.appspot.com/14864005 [email protected] Review URL: https://codereview.chromium.org/14850020 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200057 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Regression issue with "ShouldHop", the UpdateState->Layout flow was updated during M-27 to resolve a similar issue due to Updates that didn't change bounds not flowing into Layout, however due to some merging/partial reverts, this flow got partially reverted regressing these bugs. > > BUG=234655 > [email protected] > > Review URL: https://codereview.chromium.org/14640019 [email protected] Review URL: https://codereview.chromium.org/15174004 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200065 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Fix imageburner trying to extract downloaded image to unexisting folder. > > BUG=239330 > TEST=burned recovery image using chrome://imageburner > > Review URL: https://chromiumcodereview.appspot.com/14773024 [email protected] Review URL: https://codereview.chromium.org/14974008 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200071 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Base: Disable the scoped handle verifier. > > This is intended for the M28 beta branch. > > BUG=240766 > TEST=none > [email protected] > > Review URL: https://codereview.chromium.org/14979005 [email protected] Review URL: https://codereview.chromium.org/14657026 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200077 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
git-svn-id: http://src.chromium.org/svn/branches/1500/src@200112 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Fix 2 title related issues in aura port
Aura touch fix
On Tizen 3.0, the window manager seems not to support changing the window state (e.g. fullscreen, maximized) before the X window is mapped to screen.
Resolve the fullscreen issue on aura port
Uses the given DesktopRootWindowHostFactory to override the default DesktopRootWindowHost implementation for embedder. After this patch, xwalk maintains DesktopRootWindowHost inside xwalk.
…ntain DesktopRootWindowHost inside xwalk. We will perhaps make something like ui/views/widget/desktop_aura inside xwalk to satisfy our all requirements. At that time, this patch can be rollbacked.
…e xwalk maintains DesktopRootWindowHost by itself. Revert "Fix the issue that app window can not enter fullscreen mode on Tizen 3.0" Revert "Use XmbSetWMProperties to set window title for i18n issue" Revert "[Backport] Aura: enable the touch events dispatch in DesktopRootWindowHostX11" Revert "Fixup due to lint error." Revert "Make the close button can close the native app window" Revert "Add option to choose if the window border is showed"
XWalk maintains DesktopRootWindowHostXWalk copied from DesktopRootWindowHostX11 by itself.
On Tizen 2.1, the multi-touch support is different from the XInput2.2 approach. It extends the older Input2.1 spec to use multiple touch devices for multiple touch points, one touch device for one touch points. The device type name for this purpose is MULTITOUCHSCREEN which is not defined by XInput extension. This fix is to make Crosswalk be able to handle the new extension to XInput2.1 by introducing a new build option 'enable_xi21_mt'. It should be turned on for Tizen 2.1, and is exclusive to 'use_xi2_mt' option.
Fix touch support issue on Tizen 2.1
Since the approach of multi-touch support on Tizen 2.1 is compatible with XInput2 spec. It makes more sense to use 'enable_tizen21_mt' flag indicating it is specific to Tizen 2.1.
Trybot DashboardBuilding status:Finished the build of the PATCH in this pull requestThu Aug 15 2013 23:52:24 GMT+0800 (CST) [content_linux] Failed LOGS: failed update Rebuild the failed bots you want!Select the bots:
Start the building:
|
|
@rakuco for your information. |
darktears
pushed a commit
that referenced
this pull request
Sep 29, 2014
…hset #5 id:100001 of https://codereview.chromium.org/516293007/) Reason for revert: Chrome OS build with DCHECKs enabled fails on start. This CL breaks assumption, that GAIA extension can be loaded without performing IO-operations. Log and stack trace: [16275:16275:0903/161435:WARNING:renderer_freezer.cc(55)] Cgroup freezer does not exist or is not writable. Processes will not be frozen during suspend. [16275:16275:0903/161435:WARNING:configuration_policy_pref_store.cc(30)] Policy RemoteAccessClientFirewallTraversal: This policy has been deprecated. [16275:16275:0903/161437:FATAL:thread_restrictions.cc(38)] Function marked as IO-only was called from a thread that disallows IO! If this thread really should be allowed to make IO calls, adjust the call to base::ThreadRestrictions::SetIOAllowed() in this thread's startup. #0 0x7fe3122e555e base::debug::StackTrace::StackTrace() #1 0x7fe31237c462 logging::LogMessage::~LogMessage() #2 0x7fe3124824af base::ThreadRestrictions::AssertIOAllowed() #3 0x7fe3123630a1 base::PathExists() #4 0x7fe321cfd5f3 extensions::(anonymous namespace)::CollectPlatformSpecificResourceArchs() #5 0x7fe321cfad22 extensions::Extension::InitFromValue() #6 0x7fe321cfa490 extensions::Extension::Create() #7 0x7fe321cfa114 extensions::Extension::Create() #8 0x7fe3233ebe1b extensions::ComponentLoader::Load() #9 0x7fe3233ec3cf extensions::ComponentLoader::Add() #10 0x7fe3233ec32a extensions::ComponentLoader::Add() #11 0x7fe3233ec2b0 extensions::ComponentLoader::Add() #12 0x7fe32437505f (anonymous namespace)::LoadGaiaAuthExtension() #13 0x7fe324374d5e extensions::GaiaAuthExtensionLoader::LoadIfNeeded() #14 0x7fe324237f7e ScopedGaiaAuthExtension::ScopedGaiaAuthExtension() #15 0x7fe322f68bb2 chromeos::WebUILoginView::Init() #16 0x7fe322f556ef chromeos::LoginDisplayHostImpl::InitLoginWindowAndView() #17 0x7fe322f52640 chromeos::LoginDisplayHostImpl::LoadURL() #18 0x7fe322f5226a chromeos::LoginDisplayHostImpl::StartWizard() #19 0x7fe322f54acd chromeos::LoginDisplayHostImpl::StartPostponedWebUI() #20 0x7fe322f541f8 chromeos::LoginDisplayHostImpl::Observe() #21 0x7fe322f54bfd chromeos::LoginDisplayHostImpl::Observe() #22 0x7fe31b222377 content::NotificationServiceImpl::Notify() #23 0x7fe322d51a24 chromeos::(anonymous namespace)::UserWallpaperDelegate::OnWallpaperAnimationFinished() #24 0x7fe31188692f ash::RootWindowController::OnWallpaperAnimationFinished() #25 0x7fe3117c633a ash::(anonymous namespace)::ShowWallpaperAnimationObserver::OnImplicitAnimationsCompleted() #26 0x7fe311f72d30 ui::ImplicitAnimationObserver::CheckCompleted() #27 0x7fe311f72cd5 ui::ImplicitAnimationObserver::SetActive() #28 0x7fe311f965d5 ui::ScopedLayerAnimationSettings::~ScopedLayerAnimationSettings() #29 0x7fe3117c5ec7 ash::DesktopBackgroundWidgetController::StartAnimating() #30 0x7fe3117bbb0c ash::DesktopBackgroundController::InstallDesktopController() #31 0x7fe3117bbc03 ash::DesktopBackgroundController::InstallDesktopControllerForAllWindows() #32 0x7fe3117bb3cc ash::DesktopBackgroundController::SetDesktopBackgroundImageMode() #33 0x7fe3117bb096 ash::DesktopBackgroundController::SetWallpaperImage() #34 0x7fe322f9a6b9 chromeos::WallpaperManager::DoSetDefaultWallpaper() #35 0x7fe322f99b73 chromeos::WallpaperManager::PendingWallpaper::ProcessRequest() #36 0x7fe322fbac72 base::internal::RunnableAdapter<>::Run() #37 0x7fe322fbabe9 base::internal::InvokeHelper<>::MakeItSo() #38 0x7fe322fbaba5 base::internal::Invoker<>::Run() #39 0x7fe3122cc9ce base::Callback<>::Run() #40 0x7fe312488f86 base::Timer::RunScheduledTask() #41 0x7fe3124890bc base::BaseTimerTaskInternal::Run() #42 0x7fe312489382 base::internal::RunnableAdapter<>::Run() #43 0x7fe3124892ec base::internal::InvokeHelper<>::MakeItSo() #44 0x7fe312489295 base::internal::Invoker<>::Run() #45 0x7fe3122cc9ce base::Callback<>::Run() #46 0x7fe3122eb9b3 base::debug::TaskAnnotator::RunTask() #47 0x7fe3123a1c57 base::MessageLoop::RunTask() #48 0x7fe3123a1d9b base::MessageLoop::DeferOrRunPendingTask() #49 0x7fe3123a228d base::MessageLoop::DoDelayedWork() #50 0x7fe3122a1f25 base::MessagePumpGlib::Run() #51 0x7fe3123a17f0 base::MessageLoop::RunHandler() #52 0x7fe3124093b2 base::RunLoop::Run() #53 0x7fe324217e4d ChromeBrowserMainParts::MainMessageLoopRun() #54 0x7fe31ad2a8bf content::BrowserMainLoop::RunMainMessageLoopParts() #55 0x7fe31ad344c7 content::BrowserMainRunnerImpl::Run() #56 0x7fe31ad251b1 content::BrowserMain() #57 0x7fe31abb997f content::RunNamedProcessTypeMain() #58 0x7fe31abbcce8 content::ContentMainRunnerImpl::Run() #59 0x7fe31abb8ee5 content::ContentMain() #60 0x7fe3206d3505 ChromeMain #61 0x7fe3206d34b2 main Cannot upload crash dump: cannot exec /sbin/crash_reporter Crash_reporter failed to process crash report Original issue's description: > Enable forced extension updates on NaCl arch mismatch > > This makes extensions aware of the platforms for which > they have platform-specific resources installed, if any. > > This also hooks up the extension update code with some > additional logic to place an extension in forced-update > mode if it has platform-specific resources which don't > match the current NaCl architecture. > > BUG=409948 > TEST=install an extension which uses NaCl (QuickOffice for example). Rename the _platform-specific/<your-nacl-arch> directory some something else and force an update (e.g. via chrome://extensions button). Observe that a new CRX is downloaded and installed. > > Committed: https://chromium.googlesource.com/chromium/src/+/4a92281fa5d331860d65a59ba45dc882a5c71df4 [email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=409948 Review URL: https://codereview.chromium.org/532183003 Cr-Commit-Position: refs/heads/master@{#293128}
darktears
pushed a commit
that referenced
this pull request
Sep 29, 2014
…::ExecuteCommands. (patchset #1 id:1 of https://codereview.chromium.org/547783002/) Reason for revert: Broke Linux ChromiumOS Tests (dbg)(3) http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/1206 BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x7f3bcf3aa67e base::debug::StackTrace::StackTrace() #1 0x0000041c884a content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f3bc709f4a0 <unknown> #3 0x7f3bc7151a43 __poll #4 0x7f3bc7b8dff6 <unknown> #5 0x7f3bc7b8e124 g_main_context_iteration #6 0x7f3bcf366f35 base::MessagePumpGlib::Run() #7 0x7f3bcf468180 base::MessageLoop::RunHandler() #8 0x7f3bcf4cfcc2 base::RunLoop::Run() #9 0x0000041e0729 content::RunThisRunLoop() #10 0x0000041e06ba content::RunMessageLoop() #11 0x000000668feb ExtensionApiTest::ResultCatcher::GetNextResult() #12 0x0000006a30dd extensions::CommandsApiTest_ContinuePropagation_Test::RunTestOnMainThread() #13 0x0000006a3712 extensions::CommandsApiTest_ContinuePropagation_Test::RunTestOnMainThread() #14 0x00000176be8b InProcessBrowserTest::RunTestOnMainThreadLoop() #15 0x0000041c85c8 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #16 0x0000041c9cf2 base::internal::RunnableAdapter<>::Run() #17 0x0000041c9c69 base::internal::InvokeHelper<>::MakeItSo() #18 0x0000041c9c25 base::internal::Invoker<>::Run() #19 0x00000063f0de base::Callback<>::Run() #20 0x0000042dddd2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #21 0x0000042dca92 ChromeBrowserMainParts::PreMainMessageLoopRun() #22 0x000002e77daf chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #23 0x7f3bd7bd2e96 content::BrowserMainLoop::PreMainMessageLoopRun() #24 0x7f3bd7bd96f2 base::internal::RunnableAdapter<>::Run() #25 0x7f3bd7bd965c base::internal::InvokeHelper<>::MakeItSo() #26 0x7f3bd7bd960a base::internal::Invoker<>::Run() #27 0x7f3bd80a852e base::Callback<>::Run() #28 0x7f3bd841bd2b content::StartupTaskRunner::RunAllTasksNow() #29 0x7f3bd7bd12f0 content::BrowserMainLoop::CreateStartupTasks() #30 0x7f3bd7bdcc72 content::BrowserMainRunnerImpl::Initialize() #31 0x7f3bd7bcda55 content::BrowserMain() #32 0x7f3bd7a6224f content::RunNamedProcessTypeMain() #33 0x7f3bd7a655b8 content::ContentMainRunnerImpl::Run() #34 0x7f3bd7a617b5 content::ContentMain() #35 0x0000041c82cb content::BrowserTestBase::SetUp() #36 0x00000176afc3 InProcessBrowserTest::SetUp() #37 0x000000674823 ExtensionBrowserTest::SetUp() #38 0x000000674852 ExtensionBrowserTest::SetUp() #39 0x0000018298a3 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #40 0x00000181686e testing::internal::HandleExceptionsInMethodIfSupported<>() #41 0x00000180ad73 testing::Test::Run() #42 0x00000180b4cb testing::TestInfo::Run() #43 0x00000180baca testing::TestCase::Run() #44 0x000001811009 testing::internal::UnitTestImpl::RunAllTests() #45 0x0000018225b3 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #46 0x0000018185fe testing::internal::HandleExceptionsInMethodIfSupported<>() #47 0x000001810c97 testing::UnitTest::Run() #48 0x0000041a5531 RUN_ALL_TESTS() #49 0x0000041a4547 base::TestSuite::Run() #50 0x0000008026d2 InteractiveUITestSuiteRunner::RunTestSuite() #51 0x000001769618 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite() #52 0x0000041d9efb content::LaunchTests() #53 0x00000176954b LaunchChromeTests() #54 0x00000080262f main #55 0x7f3bc708a76d __libc_start_main #56 0x0000005ffda9 <unknown> [123/334] CommandsApiTest.ContinuePropagation (TIMED OUT) Original issue's description: > Fixes HasEventListener check in ExtensionKeybindingRegistry::ExecuteCommands. > > ExtensionKeybindingRegistry::ExecuteCommands functions in two distinct ways -- execute all commands based on an accelerator, or, execute an accelerator for a given extension. The former behavior is implied by passing an empty string. > > Previously, only the latter case was handled when trying to continue propagating keys. > > BUG=407163 > TEST=try bots (interactive_ui_tests --gtest_filter=CommandsApiTest.*). > > Committed: https://chromium.googlesource.com/chromium/src/+/189a2ed4d209231d517b0e64a722722dead3f17a [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=407163 Review URL: https://codereview.chromium.org/552533003 Cr-Commit-Position: refs/heads/master@{#293780}
darktears
pushed a commit
that referenced
this pull request
Sep 29, 2014
…disable GCM (patchset #8 id:150001 of https://codereview.chromium.org/561943002/) Reason for revert: this CL might be breaking browser_tests and interactive_ui_tests on ChromeOS because it's starting a request on startup. here's an example: [15345:15369:0918/132152:ERROR:leak_tracker.h(97)] Leaked 0x11cd70da7cc0 which was allocated by: [15345:15369:0918/132152:ERROR:leak_tracker.h(98)] #0 0x7f44b584025e base::debug::StackTrace::StackTrace() #1 0x000000dfc481 base::debug::LeakTracker<>::LeakTracker() #2 0x000000df3e8d SystemURLRequestContextGetter::SystemURLRequestContextGetter() #3 0x000000df57f1 IOThread::InitSystemRequestContext() #4 0x000000df570b IOThread::system_url_request_context_getter() #5 0x000001443d9e BrowserProcessImpl::system_request_context() #6 0x000001028a8e SafeBrowsingService::Initialize() #7 0x0000014462c9 BrowserProcessImpl::CreateSafeBrowsingService() #8 0x000001446196 BrowserProcessImpl::safe_browsing_service() #9 0x0000014b9a06 ChromeResourceDispatcherHostDelegate::ChromeResourceDispatcherHostDelegate() #10 0x0000014466dc BrowserProcessImpl::ResourceDispatcherHostCreated() #11 0x0000008a88e5 chrome::ChromeContentBrowserClient::ResourceDispatcherHostCreated() #12 0x7f44be489a2f content::ResourceDispatcherHostImpl::ResourceDispatcherHostImpl() #13 0x7f44be060f44 content::BrowserMainLoop::BrowserThreadsStarted() #14 0x7f44be068302 base::internal::RunnableAdapter<>::Run() #15 0x7f44be06826c base::internal::InvokeHelper<>::MakeItSo() #16 0x7f44be06821a base::internal::Invoker<>::Run() #17 0x7f44be54e46e base::Callback<>::Run() #18 0x7f44be8d223b content::StartupTaskRunner::RunAllTasksNow() #19 0x7f44be05ff97 content::BrowserMainLoop::CreateStartupTasks() #20 0x7f44be06b824 content::BrowserMainRunnerImpl::Initialize() #21 0x7f44be05c7df content::BrowserMain() #22 0x7f44bdee5f6f content::RunNamedProcessTypeMain() #23 0x7f44bdee9268 content::ContentMainRunnerImpl::Run() #24 0x7f44bdee5505 content::ContentMain() #25 0x0000041aa8cb content::BrowserTestBase::SetUp() #26 0x00000173e117 InProcessBrowserTest::SetUp() #27 0x000000671180 ExtensionBrowserTest::SetUp() #28 0x0000006711b2 ExtensionBrowserTest::SetUp() #29 0x0000017fb993 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #30 0x0000017e8bfe testing::internal::HandleExceptionsInMethodIfSupported<>() #31 0x0000017dd1e3 testing::Test::Run() #32 0x0000017dd92b testing::TestInfo::Run() #33 0x0000017ddf1a testing::TestCase::Run() #34 0x0000017e3413 testing::internal::UnitTestImpl::RunAllTests() #35 0x0000017f47d3 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #36 0x0000017ea96e testing::internal::HandleExceptionsInMethodIfSupported<>() #37 0x0000017e30b1 testing::UnitTest::Run() #38 0x000004187e41 RUN_ALL_TESTS() #39 0x000004186e67 base::TestSuite::Run() #40 0x0000007fcd62 InteractiveUITestSuiteRunner::RunTestSuite() #41 0x00000173c7b8 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite() #42 0x0000041bc2fb content::LaunchTests() #43 0x00000173c6e9 LaunchChromeTests() #44 0x0000007fccbf main #45 0x7f44ad8ed76d __libc_start_main #46 0x000000601389 <unknown> [15345:15369:0918/132152:FATAL:leak_tracker.h(102)] Check failed: 0u == count (0 vs. 1) #0 0x7f44b584025e base::debug::StackTrace::StackTrace() #1 0x7f44b58d7a62 logging::LogMessage::~LogMessage() #2 0x000000dfdd01 base::debug::LeakTracker<>::CheckForLeaks() #3 0x000000df8e13 IOThread::CleanUp() #4 0x7f44be0810b6 content::BrowserThreadImpl::CleanUp() #5 0x7f44be07e852 content::BrowserProcessSubThread::CleanUp() #6 0x7f44b59d0601 base::Thread::ThreadMain() #7 0x7f44b59bba3c base::(anonymous namespace)::ThreadFunc() #8 0x7f44b1aa9e9a start_thread #9 0x7f44ad9c03fd clone Original issue's description: > Add GCMChannelStatusSyncer to schedule requests and enable/disable GCM > > BUG=384041 > TEST=new tests added > > Committed: https://crrev.com/3c23f4a188e171998f3042ad62f4aa5717e66d63 > Cr-Commit-Position: refs/heads/master@{#295524} [email protected],[email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=384041 Review URL: https://codereview.chromium.org/582913003 Cr-Commit-Position: refs/heads/master@{#295549}
rakuco
pushed a commit
that referenced
this pull request
Oct 10, 2014
BUG=418828,419523 [email protected] Review URL: https://codereview.chromium.org/624453004 Cr-Commit-Position: refs/heads/master@{#297731} (cherry picked from commit 8c2c1ee) Review URL: https://codereview.chromium.org/628763004 Cr-Commit-Position: refs/branch-heads/2171@{#44} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
rakuco
pushed a commit
that referenced
this pull request
Jan 26, 2015
Fix for 'New Folder' is not getting added to chrome://bookmarks/ through 'Organize' menu after adding 'addPage' When we do add page then new node is added, but that node in not yet commited, and have id as 'new', so we should not consider as the selected item. Changes added so that when the entry is not commited, it should not be considered for calculating the nextIndex value. BUG=447960 Review URL: https://codereview.chromium.org/835973004 Cr-Commit-Position: refs/heads/master@{#311200} (cherry picked from commit c69c700) Review URL: https://codereview.chromium.org/860463002 Cr-Commit-Position: refs/branch-heads/2272@{#44} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco
pushed a commit
that referenced
this pull request
Mar 12, 2015
Break a circular reference which was causing FileManagerPrivateComputeChecksumFunction to never be cleaned up. This, in turn, was holding open one file stream for every file for which a content checksum was requested. BUG=458624 Review URL: https://codereview.chromium.org/950423003 Cr-Commit-Position: refs/heads/master@{#317997} (cherry picked from commit 78bb0f4) TBR=mtomasz Review URL: https://codereview.chromium.org/955313003 Cr-Commit-Position: refs/branch-heads/2311@{#44} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco
pushed a commit
that referenced
this pull request
Apr 15, 2015
[email protected] BUG=463209 Review URL: https://codereview.chromium.org/1069473003 Cr-Commit-Position: refs/heads/master@{#324519} (cherry picked from commit 5a1bb0b) Review URL: https://codereview.chromium.org/1074333002 Cr-Commit-Position: refs/branch-heads/2357@{#44} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
rakuco
pushed a commit
that referenced
this pull request
Jun 8, 2015
Our rendering path has no reasonable expectation of being able to render 1000fps content, so these are bad timestamps that end up wrecking assumptions throughout the rendering pathway. Instead of trying to guard against these frames everywhere, just discard them immediately during enqueue. BUG=488302 TEST=new unittest TBR=xhwang Review URL: https://codereview.chromium.org/1142723002 Cr-Commit-Position: refs/heads/master@{#330458} (cherry picked from commit b581477) Review URL: https://codereview.chromium.org/1153433003 Cr-Commit-Position: refs/branch-heads/2403@{#44} Cr-Branched-From: f54b809-refs/heads/master@{#330231}
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
BUG=524386 [email protected] Review URL: https://codereview.chromium.org/1319503002 Cr-Commit-Position: refs/heads/master@{#345344} (cherry picked from commit f5f469b) Review URL: https://codereview.chromium.org/1315323003 . Cr-Commit-Position: refs/branch-heads/2490@{#44} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
These metrics are keeping track of: - whether there is another audible tab when a tab becomes audible; - the maximum number of concurrent audible tab in a session; - how long there are 2 or more audible tabs at the same time. It is also recording when a tab gain or loses audible status. BUG=578049 Review URL: https://codereview.chromium.org/1591453005 Cr-Commit-Position: refs/heads/master@{#370435} (cherry picked from commit 44e4ef4) Review URL: https://codereview.chromium.org/1618523003 . Cr-Commit-Position: refs/branch-heads/2623@{#44} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
BUG=590689 Review URL: https://codereview.chromium.org/1754013002 Cr-Commit-Position: refs/heads/master@{#378638} (cherry picked from commit 6b20b22) Review URL: https://codereview.chromium.org/1756173002 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#44} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
fujunwei
pushed a commit
to fujunwei/chromium-crosswalk
that referenced
this pull request
May 27, 2016
We were asked to use Roboto-Medium on the "NEW" text, which is part of the Peek Promo. BUG=511475 Review URL: https://codereview.chromium.org/1453983003 Cr-Commit-Position: refs/heads/master@{#360275} (cherry picked from commit 64f2817) Review URL: https://codereview.chromium.org/1455303002 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#44} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
Before https://crrev.com/392652 because we included descendant overflow into container overflow and the paint invalidation rect covered the changed part of descendants. Call setNeedsPaintInvalidationSubtree() to force checking of paint invalidation of descendants when overflow clip status changes. The other changes are needed because we need to move clearPaintInvalidationFlags() after newPaintInvalidationState.updateForChildren(). Several overriding invalidateTreeIfNeeded() methods in subclasses are removed because they have been the same as inherited ones after we changed the paint invalidation tree walk order. BUG=613475 TEST=paint/invalidation/overflow-hidden-to-visible.html TEST=paint/invalidation/overflow-visible-to-hidden.html Review-Url: https://codereview.chromium.org/2000763003 Cr-Commit-Position: refs/heads/master@{#395491} Review URL: https://codereview.chromium.org/2007003003 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#44} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
Adds FrameInformation to record whether we're using a SurfaceTexture or overlay for each frame, with some information about why. This will replace Media.AVDA.FrameSentAsOverlay, once we see that it produces similar results in M62. However, since the overlay mechanism that's being measured also changed drastically in M62, I don't want to replace the measurement system at the same time. [email protected] (cherry picked from commit 5090aff) Bug: 761108 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I55999069dc798ca6cf57d0dca38951087361d29c Reviewed-on: https://chromium-review.googlesource.com/646279 Reviewed-by: Dale Curtis <[email protected]> Reviewed-by: Ilya Sherman <[email protected]> Commit-Queue: Frank Liberato <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#499110} Reviewed-on: https://chromium-review.googlesource.com/652937 Reviewed-by: Frank Liberato <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#44} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kenchris @huningxin This is a further polishment for touch issue. But please hold on until Crosswalk is released.
It is now using 'enable_tizen21_mt' flag instead of 'enable_xi21_mt' flag, and updates the comments as @kenchris reviewing comments.